Re: [PATCH net] net: ethernet: mediatek: preserve sibling PPE bindings

[Simon Horman <horms@kernel.org>]

On Tue, Oct 27, 2026 at 01:38:58AM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 1 · Medium: 0 (3) · Low: 0
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [High] The fix is incomplete: the L2_SUBFLOW branch of
>   __mtk_ppe_check_skb()…

Hi Alexander,

The issue above does seem to be of concern.
Could you please respond to it?

> 
> Pre-existing issues:
> - [Medium] This problem wasn't introduced by this patch, but L2 (bridge)
>   flows never get the 0xffff 'unbound' sentinel in entry->hash.
> - [Medium] This problem wasn't introduced by this patch, but
>   mtk_flow_offload_stats() reads entry->hash without ppe_lock: once for…
> - [Medium] This problem wasn't introduced by this patch, but the MIB read
>   sequence in mtk_mib_entry_read() is not serialized.

...