All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] hw/m68k/next-cube: Show deprecation notice to users
@ 2026-10-30 10:06 Peter Maydell
  2026-10-30 11:20 ` Richard Henderson
  2026-10-30 17:57 ` Thomas Huth
  0 siblings, 2 replies; 3+ messages in thread
From: Peter Maydell @ 2026-10-30 10:06 UTC (permalink / raw)
  To: qemu-devel; +Cc: Thomas Huth, Philippe Mathieu-Daudé

In commit 5d3333e12a034 we deprecated the next-cube machine, but
forgot to set its MachineClass::deprecation_reason. Add that, so
that anybody running the machine is shown the warning that it's
now deprecated.

Fixes: 5d3333e12a034 ("docs/about: Deprecate the 'next-cube' m68k machine")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/m68k/next-cube.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c
index d8cb4a8c23d..0d927c7b485 100644
--- a/hw/m68k/next-cube.c
+++ b/hw/m68k/next-cube.c
@@ -1370,6 +1370,7 @@ static void next_machine_class_init(ObjectClass *oc, const void *data)
     mc->default_ram_id = "next.ram";
     mc->default_cpu_type = M68K_CPU_TYPE_NAME("m68040");
     mc->no_cdrom = true;
+    mc->deprecation_reason = "machine is incomplete and cannot boot a kernel";
 }
 
 static const TypeInfo next_typeinfo = {
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] hw/m68k/next-cube: Show deprecation notice to users
  2026-10-30 10:06 [PATCH] hw/m68k/next-cube: Show deprecation notice to users Peter Maydell
@ 2026-10-30 11:20 ` Richard Henderson
  2026-10-30 17:57 ` Thomas Huth
  1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2026-10-30 11:20 UTC (permalink / raw)
  To: qemu-devel

On 10/30/26 05:06, Peter Maydell wrote:
> In commit 5d3333e12a034 we deprecated the next-cube machine, but
> forgot to set its MachineClass::deprecation_reason. Add that, so
> that anybody running the machine is shown the warning that it's
> now deprecated.
> 
> Fixes: 5d3333e12a034 ("docs/about: Deprecate the 'next-cube' m68k machine")
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
>   hw/m68k/next-cube.c | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] hw/m68k/next-cube: Show deprecation notice to users
  2026-10-30 10:06 [PATCH] hw/m68k/next-cube: Show deprecation notice to users Peter Maydell
  2026-10-30 11:20 ` Richard Henderson
@ 2026-10-30 17:57 ` Thomas Huth
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2026-10-30 17:57 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-devel, Philippe Mathieu-Daudé

Am Fri, 30 Oct 2026 10:06:59 +0000
schrieb Peter Maydell <peter.maydell@linaro.org>:

> In commit 5d3333e12a034 we deprecated the next-cube machine, but
> forgot to set its MachineClass::deprecation_reason. Add that, so
> that anybody running the machine is shown the warning that it's
> now deprecated.
> 
> Fixes: 5d3333e12a034 ("docs/about: Deprecate the 'next-cube' m68k machine")
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  hw/m68k/next-cube.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c
> index d8cb4a8c23d..0d927c7b485 100644
> --- a/hw/m68k/next-cube.c
> +++ b/hw/m68k/next-cube.c
> @@ -1370,6 +1370,7 @@ static void next_machine_class_init(ObjectClass *oc, const void *data)
>      mc->default_ram_id = "next.ram";
>      mc->default_cpu_type = M68K_CPU_TYPE_NAME("m68040");
>      mc->no_cdrom = true;
> +    mc->deprecation_reason = "machine is incomplete and cannot boot a kernel";
>  }

Reviewed-by: Thomas Huth <th.huth@posteo.eu>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-10-30 17:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-30 10:06 [PATCH] hw/m68k/next-cube: Show deprecation notice to users Peter Maydell
2026-10-30 11:20 ` Richard Henderson
2026-10-30 17:57 ` Thomas Huth

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.