drivers/clk/davinci/da8xx-cfgchip.c:766:18-25: ERROR: PTR_ERR applied after initialization to constant on line 747

drivers/clk/davinci/da8xx-cfgchip.c:766:18-25: ERROR: PTR_ERR applied after initialization to constant on line 747

[kernel test robot]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Rosen Penev <rosenp@gmail.com>
CC: Brian Masney <bmasney@redhat.com>

Hi Rosen,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   2a500a04d6f969318c05f46aedb6e73fc1963a00
commit: 551ba775497e93d93bb849f6ee572ca768cbaa3e clk: davinci: add COMPILE_TEST support
date:   8 weeks ago
:::::: branch date: 5 hours ago
:::::: commit date: 8 weeks ago
config: um-randconfig-r2103-20261031 (https://download.01.org/0day-ci/archive/20261031/202610310610.evnX1sB3-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: 551ba775497e ("clk: davinci: add COMPILE_TEST support")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202610310610.evnX1sB3-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/clk/davinci/da8xx-cfgchip.c:766:18-25: ERROR: PTR_ERR applied after initialization to constant on line 747

vim +766 drivers/clk/davinci/da8xx-cfgchip.c

1e88a8d64f2212 David Lechner 2018-03-15  741  
1e88a8d64f2212 David Lechner 2018-03-15  742  static int da8xx_cfgchip_probe(struct platform_device *pdev)
1e88a8d64f2212 David Lechner 2018-03-15  743  {
1e88a8d64f2212 David Lechner 2018-03-15  744  	struct device *dev = &pdev->dev;
1e88a8d64f2212 David Lechner 2018-03-15  745  	struct da8xx_cfgchip_clk_platform_data *pdata = dev->platform_data;
1e88a8d64f2212 David Lechner 2018-03-15  746  	da8xx_cfgchip_init clk_init = NULL;
1e88a8d64f2212 David Lechner 2018-03-15 @747  	struct regmap *regmap = NULL;
1e88a8d64f2212 David Lechner 2018-03-15  748  
409c39ec92a35e Rob Herring   2023-10-06  749  	clk_init = device_get_match_data(dev);
409c39ec92a35e Rob Herring   2023-10-06  750  	if (clk_init) {
f9848cfa4bec95 David Hunter  2024-07-20  751  		struct device_node *parent __free(device_node) = of_get_parent(dev->of_node);
1e88a8d64f2212 David Lechner 2018-03-15  752  
1e88a8d64f2212 David Lechner 2018-03-15  753  		regmap = syscon_node_to_regmap(parent);
1e88a8d64f2212 David Lechner 2018-03-15  754  	} else if (pdev->id_entry && pdata) {
1e88a8d64f2212 David Lechner 2018-03-15  755  		clk_init = (void *)pdev->id_entry->driver_data;
1e88a8d64f2212 David Lechner 2018-03-15  756  		regmap = pdata->cfgchip;
1e88a8d64f2212 David Lechner 2018-03-15  757  	}
1e88a8d64f2212 David Lechner 2018-03-15  758  
1e88a8d64f2212 David Lechner 2018-03-15  759  	if (!clk_init) {
1e88a8d64f2212 David Lechner 2018-03-15  760  		dev_err(dev, "unable to find driver data\n");
1e88a8d64f2212 David Lechner 2018-03-15  761  		return -EINVAL;
1e88a8d64f2212 David Lechner 2018-03-15  762  	}
1e88a8d64f2212 David Lechner 2018-03-15  763  
1e88a8d64f2212 David Lechner 2018-03-15  764  	if (IS_ERR_OR_NULL(regmap)) {
1e88a8d64f2212 David Lechner 2018-03-15  765  		dev_err(dev, "no regmap for CFGCHIP syscon\n");
1e88a8d64f2212 David Lechner 2018-03-15 @766  		return regmap ? PTR_ERR(regmap) : -ENOENT;
1e88a8d64f2212 David Lechner 2018-03-15  767  	}
1e88a8d64f2212 David Lechner 2018-03-15  768  
1e88a8d64f2212 David Lechner 2018-03-15  769  	return clk_init(dev, regmap);
1e88a8d64f2212 David Lechner 2018-03-15  770  }
1e88a8d64f2212 David Lechner 2018-03-15  771  

:::::: The code at line 766 was first introduced by commit
:::::: 1e88a8d64f221208801bb279ee7452df0b6d609f clk: davinci: New driver for TI DA8XX CFGCHIP clocks

:::::: TO: David Lechner <david@lechnology.com>
:::::: CC: Stephen Boyd <sboyd@kernel.org>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki