From: Jamin Lin <jamin_lin@aspeedtech.com>
To: "kraxel@redhat.com" <kraxel@redhat.com>,
"marcandre.lureau@redhat.com" <marcandre.lureau@redhat.com>,
"junjie.cao@intel.com" <junjie.cao@intel.com>,
"junjie.cao@linux.dev" <junjie.cao@linux.dev>,
"clg@kaod.org" <clg@kaod.org>,
"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Kane Chen" <kane_chen@aspeedtech.com>,
"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
"Tyrone Ting" <kfting@nuvoton.com>,
"Hao Wu" <wuhaotsh@google.com>, "Zhao Liu" <zhao1.liu@intel.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Helge Deller" <deller@gmx.de>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Anthony PERARD" <anthony@xenproject.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
Cc: Jamin Lin <jamin_lin@aspeedtech.com>, Troy Lee <troy_lee@aspeedtech.com>
Subject: [PATCH v8 08/18] hw/usb/bus: Turn off the automatic hub by default
Date: Mon, 2 Nov 2026 09:22:14 +0000 [thread overview]
Message-ID: <20261102092201.1729245-9-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20261102092201.1729245-1-jamin_lin@aspeedtech.com>
Every bus creator now sets auto_hub from its own property, or clears
it outright, so the value usb_bus_new() leaves there is never read.
Drop the line. A new bus then has no hub unless its controller asks
for one.
Suggested-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
hw/usb/bus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/usb/bus.c b/hw/usb/bus.c
index 92f67de4fe..cd587db892 100644
--- a/hw/usb/bus.c
+++ b/hw/usb/bus.c
@@ -92,7 +92,6 @@ void usb_bus_new(USBBus *bus, size_t bus_size,
qbus_set_bus_hotplug_handler(BUS(bus));
bus->ops = ops;
bus->busnr = next_usb_bus++;
- bus->auto_hub = true;
QTAILQ_INIT(&bus->free);
QTAILQ_INIT(&bus->used);
QTAILQ_INSERT_TAIL(&busses, bus, next);
--
2.43.0
next prev parent reply other threads:[~2026-11-02 9:25 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 9:22 [PATCH v8 00/18] hw/usb: Add a usbredir server transport Jamin Lin
2026-11-02 9:22 ` [PATCH v8 01/18] hw/usb/bus: Add an auto-hub flag to the USB bus Jamin Lin
2026-11-02 14:07 ` marcandre.lureau
2026-11-02 9:22 ` [PATCH v8 02/18] hw/usb/hcd-xhci: Add an auto-hub property and leave it off Jamin Lin
2026-11-02 14:07 ` marcandre.lureau
2026-11-03 14:23 ` Junjie Cao
2026-11-02 9:22 ` [PATCH v8 03/18] hw/usb/hcd-ehci: " Jamin Lin
2026-11-02 14:07 ` marcandre.lureau
2026-11-02 9:22 ` [PATCH v8 04/18] hw/usb/hcd-uhci: " Jamin Lin
2026-11-02 14:07 ` marcandre.lureau
2026-11-02 9:22 ` [PATCH v8 05/18] hw/usb/hcd-ohci: " Jamin Lin
2026-11-02 14:07 ` marcandre.lureau
2026-11-03 1:29 ` Jamin Lin
2026-11-02 9:22 ` [PATCH v8 06/18] hw/usb/hcd-dwc2: " Jamin Lin
2026-11-02 14:07 ` marcandre.lureau
2026-11-03 14:23 ` Junjie Cao
2026-11-02 9:22 ` [PATCH v8 07/18] hw/usb/xen-usb: Do not insert an automatic hub Jamin Lin
2026-11-02 14:07 ` marcandre.lureau
2026-11-02 9:22 ` Jamin Lin [this message]
2026-11-02 14:07 ` [PATCH v8 08/18] hw/usb/bus: Turn off the automatic hub by default marcandre.lureau
2026-11-02 9:22 ` [PATCH v8 09/18] hw/arm/npcm7xx: Keep the automatic hub Jamin Lin
2026-11-02 14:07 ` marcandre.lureau
2026-11-03 1:06 ` Jamin Lin
2026-11-03 14:23 ` Junjie Cao
2026-11-02 9:22 ` [PATCH v8 10/18] docs/system/devices/usb: Note the automatic hub change Jamin Lin
2026-11-02 14:07 ` marcandre.lureau
2026-11-03 14:23 ` Junjie Cao
2026-11-02 9:22 ` [PATCH v8 11/18] hw/usb/redirect-server: Add a usbredir server device Jamin Lin
2026-11-03 14:23 ` Junjie Cao
2026-11-02 9:22 ` [PATCH v8 12/18] hw/usb/redirect-server: Connect usbredirparser to a chardev Jamin Lin
2026-11-03 14:23 ` Junjie Cao
2026-11-02 9:22 ` [PATCH v8 13/18] hw/usb/redirect-server: Announce the exported device Jamin Lin
2026-11-02 14:07 ` marcandre.lureau
2026-11-03 7:14 ` Jamin Lin
2026-11-02 9:22 ` [PATCH v8 14/18] hw/usb/redirect-server: Implement control transfers Jamin Lin
2026-11-03 14:23 ` Junjie Cao
2026-11-02 9:22 ` [PATCH v8 15/18] hw/usb/redirect-server: Implement bulk and interrupt transfers Jamin Lin
2026-11-02 14:07 ` marcandre.lureau
2026-11-03 14:23 ` Junjie Cao
2026-11-02 9:22 ` [PATCH v8 16/18] hw/usb/redirect-server: Stream interrupt IN endpoints Jamin Lin
2026-11-02 14:07 ` marcandre.lureau
2026-11-02 9:22 ` [PATCH v8 17/18] hw/usb/redirect-server: Implement isochronous OUT transfers Jamin Lin
2026-11-02 14:07 ` marcandre.lureau
2026-11-03 14:23 ` Junjie Cao
2026-11-02 9:22 ` [PATCH v8 18/18] hw/arm/aspeed: Enable the usbredir server transport Jamin Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261102092201.1729245-9-jamin_lin@aspeedtech.com \
--to=jamin_lin@aspeedtech.com \
--cc=anthony@xenproject.org \
--cc=clg@kaod.org \
--cc=deller@gmx.de \
--cc=edgar.iglesias@gmail.com \
--cc=junjie.cao@intel.com \
--cc=junjie.cao@linux.dev \
--cc=kane_chen@aspeedtech.com \
--cc=kfting@nuvoton.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@oss.qualcomm.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sstabellini@kernel.org \
--cc=troy_lee@aspeedtech.com \
--cc=wuhaotsh@google.com \
--cc=xen-devel@lists.xenproject.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.