All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junjie Cao <junjie.cao@linux.dev>
To: jamin_lin@aspeedtech.com
Cc: kraxel@redhat.com, marcandre.lureau@redhat.com, clg@kaod.org,
	pierrick.bouvier@oss.qualcomm.com, peter.maydell@linaro.org,
	kane_chen@aspeedtech.com, philmd@oss.qualcomm.com,
	kfting@nuvoton.com, wuhaotsh@google.com, zhao1.liu@intel.com,
	richard.henderson@linaro.org, deller@gmx.de,
	sstabellini@kernel.org, anthony@xenproject.org,
	edgar.iglesias@gmail.com, troy_lee@aspeedtech.com,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	xen-devel@lists.xenproject.org, junjie.cao@linux.dev
Subject: Re: [PATCH v8 12/18] hw/usb/redirect-server: Connect usbredirparser to a chardev
Date: Tue,  3 Nov 2026 08:23:24 -0600	[thread overview]
Message-ID: <20261103142327.1348025-6-junjie.cao@linux.dev> (raw)
In-Reply-To: <20261102092201.1729245-13-jamin_lin@aspeedtech.com>

On Mon, Nov 02, 2026 at 09:22:20AM +0000, Jamin Lin wrote:
> The chardev handling follows hw/usb/redirect.c: take no data before the
> parser exists, do not write to a closed backend, do not re-enter the
> writer, and let a close that is still queued finish before a new
> connection opens.

Exercised the close/reopen path with usb-storage exported: three
usb-redir clients in a row on one server each get hello and
device_connect. Killing a client with SIGKILL during a direct-I/O dd
loop leaves the server running (ASan build), and a fresh client gets
sda back and reads what it wrote.

Reviewed-by: Junjie Cao <junjie.cao@linux.dev>
Tested-by: Junjie Cao <junjie.cao@linux.dev>


  reply	other threads:[~2026-11-03 14:24 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02  9:22 [PATCH v8 00/18] hw/usb: Add a usbredir server transport Jamin Lin
2026-11-02  9:22 ` [PATCH v8 01/18] hw/usb/bus: Add an auto-hub flag to the USB bus Jamin Lin
2026-11-02 14:07   ` marcandre.lureau
2026-11-02  9:22 ` [PATCH v8 02/18] hw/usb/hcd-xhci: Add an auto-hub property and leave it off Jamin Lin
2026-11-02 14:07   ` marcandre.lureau
2026-11-03 14:23   ` Junjie Cao
2026-11-02  9:22 ` [PATCH v8 03/18] hw/usb/hcd-ehci: " Jamin Lin
2026-11-02 14:07   ` marcandre.lureau
2026-11-02  9:22 ` [PATCH v8 04/18] hw/usb/hcd-uhci: " Jamin Lin
2026-11-02 14:07   ` marcandre.lureau
2026-11-02  9:22 ` [PATCH v8 05/18] hw/usb/hcd-ohci: " Jamin Lin
2026-11-02 14:07   ` marcandre.lureau
2026-11-03  1:29     ` Jamin Lin
2026-11-02  9:22 ` [PATCH v8 06/18] hw/usb/hcd-dwc2: " Jamin Lin
2026-11-02 14:07   ` marcandre.lureau
2026-11-03 14:23   ` Junjie Cao
2026-11-02  9:22 ` [PATCH v8 07/18] hw/usb/xen-usb: Do not insert an automatic hub Jamin Lin
2026-11-02 14:07   ` marcandre.lureau
2026-11-02  9:22 ` [PATCH v8 08/18] hw/usb/bus: Turn off the automatic hub by default Jamin Lin
2026-11-02 14:07   ` marcandre.lureau
2026-11-02  9:22 ` [PATCH v8 09/18] hw/arm/npcm7xx: Keep the automatic hub Jamin Lin
2026-11-02 14:07   ` marcandre.lureau
2026-11-03  1:06     ` Jamin Lin
2026-11-03 14:23   ` Junjie Cao
2026-11-02  9:22 ` [PATCH v8 10/18] docs/system/devices/usb: Note the automatic hub change Jamin Lin
2026-11-02 14:07   ` marcandre.lureau
2026-11-03 14:23   ` Junjie Cao
2026-11-02  9:22 ` [PATCH v8 11/18] hw/usb/redirect-server: Add a usbredir server device Jamin Lin
2026-11-03 14:23   ` Junjie Cao
2026-11-02  9:22 ` [PATCH v8 12/18] hw/usb/redirect-server: Connect usbredirparser to a chardev Jamin Lin
2026-11-03 14:23   ` Junjie Cao [this message]
2026-11-02  9:22 ` [PATCH v8 13/18] hw/usb/redirect-server: Announce the exported device Jamin Lin
2026-11-02 14:07   ` marcandre.lureau
2026-11-03  7:14     ` Jamin Lin
2026-11-02  9:22 ` [PATCH v8 14/18] hw/usb/redirect-server: Implement control transfers Jamin Lin
2026-11-03 14:23   ` Junjie Cao
2026-11-02  9:22 ` [PATCH v8 15/18] hw/usb/redirect-server: Implement bulk and interrupt transfers Jamin Lin
2026-11-02 14:07   ` marcandre.lureau
2026-11-03 14:23   ` Junjie Cao
2026-11-02  9:22 ` [PATCH v8 16/18] hw/usb/redirect-server: Stream interrupt IN endpoints Jamin Lin
2026-11-02 14:07   ` marcandre.lureau
2026-11-02  9:22 ` [PATCH v8 17/18] hw/usb/redirect-server: Implement isochronous OUT transfers Jamin Lin
2026-11-02 14:07   ` marcandre.lureau
2026-11-03 14:23   ` Junjie Cao
2026-11-02  9:22 ` [PATCH v8 18/18] hw/arm/aspeed: Enable the usbredir server transport Jamin Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261103142327.1348025-6-junjie.cao@linux.dev \
    --to=junjie.cao@linux.dev \
    --cc=anthony@xenproject.org \
    --cc=clg@kaod.org \
    --cc=deller@gmx.de \
    --cc=edgar.iglesias@gmail.com \
    --cc=jamin_lin@aspeedtech.com \
    --cc=kane_chen@aspeedtech.com \
    --cc=kfting@nuvoton.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@oss.qualcomm.com \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sstabellini@kernel.org \
    --cc=troy_lee@aspeedtech.com \
    --cc=wuhaotsh@google.com \
    --cc=xen-devel@lists.xenproject.org \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.