All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonhoe Kim <26rote@gmail.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>, vkoul@kernel.org
Cc: neil.armstrong@linaro.org, mani@kernel.org,
	dmitry.baryshkov@oss.qualcomm.com, val@packett.cool,
	wesley.cheng@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
	linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] phy: qcom: qmp-combo: Leave the USB PCS alone in DP-only mode
Date: Tue,  3 Nov 2026 07:04:56 +0900	[thread overview]
Message-ID: <20261102220456.1687-1-26rote@gmail.com> (raw)
In-Reply-To: <6cd9240d-5628-4c35-b7ca-bbbae7f62fe9@oss.qualcomm.com>

On 11/2/26 10:34 PM, Konrad Dybcio wrote:
> On 10/23/26 2:35 PM, Joonhoe Kim wrote:
[...]
>> On a Lenovo Y700 Gen 5 (TB323FU, Kaanapali) with a USB-C monitor
>> in pin assignment C, resume from s2idle fails with "phy initialization
>> timed-out", the dwc3 resume returns -110 and the following xHCI resume
>> hangs the system.
>
> This sounds like a gap in the DWC3 driver, we should bail out of r/w
> any registers if resume failed

Agreed, that is a separate problem. This patch only removes the PHY
timeout behind the -110 in this case.

I need to correct the last part, though. The hang was with an
out-of-tree dwc3 change that passes power_lost to xhci-plat. With it,
xhci_resume() went into xhci_reset() with the long timeout and
interrupts off. I haven't checked what mainline does after the failed
dwc3 resume. In v3 I'll end that paragraph with "the dwc3 resume
returns -110 and USB stops working".

Thanks,
Joonhoe Kim

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Joonhoe Kim <26rote@gmail.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>, vkoul@kernel.org
Cc: neil.armstrong@linaro.org, mani@kernel.org,
	dmitry.baryshkov@oss.qualcomm.com, val@packett.cool,
	wesley.cheng@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
	linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] phy: qcom: qmp-combo: Leave the USB PCS alone in DP-only mode
Date: Tue,  3 Nov 2026 07:04:56 +0900	[thread overview]
Message-ID: <20261102220456.1687-1-26rote@gmail.com> (raw)
In-Reply-To: <6cd9240d-5628-4c35-b7ca-bbbae7f62fe9@oss.qualcomm.com>

On 11/2/26 10:34 PM, Konrad Dybcio wrote:
> On 10/23/26 2:35 PM, Joonhoe Kim wrote:
[...]
>> On a Lenovo Y700 Gen 5 (TB323FU, Kaanapali) with a USB-C monitor
>> in pin assignment C, resume from s2idle fails with "phy initialization
>> timed-out", the dwc3 resume returns -110 and the following xHCI resume
>> hangs the system.
>
> This sounds like a gap in the DWC3 driver, we should bail out of r/w
> any registers if resume failed

Agreed, that is a separate problem. This patch only removes the PHY
timeout behind the -110 in this case.

I need to correct the last part, though. The hang was with an
out-of-tree dwc3 change that passes power_lost to xhci-plat. With it,
xhci_resume() went into xhci_reset() with the long timeout and
interrupts off. I haven't checked what mainline does after the failed
dwc3 resume. In v3 I'll end that paragraph with "the dwc3 resume
returns -110 and USB stops working".

Thanks,
Joonhoe Kim

  reply	other threads:[~2026-11-02 22:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-23 12:35 [PATCH v2] phy: qcom: qmp-combo: Leave the USB PCS alone in DP-only mode Joonhoe Kim
2026-10-23 12:35 ` Joonhoe Kim
2026-10-27 11:20 ` Abel Vesa
2026-10-27 11:20   ` Abel Vesa
2026-11-01 11:06 ` Manivannan Sadhasivam
2026-11-01 11:06   ` Manivannan Sadhasivam
2026-11-02 13:32 ` Konrad Dybcio
2026-11-02 13:32   ` Konrad Dybcio
2026-11-02 22:04   ` Joonhoe Kim
2026-11-02 22:04     ` Joonhoe Kim
2026-11-02 13:34 ` Konrad Dybcio
2026-11-02 13:34   ` Konrad Dybcio
2026-11-02 22:04   ` Joonhoe Kim [this message]
2026-11-02 22:04     ` Joonhoe Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261102220456.1687-1-26rote@gmail.com \
    --to=26rote@gmail.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mani@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=val@packett.cool \
    --cc=vkoul@kernel.org \
    --cc=wesley.cheng@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.