* [PATCH] crypto: sa2ul - remove redundant 0x prefixes
@ 2026-11-03 21:32 Thorsten Blum
0 siblings, 0 replies; only message in thread
From: Thorsten Blum @ 2026-11-03 21:32 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, Keerthy, Tero Kristo
Cc: Thorsten Blum, linux-crypto, linux-kernel
The %pad format specifier already includes the 0x prefix. Remove the
redundant prefixes to avoid printing 0x0x.
Also remove the duplicate colon from the security context dump message.
Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver")
Fixes: 2dc53d004745 ("crypto: sa2ul - add sha1/sha256/sha512 support")
Fixes: d2c8ac187fc9 ("crypto: sa2ul - Add AEAD algorithm support")
Signed-off-by: Thorsten Blum <blum@kernel.org>
---
drivers/crypto/sa2ul.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c
index 4557eae94164..e026fc14a411 100644
--- a/drivers/crypto/sa2ul.c
+++ b/drivers/crypto/sa2ul.c
@@ -652,7 +652,7 @@ void sa_set_swinfo(u8 eng_id, u16 sc_id, dma_addr_t sc_phys,
static void sa_dump_sc(u8 *buf, dma_addr_t dma_addr)
{
#ifdef DEBUG
- dev_info(sa_k3_dev, "Security context dump:: 0x%pad\n", &dma_addr);
+ dev_info(sa_k3_dev, "Security context dump: %pad\n", &dma_addr);
print_hex_dump(KERN_CONT, "", DUMP_PREFIX_OFFSET,
16, 1, buf, SA_CTX_MAX_SZ, false);
#endif
@@ -781,7 +781,7 @@ static void sa_cipher_cra_exit(struct crypto_skcipher *tfm)
struct sa_tfm_ctx *ctx = crypto_skcipher_ctx(tfm);
struct sa_crypto_data *data = dev_get_drvdata(sa_k3_dev);
- dev_dbg(sa_k3_dev, "%s(0x%p) sc-ids(0x%x(0x%pad), 0x%x(0x%pad))\n",
+ dev_dbg(sa_k3_dev, "%s(0x%p) sc-ids(0x%x(%pad), 0x%x(%pad))\n",
__func__, tfm, ctx->enc.sc_id, &ctx->enc.sc_phys,
ctx->dec.sc_id, &ctx->dec.sc_phys);
@@ -822,7 +822,7 @@ static int sa_cipher_cra_init(struct crypto_skcipher *tfm)
crypto_skcipher_set_reqsize(tfm, crypto_skcipher_reqsize(child) +
sizeof(struct skcipher_request));
- dev_dbg(sa_k3_dev, "%s(0x%p) sc-ids(0x%x(0x%pad), 0x%x(0x%pad))\n",
+ dev_dbg(sa_k3_dev, "%s(0x%p) sc-ids(0x%x(%pad), 0x%x(%pad))\n",
__func__, tfm, ctx->enc.sc_id, &ctx->enc.sc_phys,
ctx->dec.sc_id, &ctx->dec.sc_phys);
return 0;
@@ -1447,7 +1447,7 @@ static int sa_sha_cra_init_alg(struct crypto_tfm *tfm, const char *alg_base)
}
}
- dev_dbg(sa_k3_dev, "%s(0x%p) sc-ids(0x%x(0x%pad), 0x%x(0x%pad))\n",
+ dev_dbg(sa_k3_dev, "%s(0x%p) sc-ids(0x%x(%pad), 0x%x(%pad))\n",
__func__, tfm, ctx->enc.sc_id, &ctx->enc.sc_phys,
ctx->dec.sc_id, &ctx->dec.sc_phys);
@@ -1584,7 +1584,7 @@ static void sa_sha_cra_exit(struct crypto_tfm *tfm)
struct sa_tfm_ctx *ctx = crypto_tfm_ctx(tfm);
struct sa_crypto_data *data = dev_get_drvdata(sa_k3_dev);
- dev_dbg(sa_k3_dev, "%s(0x%p) sc-ids(0x%x(0x%pad), 0x%x(0x%pad))\n",
+ dev_dbg(sa_k3_dev, "%s(0x%p) sc-ids(0x%x(%pad), 0x%x(%pad))\n",
__func__, tfm, ctx->enc.sc_id, &ctx->enc.sc_phys,
ctx->dec.sc_id, &ctx->dec.sc_phys);
@@ -1664,7 +1664,7 @@ static int sa_cra_init_aead(struct crypto_aead *tfm, const char *fallback)
return ret;
}
- dev_dbg(sa_k3_dev, "%s(0x%p) sc-ids(0x%x(0x%pad), 0x%x(0x%pad))\n",
+ dev_dbg(sa_k3_dev, "%s(0x%p) sc-ids(0x%x(%pad), 0x%x(%pad))\n",
__func__, tfm, ctx->enc.sc_id, &ctx->enc.sc_phys,
ctx->dec.sc_id, &ctx->dec.sc_phys);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-03 21:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-03 21:32 [PATCH] crypto: sa2ul - remove redundant 0x prefixes Thorsten Blum
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.