[PATCH] test: skip metadata-write-rounding with pages larger than 4KiB

[PATCH] test: skip metadata-write-rounding with pages larger than 4KiB

[Itai Handler]

On kernels configured with 64KiB pages, pvcreate in the test fails:

  Metadata area size too small: 66560 bytes. It must be at least 524288 bytes.

The metadata area starts at the page size and is at least 8 pages long,
so it can end one logical block after 64KiB, as the test needs, only
with 4KiB pages.  Skip the test with larger pages.

Fixes: 669e2f2b6ccf ("label: don't round writes past the logical block size")
Assisted-by: LLM
---
The layout cannot simply follow the page size: the first PE has to
start within the first 128KiB of the PV, which lvm reads before asking
for confirmation, and with 16KiB or larger pages the metadata area alone
extends past that.

Tested with 4KiB pages on x86_64, where the test passes as before, and
with 64KiB pages on arm64, where it is now skipped.

v2 of "blkio: fix writes when the logical block size is not 512 or
4096", which I am sending next, extends the same test and applies on
top of this patch.

 test/shell/metadata-write-rounding.sh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/test/shell/metadata-write-rounding.sh b/test/shell/metadata-write-rounding.sh
index 7bc2da2eb..ac33a7960 100644
--- a/test/shell/metadata-write-rounding.sh
+++ b/test/shell/metadata-write-rounding.sh
@@ -20,6 +20,11 @@
 
 . lib/inittest --skip-with-lvmpolld --skip-with-lvmlockd
 
+# The metadata area starts at the page size and is at least 8 pages
+# long, so it can end one logical block after 64KiB, as below, only with
+# 4KiB pages.
+test "$(getconf PAGESIZE)" -le 4096 || skip "page size larger than 4KiB"
+
 mkfifo fifo
 
 for bs in 1024 2048 ; do

base-commit: 7ea850a1419522cc0c8096d718551015465322d2
-- 
2.34.1

Re: [PATCH] test: skip metadata-write-rounding with pages larger than 4KiB

[Zdenek Kabelac]

Dne 04. 11. 26 v 7:57 Itai Handler napsal(a):
> On kernels configured with 64KiB pages, pvcreate in the test fails:
> 
>    Metadata area size too small: 66560 bytes. It must be at least 524288 bytes.
> 
> The metadata area starts at the page size and is at least 8 pages long,
> so it can end one logical block after 64KiB, as the test needs, only
> with 4KiB pages.  Skip the test with larger pages.
> 
Hi

Here I've my local repo with longer list of test fixes for 64K pages - this 
will be pushed to origin once it will be polished.

Regards

Zdenek