* [PATCH] tests/lcitool: Switch to a newer version of netmap and check it out faster
@ 2026-11-06 6:31 Thomas Huth
2026-11-06 8:07 ` Pierrick Bouvier
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2026-11-06 6:31 UTC (permalink / raw)
To: Alex Bennée, Pierrick Bouvier; +Cc: qemu-devel, Daniel P . Berrangé
Netmap v11.3 is from 2017, so this is way older than the oldest version
of other features that we support in QEMU. The newest tagged version is
v13.0 which is from 2019 - still old, but at least it's the newest one
with a version number, so let's use that instead.
While we're at it, also make sure to check out only the revision that we
need, so we don't waste bandwidth by downloading the whole repository here.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/lcitool/refresh | 4 ++--
tests/docker/dockerfiles/debian.docker | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/lcitool/refresh b/tests/lcitool/refresh
index 94cab24bbdb..b54b4e3ac78 100755
--- a/tests/lcitool/refresh
+++ b/tests/lcitool/refresh
@@ -117,8 +117,8 @@ RUN apt update && \
cscope\
global\
linux-headers-generic
-RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap
-RUN cd /usr/src/netmap && git checkout v11.3
+RUN git clone -cadvice.detachedHead=false --branch=v13.0 --depth=1 \
+ https://github.com/luigirizzo/netmap.git /usr/src/netmap
RUN cd /usr/src/netmap/LINUX && \
./configure --no-drivers --no-apps \
--kernel-dir=$(ls -d /usr/src/linux-headers-*-$(dpkg --print-architecture)) \
diff --git a/tests/docker/dockerfiles/debian.docker b/tests/docker/dockerfiles/debian.docker
index ce591feec21..aeed90523c7 100644
--- a/tests/docker/dockerfiles/debian.docker
+++ b/tests/docker/dockerfiles/debian.docker
@@ -161,8 +161,8 @@ RUN apt update && \
cscope\
global\
linux-headers-generic
-RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap
-RUN cd /usr/src/netmap && git checkout v11.3
+RUN git clone -cadvice.detachedHead=false --branch=v13.0 --depth=1 \
+ https://github.com/luigirizzo/netmap.git /usr/src/netmap
RUN cd /usr/src/netmap/LINUX && \
./configure --no-drivers --no-apps \
--kernel-dir=$(ls -d /usr/src/linux-headers-*-$(dpkg --print-architecture)) \
--
2.56.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/lcitool: Switch to a newer version of netmap and check it out faster
2026-11-06 6:31 [PATCH] tests/lcitool: Switch to a newer version of netmap and check it out faster Thomas Huth
@ 2026-11-06 8:07 ` Pierrick Bouvier
2026-11-06 8:18 ` Thomas Huth
0 siblings, 1 reply; 3+ messages in thread
From: Pierrick Bouvier @ 2026-11-06 8:07 UTC (permalink / raw)
To: Thomas Huth, Alex Bennée; +Cc: qemu-devel, Daniel P . Berrangé
On 11/5/26 11:31 PM, Thomas Huth wrote:
> Netmap v11.3 is from 2017, so this is way older than the oldest version
> of other features that we support in QEMU. The newest tagged version is
> v13.0 which is from 2019 - still old, but at least it's the newest one
> with a version number, so let's use that instead.
>
> While we're at it, also make sure to check out only the revision that we
> need, so we don't waste bandwidth by downloading the whole repository here.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/lcitool/refresh | 4 ++--
> tests/docker/dockerfiles/debian.docker | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
I'll send it when trunk reopens, except if you consider it as a fix for
current release.
Regards,
Pierrick
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tests/lcitool: Switch to a newer version of netmap and check it out faster
2026-11-06 8:07 ` Pierrick Bouvier
@ 2026-11-06 8:18 ` Thomas Huth
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2026-11-06 8:18 UTC (permalink / raw)
To: Pierrick Bouvier, Alex Bennée; +Cc: qemu-devel, Daniel P . Berrangé
On 06/11/2026 09.07, Pierrick Bouvier wrote:
> On 11/5/26 11:31 PM, Thomas Huth wrote:
>> Netmap v11.3 is from 2017, so this is way older than the oldest version
>> of other features that we support in QEMU. The newest tagged version is
>> v13.0 which is from 2019 - still old, but at least it's the newest one
>> with a version number, so let's use that instead.
>>
>> While we're at it, also make sure to check out only the revision that we
>> need, so we don't waste bandwidth by downloading the whole repository here.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> tests/lcitool/refresh | 4 ++--
>> tests/docker/dockerfiles/debian.docker | 4 ++--
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>
>
> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
>
> I'll send it when trunk reopens, except if you consider it as a fix for
> current release.
No, it's fine, this can wait for QEMU v12.0.
Thanks,
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-06 8:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-06 6:31 [PATCH] tests/lcitool: Switch to a newer version of netmap and check it out faster Thomas Huth
2026-11-06 8:07 ` Pierrick Bouvier
2026-11-06 8:18 ` Thomas Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.