All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Di Maio <luca@edera.dev>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Luca Di Maio" <luca@edera.dev>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Roger Pau Monné" <roger@xenproject.org>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Julien Grall" <julien@xen.org>,
	"Bertrand Marquis" <bertrand.marquis@arm.com>,
	"Michal Orzel" <michal.orzel@amd.com>,
	"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
	"Anthony PERARD" <anthony.perard@vates.tech>,
	xen-devel@lists.xenproject.org,
	"Teddy Astie" <teddy.astie@vates.tech>
Subject: Re: [PATCH 1/3] IOMMU: record the flushes skipped under iommu_dont_flush_iotlb
Date: Fri,  6 Nov 2026 09:03:22 +0100	[thread overview]
Message-ID: <20261106080324.2145220-1-luca@edera.dev> (raw)
In-Reply-To: <2d444072-e4cb-40ff-b2f5-a6e5038e64c9@suse.com>

On 02/11/2026 17:54, Jan Beulich wrote:
> On 31.10.2026 11:55, Teddy Astie wrote:
>> Le 30/10/2026 à 17:53, Luca Di Maio a écrit :
>>> +DEFINE_PER_CPU(uint8_t, iommu_skipped_flush_flags);
>>
>> flush_flags in iotlb_flush is unsigned int in iommu_iotlb_flush(), so I
>> would use it here as well instead of uint8_t.
>
> +1
>
> Also see ./CODING_STYLE on the matter. If not unsigned int, the next choices
> would be unsigned short or unsigned char, not uint8_t.

Thanks for the review, Jan and Teddy.

I'll address your comments in upcoming v2.

L.


  reply	other threads:[~2026-11-06  8:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30 16:50 [PATCH 0/3] x86/HVM: batch the flushes of grant unmaps Luca Di Maio
2026-10-30 16:50 ` [PATCH 1/3] IOMMU: record the flushes skipped under iommu_dont_flush_iotlb Luca Di Maio
2026-10-31 10:55   ` Teddy Astie
2026-11-02 16:54     ` Jan Beulich
2026-11-06  8:03       ` Luca Di Maio [this message]
2026-11-02 17:04   ` Jan Beulich
2026-10-30 16:50 ` [PATCH 2/3] x86/HVM: defer IOTLB flushes across a grant unmap batch Luca Di Maio
2026-10-31 11:08   ` Teddy Astie
2026-10-30 16:50 ` [PATCH 3/3] x86/HVM: defer p2m TLB " Luca Di Maio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261106080324.2145220-1-luca@edera.dev \
    --to=luca@edera.dev \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=anthony.perard@vates.tech \
    --cc=bertrand.marquis@arm.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=michal.orzel@amd.com \
    --cc=roger@xenproject.org \
    --cc=sstabellini@kernel.org \
    --cc=teddy.astie@vates.tech \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.