Re: [PATCH 1/3] IOMMU: record the flushes skipped under iommu_dont_flush_iotlb

[Jan Beulich <jbeulich@suse.com>]

On 31.10.2026 11:55, Teddy Astie wrote:
> Le 30/10/2026 à 17:53, Luca Di Maio a écrit :
>> --- a/xen/drivers/passthrough/iommu.c
>> +++ b/xen/drivers/passthrough/iommu.c
>> @@ -64,6 +64,11 @@ bool __read_mostly iommu_hap_pt_share = true;
>>   bool __read_mostly iommu_debug;
>>   
>>   DEFINE_PER_CPU(bool, iommu_dont_flush_iotlb);
>> +/*
>> + * A byte holds every IOMMU_FLUSHF_*, and fits in the alignment padding the
>> + * bool above leaves, instead of shifting the per-CPU data that follows.
>> + */
>> +DEFINE_PER_CPU(uint8_t, iommu_skipped_flush_flags);
> 
> flush_flags in iotlb_flush is unsigned int in iommu_iotlb_flush(), so I 
> would use it here as well instead of uint8_t.

+1

Also see ./CODING_STYLE on the matter. If not unsigned int, the next choices
would be unsigned short or unsigned char, not uint8_t.

Jan