[PATCH 6/6] usb: musb-new: da8xx: Free the controller if the host probe fails

[Yuho Choi <oss.patchbox@gmail.com>]

da8xx_musb_probe() allocates the struct musb with musb_init_controller()
and returns the error when musb_lowlevel_init() fails, for example when
no device is connected. The error path turns off the PHY and the PSC but
does not free the struct musb, and the driver core then frees the
private data that holds the only pointer to it. Each 'usb reset', or
'usb start' after 'usb stop', probes the controller again and leaks
another one.

Free the struct musb when musb_lowlevel_init() fails.

Fixes: 5608331d8136 ("usb: musb-new: Add support for da8xx-musb")
Signed-off-by: Yuho Choi <oss.patchbox@gmail.com>
---
Build-tested only, with omapl138_lcdk_defconfig.

da8xx_musb_remove() does not free the struct musb either; that is not
changed here.

 drivers/usb/musb-new/da8xx.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/musb-new/da8xx.c b/drivers/usb/musb-new/da8xx.c
index 7caf03cc2e1..17a953c9744 100644
--- a/drivers/usb/musb-new/da8xx.c
+++ b/drivers/usb/musb-new/da8xx.c
@@ -319,6 +319,8 @@ static int da8xx_musb_probe(struct udevice *dev)
 
 	if (ret == 0)
 		return 0;
+
+	free(host->host);
 shutdown:
 	/* Turn off the phy if we fail */
 	generic_phy_power_off(&plat->phy);
-- 
2.43.0