Re: [PATCH 0/6] usb: musb-new: Free the controller if the host probe fails

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]

On Fri, Nov 06, 2026 at 02:45:52PM -0500, Yuho Choi wrote:

> The MUSB glue drivers below allocate the struct musb with
> musb_init_controller() in their host probe and return the error when
> musb_lowlevel_init() fails, for example when no device is connected.
> None of them frees the struct musb on that path, and the driver core
> then frees the private data that holds the only pointer to it, so each
> 'usb reset', or 'usb start' after 'usb stop', leaks another one. This
> series frees it in ux500, sc5xx, pic32, omap2430, ti-musb and da8xx.
> 
> The same fix for sunxi and mt85xx was sent as separate patches:
> "usb: musb-new: sunxi: Free the controller if the host probe fails"
> "usb: musb-new: mt85xx: Free the controller if the host probe fails"
> 
> The patches are independent of each other. They are build-tested only,
> as noted in each patch, and pic32 is not built at all. None was tested
> on hardware.

How are you finding and investigating these issues, exactly? To cut to
the chase, this series (and the other two patches) sure seem like what
happens when someone sends an LLM to look for resource leaks. Which are
not great. But the bigger concern is if we handle the error case
correctly. Thanks.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]