All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chad Aldreda <ca@modelmiser.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Nicolas Palix <nicolas.palix@imag.fr>,
	cocci@inria.fr, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coccinelle: api: add a checker for device nodes in devm_ memory
Date: Fri, 06 Nov 2026 21:07:48 +0000	[thread overview]
Message-ID: <20261106210740.3317795-2-ca@modelmiser.com> (raw)
In-Reply-To: <5f30dd50-a764-8e8-8b27-5c26ad10a7dd@inria.fr>

On Fri, 6 Nov 2026, Julia Lawall wrote:
> Have you sent any patches based on the results?  I'm not an expert on the
> problem being addressed, so it would be helpful to know that the semantic
> patch has led to patches that have been accepted.

Not yet. I'll send fixes for a few of the reported drivers first, and
post v2 once some of them have been reviewed, with links to them.

> The problem you have when you work on a subdirectory is that it doesn't
> know where to find the header files.  It should work better with a -I
> option.

I tried that, but the header (ipu6-isys.h) is in the same directory as
the .c file. With --include-headers, -I include, -I include/uapi and
-I arch/x86/include, on drivers/media/pci/intel/ipu6:

  --dir, with or without -I drivers/media/pci/intel/ipu6:  no report
  the directory's .c files named on the command line:     ipu6-isys.c:990

make coccicheck M=drivers/media/pci/intel/ipu6 loses it too. It seems to
come from --dir rather than the include path: in a copy holding the
headers and ipu6-isys.c, --dir reports line 990, but adding
ipu6-isys-csi2.c, which also includes ipu6-isys.h, loses it. Unless I
am using -I wrongly, is the header matched only for the first file that
includes it?

> Could you rewrite this in a much more concise format?

Yes, I'll do that in v2.

> Since you only support org and report, you don't really need depends on
> org || report everywhere.

Thanks, I'll drop them.

Chad


WARNING: multiple messages have this Message-ID (diff)
From: Chad Aldreda <ca@modelmiser.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Nicolas Palix <nicolas.palix@imag.fr>,
	cocci@inria.fr, linux-kernel@vger.kernel.org
Subject: Re: [cocci] [PATCH] coccinelle: api: add a checker for device nodes in devm_ memory
Date: Fri, 06 Nov 2026 21:07:48 +0000	[thread overview]
Message-ID: <20261106210740.3317795-2-ca@modelmiser.com> (raw)
In-Reply-To: <5f30dd50-a764-8e8-8b27-5c26ad10a7dd@inria.fr>

On Fri, 6 Nov 2026, Julia Lawall wrote:
> Have you sent any patches based on the results?  I'm not an expert on the
> problem being addressed, so it would be helpful to know that the semantic
> patch has led to patches that have been accepted.

Not yet. I'll send fixes for a few of the reported drivers first, and
post v2 once some of them have been reviewed, with links to them.

> The problem you have when you work on a subdirectory is that it doesn't
> know where to find the header files.  It should work better with a -I
> option.

I tried that, but the header (ipu6-isys.h) is in the same directory as
the .c file. With --include-headers, -I include, -I include/uapi and
-I arch/x86/include, on drivers/media/pci/intel/ipu6:

  --dir, with or without -I drivers/media/pci/intel/ipu6:  no report
  the directory's .c files named on the command line:     ipu6-isys.c:990

make coccicheck M=drivers/media/pci/intel/ipu6 loses it too. It seems to
come from --dir rather than the include path: in a copy holding the
headers and ipu6-isys.c, --dir reports line 990, but adding
ipu6-isys-csi2.c, which also includes ipu6-isys.h, loses it. Unless I
am using -I wrongly, is the header matched only for the first file that
includes it?

> Could you rewrite this in a much more concise format?

Yes, I'll do that in v2.

> Since you only support org and report, you don't really need depends on
> org || report everywhere.

Thanks, I'll drop them.

Chad


  reply	other threads:[~2026-11-06 21:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 19:35 [PATCH] coccinelle: api: add a checker for device nodes in devm_ memory Chad Aldreda
2026-11-06 19:35 ` [cocci] " Chad Aldreda
2026-11-06 20:20 ` Julia Lawall
2026-11-06 20:20   ` Julia Lawall
2026-11-06 21:07   ` Chad Aldreda [this message]
2026-11-06 21:07     ` [cocci] " Chad Aldreda
2026-11-07  9:10   ` Markus Elfring
2026-11-07 10:55 ` Markus Elfring
2026-11-07 10:55   ` [cocci] " Markus Elfring
2026-11-07 13:40 ` Markus Elfring
2026-11-07 14:37 ` Markus Elfring
2026-11-08 20:10 ` Julia Lawall
2026-11-08 20:10   ` [cocci] " Julia Lawall
2026-11-08 20:36   ` Chad Aldreda
2026-11-08 20:36     ` [cocci] " Chad Aldreda
2026-11-10 17:56 ` [PATCH v2] coccinelle: api: add a checker for device nodes in devm memory Chad Aldreda
2026-11-10 17:56   ` [cocci] " Chad Aldreda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261106210740.3317795-2-ca@modelmiser.com \
    --to=ca@modelmiser.com \
    --cc=cocci@inria.fr \
    --cc=julia.lawall@inria.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.palix@imag.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.