Re: [PATCH v2 1/4] iio: light: ltr501: Switch to read_avail() op from manual attribute registration

[Joshua Crofts <crofts@kernel.org>]

On Sat, 7 Nov 2026 12:10:06 +0200
Svyatoslav Ryhel <clamor95@gmail.com> wrote:
...

> IIO_CHAN_INFO_SCALE is by type and IIO_CHAN_INFO_INT_TIME and
> IIO_CHAN_INFO_SAMP_FREQ by all
> 
> > The current way the two Intensity channels is done is very odd.
> > The .info_mask_shared_by_type should be the same for both of them
> > (only one set of attrs will be created).
> > Ideally fix that as a precursor patch (don't label it as a fix
> > though as it's just a code consistency thing rather than actually
> > resulting in a change.)
> >  
> 
> No more precursor patches! I am just a random contributor, not a
> driver author, not a subsystem maintainer, not even a random code
> janitor. Stop using me for random unrelated fixes!

It's not an attempt to use you as a janitor; reviewers often suggest
cleanups in the adjacent code so that no new patches are built on
inconsistent code patterns.

Nevertheless, it's only a suggestion, so it's no problem if you don't
have the time or just want to focus on adding new functionality.

-- 
Kind regards,
Joshua Crofts