Re: [PATCH v2 2/4] iio: light: ltr501: Switch to modern match mechanism

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] iio: light: ltr501: unintended sysfs name change in
  ltr501_probe()
--

commit 1e03d9253f6f315d8f95ed562a39ab7edc44ec2b
Author: Svyatoslav Ryhel <clamor95@gmail.com>

iio: light: ltr501: Switch to modern match mechanism

This commit replaces the chip enum and array with per-chip info structs
retrieved via i2c_get_match_data().

> diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c
> index cc5d7af44d77c..d5ce6468a229b 100644
> --- a/drivers/iio/light/ltr501.c
> +++ b/drivers/iio/light/ltr501.c

[ ... ]

> @@ -1480,18 +1471,10 @@ static int ltr501_probe(struct i2c_client *client)
>  	if (ret < 0)
>  		return ret;
>  
> -	if (id) {
> -		name = id->name;
> -		chip_idx = id->driver_data;
> -	} else {
> -		name = iio_get_acpi_device_name_and_data(&client->dev, &ddata);
> -		chip_idx = (intptr_t)ddata;
> -	}
> -	if (!name)
> +	data->chip_info = i2c_get_match_data(client);
> +	if (!data->chip_info)
>  		return -ENODEV;
>  
> -	data->chip_info = &ltr501_chip_info_tbl[chip_idx];
> -
>  	if ((partid >> 4) != data->chip_info->partid)
>  		return -ENODEV;
>  
> @@ -1502,7 +1485,7 @@ static int ltr501_probe(struct i2c_client *client)
>  	indio_dev->info = &ltr501_info;
>  	indio_dev->channels = data->chip_info->channels;
>  	indio_dev->num_channels = data->chip_info->no_channels;
> -	indio_dev->name = name;
> +	indio_dev->name = client->name;
>  	indio_dev->modes = INDIO_DIRECT_MODE;

[Severity: Medium]
Does assigning client->name to indio_dev->name change the exported IIO
sysfs device name on ACPI systems?

Previously, iio_get_acpi_device_name_and_data() returned
dev_name(&client->dev), which is "i2c-LTER0301:00" or "i2c-LTER0303:00".
For ACPI-enumerated I2C clients, i2c_acpi_get_info() populates
client->name from the ACPI device name without the "i2c-" prefix
("LTER0301:00" / "LTER0303:00"), altering the user-visible
/sys/bus/iio/devices/iio:deviceX/name attribute (neither preserving the
legacy ACPI name nor using the canonical chip name from chip_info).

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106091943.35783-1-clamor95@gmail.com?part=2