From: Steven Rostedt <rostedt@goodmis.org>
To: Temitope obabi <obabitemitope765@gmail.com>
Cc: outreachy@lists.linux.dev, julianbraha@gmail.com
Subject: Re: [PATCH v3] rxrpc: Remove unused rxrpc_drop_ack tracepoint
Date: Sat, 7 Nov 2026 13:12:49 -0500 [thread overview]
Message-ID: <20261107131249.69e8ff4d@fedora> (raw)
In-Reply-To: <20261102183847.38109-1-obabitemitope765@gmail.com>
On Mon, 2 Nov 2026 20:38:46 +0200
Temitope obabi <obabitemitope765@gmail.com> wrote:
> The only call to trace_rxrpc_drop_ack(), in rxrpc_send_ACK(), was removed
> by commit 5e6ef4f1017c ("rxrpc: Make the I/O thread take over the call and
> local processor work"). The tracepoint is no longer reached by any caller.
>
> Removing this tracepoint avoids keeping unused tracing code and makes the
> code easier to maintain. Each defined tracepoint also takes up around 5K of
> code and data, even when it is never used.
>
> Fixes: 5e6ef4f1017c ("rxrpc: Make the I/O thread take over the call and local processor work")
> Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>
LGTM.
-- Steve
next prev parent reply other threads:[~2026-11-07 18:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 18:38 [PATCH v3] rxrpc: Remove unused rxrpc_drop_ack tracepoint Temitope obabi
2026-11-07 18:12 ` Steven Rostedt [this message]
2026-11-07 18:20 ` Julia Lawall
-- strict thread matches above, loose matches on Subject: below --
2026-11-07 20:56 Temitope obabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261107131249.69e8ff4d@fedora \
--to=rostedt@goodmis.org \
--cc=julianbraha@gmail.com \
--cc=obabitemitope765@gmail.com \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.