[PATCH v3] rxrpc: Remove unused rxrpc_drop_ack tracepoint

[PATCH v3] rxrpc: Remove unused rxrpc_drop_ack tracepoint

[Temitope obabi]

The only call to trace_rxrpc_drop_ack(), in rxrpc_send_ACK(), was removed
by commit 5e6ef4f1017c ("rxrpc: Make the I/O thread take over the call and
local processor work"). The tracepoint is no longer reached by any caller.

Removing this tracepoint avoids keeping unused tracing code and makes the
code easier to maintain. Each defined tracepoint also takes up around 5K of
code and data, even when it is never used.

Fixes: 5e6ef4f1017c ("rxrpc: Make the I/O thread take over the call and local processor work")
Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>
---
Changes in v3:
- Added a Fixes tag.
- Wrapped the commit message at 76 characters.
- Clarified that the 5K refers to both code and data.

 include/trace/events/rxrpc.h | 29 -----------------------------
 1 file changed, 29 deletions(-)

diff --git a/include/trace/events/rxrpc.h b/include/trace/events/rxrpc.h
index 56dc9b614071..ec145da21ca8 100644
--- a/include/trace/events/rxrpc.h
+++ b/include/trace/events/rxrpc.h
@@ -1837,35 +1837,6 @@ TRACE_EVENT(rxrpc_send_ack,
 		      __entry->serial)
 	    );
 
-TRACE_EVENT(rxrpc_drop_ack,
-	    TP_PROTO(struct rxrpc_call *call, enum rxrpc_propose_ack_trace why,
-		     u8 ack_reason, rxrpc_serial_t serial, bool nobuf),
-
-	    TP_ARGS(call, why, ack_reason, serial, nobuf),
-
-	    TP_STRUCT__entry(
-		    __field(unsigned int,			call)
-		    __field(enum rxrpc_propose_ack_trace,	why)
-		    __field(rxrpc_serial_t,			serial)
-		    __field(u8,					ack_reason)
-		    __field(bool,				nobuf)
-			     ),
-
-	    TP_fast_assign(
-		    __entry->call	= call->debug_id;
-		    __entry->why	= why;
-		    __entry->serial	= serial;
-		    __entry->ack_reason	= ack_reason;
-		    __entry->nobuf	= nobuf;
-			   ),
-
-	    TP_printk("c=%08x %s %s r=%08x nbf=%u",
-		      __entry->call,
-		      __print_symbolic(__entry->why, rxrpc_propose_ack_traces),
-		      __print_symbolic(__entry->ack_reason, rxrpc_ack_names),
-		      __entry->serial, __entry->nobuf)
-	    );
-
 TRACE_EVENT(rxrpc_retransmit,
 	    TP_PROTO(struct rxrpc_call *call,
 		     struct rxrpc_send_data_req *req,
-- 
2.53.0

Re: [PATCH v3] rxrpc: Remove unused rxrpc_drop_ack tracepoint

[Steven Rostedt]

On Mon,  2 Nov 2026 20:38:46 +0200
Temitope obabi <obabitemitope765@gmail.com> wrote:

> The only call to trace_rxrpc_drop_ack(), in rxrpc_send_ACK(), was removed
> by commit 5e6ef4f1017c ("rxrpc: Make the I/O thread take over the call and
> local processor work"). The tracepoint is no longer reached by any caller.
> 
> Removing this tracepoint avoids keeping unused tracing code and makes the
> code easier to maintain. Each defined tracepoint also takes up around 5K of
> code and data, even when it is never used.
> 
> Fixes: 5e6ef4f1017c ("rxrpc: Make the I/O thread take over the call and local processor work")
> Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>

LGTM.

-- Steve

Re: [PATCH v3] rxrpc: Remove unused rxrpc_drop_ack tracepoint

[Julia Lawall]

On Sat, 7 Nov 2026, Steven Rostedt wrote:

> On Mon,  2 Nov 2026 20:38:46 +0200
> Temitope obabi <obabitemitope765@gmail.com> wrote:
>
> > The only call to trace_rxrpc_drop_ack(), in rxrpc_send_ACK(), was removed
> > by commit 5e6ef4f1017c ("rxrpc: Make the I/O thread take over the call and
> > local processor work"). The tracepoint is no longer reached by any caller.
> >
> > Removing this tracepoint avoids keeping unused tracing code and makes the
> > code easier to maintain. Each defined tracepoint also takes up around 5K of
> > code and data, even when it is never used.
> >
> > Fixes: 5e6ef4f1017c ("rxrpc: Make the I/O thread take over the call and local processor work")
> > Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>
>
> LGTM.

Temitope, this means that you are now free to resubmit the patch to the
maintainers that you find with get_maintainer.  There is no guarantee that
the patch will be accepted by the end of the application period, but it
should be accepted eventually.

julia

[PATCH v3] rxrpc: Remove unused rxrpc_drop_ack tracepoint

[Temitope obabi]

The only call to trace_rxrpc_drop_ack(), in rxrpc_send_ACK(), was removed
by commit 5e6ef4f1017c ("rxrpc: Make the I/O thread take over the call and
local processor work"). The tracepoint is no longer reached by any caller.

Removing this tracepoint avoids keeping unused tracing code and makes the
code easier to maintain. Each defined tracepoint also takes up around 5K of
code and data, even when it is never used.

Fixes: 5e6ef4f1017c ("rxrpc: Make the I/O thread take over the call and local processor work")
Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>
---
 include/trace/events/rxrpc.h | 29 -----------------------------
 1 file changed, 29 deletions(-)

diff --git a/include/trace/events/rxrpc.h b/include/trace/events/rxrpc.h
index 56dc9b614071..ec145da21ca8 100644
--- a/include/trace/events/rxrpc.h
+++ b/include/trace/events/rxrpc.h
@@ -1837,35 +1837,6 @@ TRACE_EVENT(rxrpc_send_ack,
 		      __entry->serial)
 	    );
 
-TRACE_EVENT(rxrpc_drop_ack,
-	    TP_PROTO(struct rxrpc_call *call, enum rxrpc_propose_ack_trace why,
-		     u8 ack_reason, rxrpc_serial_t serial, bool nobuf),
-
-	    TP_ARGS(call, why, ack_reason, serial, nobuf),
-
-	    TP_STRUCT__entry(
-		    __field(unsigned int,			call)
-		    __field(enum rxrpc_propose_ack_trace,	why)
-		    __field(rxrpc_serial_t,			serial)
-		    __field(u8,					ack_reason)
-		    __field(bool,				nobuf)
-			     ),
-
-	    TP_fast_assign(
-		    __entry->call	= call->debug_id;
-		    __entry->why	= why;
-		    __entry->serial	= serial;
-		    __entry->ack_reason	= ack_reason;
-		    __entry->nobuf	= nobuf;
-			   ),
-
-	    TP_printk("c=%08x %s %s r=%08x nbf=%u",
-		      __entry->call,
-		      __print_symbolic(__entry->why, rxrpc_propose_ack_traces),
-		      __print_symbolic(__entry->ack_reason, rxrpc_ack_names),
-		      __entry->serial, __entry->nobuf)
-	    );
-
 TRACE_EVENT(rxrpc_retransmit,
 	    TP_PROTO(struct rxrpc_call *call,
 		     struct rxrpc_send_data_req *req,
-- 
2.53.0