[Buildroot] [PATCH v4 13/15] package/linux-pam: fix linking with the NLS and atomic libraries

From: Angelo Compagnucci <angelo.compagnucci@gmail.com>
To: buildroot@buildroot.org
Cc: "Joseph Kogut" <joseph.kogut@gmail.com>,
	"Marcus Folkesson" <marcus.folkesson@gmail.com>,
	"Leo Yu-Chi Liang" <ycliang@andestech.com>,
	"Romain Naour" <romain.naour@gmail.com>,
	"Antoine Tenart" <atenart@kernel.org>,
	"José Luis Salvador Rufo" <salvador.joseluis@gmail.com>,
	"Ricardo Martincoski" <ricardo.martincoski@datacom.com.br>,
	"Fabrice Fontaine" <fontaine.fabrice@gmail.com>,
	"Maxim Kochetkov" <fido_max@inbox.ru>,
	"Angelo Compagnucci" <angelo.compagnucci@gmail.com>,
	"Francois Perrad" <francois.perrad.86@gmail.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"James Knight" <james.d.knight@live.com>,
	"Giulio Benetti" <giulio.benetti@benettiengineering.com>,
	"Bernd Kuhls" <bernd@kuhls.net>
Subject: [Buildroot] [PATCH v4 13/15] package/linux-pam: fix linking with the NLS and atomic libraries
Date: Sat,  7 Nov 2026 17:34:12 +0100	[thread overview]
Message-ID: <20261107163414.560896-14-angelo.compagnucci@gmail.com> (raw)
In-Reply-To: <20261107163414.560896-1-angelo.compagnucci@gmail.com>

Since the move to meson in 30e38505e4 ("package/linux-pam: security
bump to version 1.7.2"), LINUX_PAM_LIBS is passed through
LINUX_PAM_MAKE_OPTS, which the meson infra does not use. So linux-pam
is linked neither with $(TARGET_NLS_LIBS), when the gettext functions
come from an external libintl, nor with -latomic, added in f1a47904b6
("package/linux-pam: link with -latomic when needed") for pam_keyinit.

This breaks the build when libintl is external, for example on musl
with NLS:

  ld: libpam_misc/libpam_misc.so.0.82.1.p/misc_conv.c.o: in function `misc_conv':
  misc_conv.c:(.text+0xa40): undefined reference to `libintl_dgettext'

Pass the libraries through LINUX_PAM_LDFLAGS, which the meson infra
puts in the cross-compilation file, as done for example by gcr.

The meson build of linux-pam is also in 2026.02.x, so the problem
affects 2026.02.x and later.

Fixes:
https://autobuild.buildroot.net/results/455/455da16d91d6f87a1a7d412c4b1e0de403c5cbcf/

Fixes: 30e38505e4bc6f8313509bdee2418024693088fa ("package/linux-pam: security bump to version 1.7.2")
Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
---
Changes v3 -> v4:
  - new patch: fix a file warned about by the package infra checks
    added at the end of the series.

 package/linux-pam/linux-pam.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/linux-pam/linux-pam.mk b/package/linux-pam/linux-pam.mk
index a4be4fa3b6..844ca2a1fe 100644
--- a/package/linux-pam/linux-pam.mk
+++ b/package/linux-pam/linux-pam.mk
@@ -19,7 +19,7 @@ LINUX_PAM_DEPENDENCIES = host-flex host-pkgconf \
 LINUX_PAM_LICENSE = BSD-3-Clause
 LINUX_PAM_LICENSE_FILES = Copyright
 LINUX_PAM_LIBS = $(TARGET_NLS_LIBS)
-LINUX_PAM_MAKE_OPTS += LIBS="$(LINUX_PAM_LIBS)"
+LINUX_PAM_LDFLAGS = $(TARGET_LDFLAGS) $(LINUX_PAM_LIBS)
 LINUX_PAM_CPE_ID_VENDOR = linux-pam
 
 ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
-- 
2.53.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
