Re: [Buildroot] [PATCH v4 12/15] package/libglib2/libglib2-bootstrap: drop unused variables

From: Fiona Klute via buildroot <buildroot@buildroot.org>
To: Angelo Compagnucci <angelo.compagnucci@gmail.com>,
	buildroot@buildroot.org
Cc: "Joseph Kogut" <joseph.kogut@gmail.com>,
	"Marcus Folkesson" <marcus.folkesson@gmail.com>,
	"Leo Yu-Chi Liang" <ycliang@andestech.com>,
	"Romain Naour" <romain.naour@gmail.com>,
	"Antoine Tenart" <atenart@kernel.org>,
	"José Luis Salvador Rufo" <salvador.joseluis@gmail.com>,
	"Ricardo Martincoski" <ricardo.martincoski@datacom.com.br>,
	"Fabrice Fontaine" <fontaine.fabrice@gmail.com>,
	"Maxim Kochetkov" <fido_max@inbox.ru>,
	"Francois Perrad" <francois.perrad.86@gmail.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"James Knight" <james.d.knight@live.com>,
	"Giulio Benetti" <giulio.benetti@benettiengineering.com>,
	"Bernd Kuhls" <bernd@kuhls.net>
Subject: Re: [Buildroot] [PATCH v4 12/15] package/libglib2/libglib2-bootstrap: drop unused variables
Date: Wed, 11 Nov 2026 23:46:40 +0100	[thread overview]
Message-ID: <4bbdf61e-541c-4c19-b168-cc33717fa2f1@gmx.de> (raw)
In-Reply-To: <20261107163414.560896-13-angelo.compagnucci@gmail.com>

Am 07.11.26 um 17:34 schrieb Angelo Compagnucci:
> Two variables of libglib2-bootstrap are not used:
> 
> - LIBGLIB2_BOOTSTRAP_VERSION_MAJOR, set when the package was added in
>    11aa1cfa5a ("package/{gobject-introspection, libglib2}: bump to
>    {1.82.0, 2.82.4}"), is not referenced anywhere;
> - LIBGLIB2_BOOTSTRAP_POST_INSTALL_TARGET_HOOKS are never run since
>    866462e8dd ("package/libglib2/libglib2-bootstrap: do not install to
>    target") set LIBGLIB2_BOOTSTRAP_INSTALL_TARGET = NO.
> 
> Drop them.
> 
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>

Reviewed-by: Fiona Klute <fiona.klute@gmx.de>

Thanks for cleaning up!

> ---
> Changes v3 -> v4:
>    - new patch: fix a file warned about by the package infra checks
>      added at the end of the series.
> 
>   package/libglib2/libglib2-bootstrap/libglib2-bootstrap.mk | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/package/libglib2/libglib2-bootstrap/libglib2-bootstrap.mk b/package/libglib2/libglib2-bootstrap/libglib2-bootstrap.mk
> index 1e512fd7ed..856e7e697d 100644
> --- a/package/libglib2/libglib2-bootstrap/libglib2-bootstrap.mk
> +++ b/package/libglib2/libglib2-bootstrap/libglib2-bootstrap.mk
> @@ -16,7 +16,6 @@
>   # The bootstrap package is an implementation detail that nothing
>   # except gobject-introspection should depend on.
>   
> -LIBGLIB2_BOOTSTRAP_VERSION_MAJOR = $(LIBGLIB2_VERSION_MAJOR)
>   LIBGLIB2_BOOTSTRAP_VERSION = $(LIBGLIB2_VERSION)
>   LIBGLIB2_BOOTSTRAP_SOURCE = $(LIBGLIB2_SOURCE)
>   LIBGLIB2_BOOTSTRAP_SITE = $(LIBGLIB2_SITE)
> @@ -53,8 +52,6 @@ LIBGLIB2_BOOTSTRAP_MESON_EXTRA_PROPERTIES = \
>   	have_c99_snprintf=true \
>   	have_unix98_printf=true
>   
> -LIBGLIB2_BOOTSTRAP_POST_INSTALL_TARGET_HOOKS = $(LIBGLIB2_POST_INSTALL_TARGET_HOOKS)
> -
>   HOST_LIBGLIB2_BOOTSTRAP_DEPENDENCIES = \
>   	host-gettext \
>   	host-libffi \
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot