All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mohamed Mediouni <mohamed@unpredictable.fr>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, Mohamed Mediouni <mohamed@unpredictable.fr>,
	Pedro Barbuda <pbarbuda@microsoft.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>,
	Boden Randin <bodenrandin1@gmail.com>
Subject: [PULL 07/13] whpx: i386: avoid updating hflags for vmexits
Date: Sun,  8 Nov 2026 02:53:57 -0700	[thread overview]
Message-ID: <20261108095403.70813-8-mohamed@unpredictable.fr> (raw)
In-Reply-To: <20261108095403.70813-1-mohamed@unpredictable.fr>

From: Boden Randin <bodenrandin1@gmail.com>

whpx_get_registers_for_vmexit only refreshes GPRs, RIP and RFLAGS.

x86_update_hflags() depends on state not refreshed here, while the code
using the fast runtime state does not depend on the hflags it recomputes.

Signed-off-by: Boden Randin <bodenrandin1@gmail.com>
Reviewed-by: Mohamed Mediouni <mohamed@unpredictable.fr>
---
 target/i386/whpx/whpx-all.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c
index d13513985c..65e56d32fa 100644
--- a/target/i386/whpx/whpx-all.c
+++ b/target/i386/whpx/whpx-all.c
@@ -772,8 +772,6 @@ static void whpx_get_registers_for_vmexit(CPUState *cpu, WHPXStateLevel level)
     rflags_to_lflags(env);
 
     assert(idx == RTL_NUMBER_OF(whpx_register_names_for_vmexit));
-
-    x86_update_hflags(env);
 }
 
 static void whpx_get_legacy_fp_registers(CPUState *cpu, WHPXStateLevel level)
-- 
2.54.0 (Apple Git-157)



  parent reply	other threads:[~2026-11-08  9:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08  9:53 [PULL 00/13] Whpx fix 0 patches Mohamed Mediouni
2026-11-08  9:53 ` [PULL 01/13] target/i386/whpx: fix VMX capability MSR values Mohamed Mediouni
2026-11-08  9:53 ` [PULL 02/13] target/i386/whpx: whpx_get_xsave_state error handling Mohamed Mediouni
2026-11-08  9:53 ` [PULL 03/13] whpx: i386: get APIC state before VM save Mohamed Mediouni
2026-11-08  9:53 ` [PULL 04/13] whpx: i386: fix TPR encodings for local APIC Mohamed Mediouni
2026-11-08  9:53 ` [PULL 05/13] whpx: i386: save/restore xss Mohamed Mediouni
2026-11-08  9:53 ` [PULL 06/13] whpx: i386: make nested virtualisation init failure non-fatal Mohamed Mediouni
2026-11-08  9:53 ` Mohamed Mediouni [this message]
2026-11-08  9:53 ` [PULL 08/13] target/i386/whpx: handle processor reset Mohamed Mediouni
2026-11-08  9:53 ` [PULL 09/13] target/arm/whpx: " Mohamed Mediouni
2026-11-08  9:54 ` [PULL 10/13] whpx: i386: forward the dynamic EBX of CPUID[0xD] sub-leaves 0 and 1, not 1 and 2 Mohamed Mediouni
2026-11-08  9:54 ` [PULL 11/13] whpx: i386: do not require ProcessorFeaturesBanks on legacy Windows Mohamed Mediouni
2026-11-08  9:54 ` [PULL 12/13] whpx: i386: fall back to xAPIC when the MSR exit bitmap is unavailable Mohamed Mediouni
2026-11-08  9:54 ` [PULL 13/13] whpx: i386: also save debug registers Mohamed Mediouni
2026-11-08 19:01 ` [PULL 00/13] Whpx fix 0 patches Alex Bennée
2026-11-09  0:41   ` Mohamed Mediouni
  -- strict thread matches above, loose matches on Subject: below --
2026-11-09  0:40 [PULL 00/13] whpx: QEMU 11.2 pull request Mohamed Mediouni
2026-11-09  0:41 ` [PULL 07/13] whpx: i386: avoid updating hflags for vmexits Mohamed Mediouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261108095403.70813-8-mohamed@unpredictable.fr \
    --to=mohamed@unpredictable.fr \
    --cc=bodenrandin1@gmail.com \
    --cc=pbarbuda@microsoft.com \
    --cc=peter.maydell@linaro.org \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.