All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lance Yang <lance.yang@linux.dev>
To: songmuchun@bytedance.com
Cc: david@kernel.org, maddy@linux.ibm.com, rppt@kernel.org,
	akpm@linux-foundation.org, lance.yang@linux.dev,
	mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org,
	ritesh.list@gmail.com, sshegde@linux.ibm.com, osalvador@suse.de,
	qi.zheng@linux.dev, muchun.song@linux.dev, chenhuacai@kernel.org,
	kernel@xen0n.name, linux-mm@kvack.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-riscv@lists.infradead.org, x86@kernel.org,
	loongarch@lists.linux.dev, linux-s390@vger.kernel.org
Subject: Re: [PATCH v3 4/5] mm/sparse-vmemmap: drop vmemmap_can_optimize()
Date: Mon,  9 Nov 2026 13:48:23 +0800	[thread overview]
Message-ID: <20261109054823.45056-1-lance.yang@linux.dev> (raw)
In-Reply-To: <20261107043122.25650-5-songmuchun@bytedance.com>


On Sat, Nov 07, 2026 at 12:31:21PM +0800, Muchun Song wrote:
>section_vmemmap_optimizable() can already decide whether a section uses
>vmemmap optimization based on the section compound order. The DAX-specific
>vmemmap_can_optimize() helper duplicates that policy, so remove it to
>simplify the code.
>
>Signed-off-by: Muchun Song <songmuchun@bytedance.com>
>---

With the arch fallbacks handled by the previous patches, we can just drop
vmemmap_can_optimize() now ;)

Nothing jumped out at me, so:

Reviewed-by: Lance Yang <lance.yang@linux.dev>


WARNING: multiple messages have this Message-ID (diff)
From: Lance Yang <lance.yang@linux.dev>
To: songmuchun@bytedance.com
Cc: david@kernel.org, maddy@linux.ibm.com, rppt@kernel.org,
	akpm@linux-foundation.org, lance.yang@linux.dev,
	mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org,
	ritesh.list@gmail.com, sshegde@linux.ibm.com, osalvador@suse.de,
	qi.zheng@linux.dev, muchun.song@linux.dev, chenhuacai@kernel.org,
	kernel@xen0n.name, linux-mm@kvack.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-riscv@lists.infradead.org, x86@kernel.org,
	loongarch@lists.linux.dev, linux-s390@vger.kernel.org
Subject: Re: [PATCH v3 4/5] mm/sparse-vmemmap: drop vmemmap_can_optimize()
Date: Mon,  9 Nov 2026 13:48:23 +0800	[thread overview]
Message-ID: <20261109054823.45056-1-lance.yang@linux.dev> (raw)
In-Reply-To: <20261107043122.25650-5-songmuchun@bytedance.com>


On Sat, Nov 07, 2026 at 12:31:21PM +0800, Muchun Song wrote:
>section_vmemmap_optimizable() can already decide whether a section uses
>vmemmap optimization based on the section compound order. The DAX-specific
>vmemmap_can_optimize() helper duplicates that policy, so remove it to
>simplify the code.
>
>Signed-off-by: Muchun Song <songmuchun@bytedance.com>
>---

With the arch fallbacks handled by the previous patches, we can just drop
vmemmap_can_optimize() now ;)

Nothing jumped out at me, so:

Reviewed-by: Lance Yang <lance.yang@linux.dev>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2026-11-09  5:48 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07  4:31 [PATCH v3 0/5] mm: Simplify device DAX vmemmap optimization plumbing Muchun Song
2026-11-07  4:31 ` Muchun Song
2026-11-07  4:31 ` [PATCH v3 1/5] powerpc/mm: make vmemmap_populate_compound_pages() static Muchun Song
2026-11-07  4:31   ` Muchun Song
2026-11-07 17:22   ` Oscar Salvador (SUSE)
2026-11-07 17:22     ` Oscar Salvador (SUSE)
2026-11-07  4:31 ` [PATCH v3 2/5] powerpc/mm: drop powerpc vmemmap_can_optimize() Muchun Song
2026-11-07  4:31   ` Muchun Song
2026-11-07 17:41   ` Oscar Salvador (SUSE)
2026-11-07 17:41     ` Oscar Salvador (SUSE)
2026-11-09  4:26   ` Lance Yang
2026-11-09  4:26     ` Lance Yang
2026-11-07  4:31 ` [PATCH v3 3/5] loongarch/mm: disable device DAX vmemmap optimization Muchun Song
2026-11-07  4:31   ` Muchun Song
2026-11-09  4:33   ` Lance Yang
2026-11-09  4:33     ` Lance Yang
2026-11-07  4:31 ` [PATCH v3 4/5] mm/sparse-vmemmap: drop vmemmap_can_optimize() Muchun Song
2026-11-07  4:31   ` Muchun Song
2026-11-09  5:48   ` Lance Yang [this message]
2026-11-09  5:48     ` Lance Yang
2026-11-09  9:20   ` Oscar Salvador (SUSE)
2026-11-09  9:20     ` Oscar Salvador (SUSE)
2026-11-07  4:31 ` [PATCH v3 5/5] mm/sparse-vmemmap: drop @pgmap from vmemmap population APIs Muchun Song
2026-11-07  4:31   ` Muchun Song
2026-11-09  6:16   ` Lance Yang
2026-11-09  6:16     ` Lance Yang
2026-11-09  9:24   ` Oscar Salvador (SUSE)
2026-11-09  9:24     ` Oscar Salvador (SUSE)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261109054823.45056-1-lance.yang@linux.dev \
    --to=lance.yang@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=chenhuacai@kernel.org \
    --cc=chleroy@kernel.org \
    --cc=david@kernel.org \
    --cc=kernel@xen0n.name \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=loongarch@lists.linux.dev \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=muchun.song@linux.dev \
    --cc=npiggin@gmail.com \
    --cc=osalvador@suse.de \
    --cc=qi.zheng@linux.dev \
    --cc=ritesh.list@gmail.com \
    --cc=rppt@kernel.org \
    --cc=songmuchun@bytedance.com \
    --cc=sshegde@linux.ibm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.