Re: [PATCH v2 2/4] rtc: Add StarFive JH7110 RTC driver

From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: E Shattow <e@freeshell.de>
Cc: "Owen O'Hehir" <oo.hehir@gmail.com>,
	linux-rtc@vger.kernel.org, "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Emil Renner Berthing" <kernel@esmil.dk>,
	"Paul Walmsley" <pjw@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	"Hal Feng" <hal.feng@starfivetech.com>,
	"ziv.xu" <ziv.xu@starfivetech.com>,
	"Conor Dooley" <conor@kernel.org>,
	"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Subject: Re: [PATCH v2 2/4] rtc: Add StarFive JH7110 RTC driver
Date: Mon, 9 Nov 2026 17:29:19 +0100	[thread overview]
Message-ID: <202611091629193b8f049c@mail.local> (raw)
In-Reply-To: <ff0906c3-478e-4ad6-ac30-1e0a7cc35a41@freeshell.de>

On 08/11/2026 19:12:58-0800, E Shattow wrote:
> > +static const struct of_device_id jh7110_rtc_of_match[] = {
> > +	{ .compatible = "starfive,jh7110-rtc" },
> > +	{ }
> > +};
> > +MODULE_DEVICE_TABLE(of, jh7110_rtc_of_match);
> > +
> > +static struct platform_driver jh7110_rtc_driver = {
> > +	.driver = {
> > +		.name = "jh7110-rtc",
> > +		.of_match_table = jh7110_rtc_of_match,
> > +	},
> > +	.probe = jh7110_rtc_probe,
> > +};
> > +module_platform_driver(jh7110_rtc_driver);
> 
> I note that JH7100 does not mention RTC in its datasheet. Does JH7110
> RTC have any commonality with JHB100 and if so then would rtc-starfive
> be a more suitable name for the code filename and module?
> 

The filename has to be soc specific, else we will end up with
rtc-starfive.c, rtc-starfive2.c, etc... when the vendor choose to change
the IP.

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com