Re: [PATCH v2 03/19] USB: Lock registered interfaces during manual driver binding

[Leon Romanovsky <leon@kernel.org>]

On Tue, Nov 10, 2026 at 07:35:13AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [High] usb: core: unlocked dev->driver updates in
>   usb_driver_claim_interface()
> --
> 
> commit aa47d25b59fe6dc15ab05e899c754ff4b6a72894
> Author: Leon Romanovsky <leon@kernel.org>
> 
> USB: Lock registered interfaces during manual driver binding
> 
> This commit locks registered USB interfaces around device_bind_driver() in
> usb_driver_claim_interface() and updates btusb_mtk_claim_iso_intf() to acquire
> the USB device lock instead of the target interface lock.
> 
> > diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
> > index d3a61ebc6afb0..ad5d9d5fc7598 100644
> > --- a/drivers/usb/core/driver.c
> > +++ b/drivers/usb/core/driver.c
> > @@ -584,8 +584,11 @@ int usb_driver_claim_interface(struct usb_driver *driver,
> >  	/* if interface was already added, bind now; else let
> >  	 * the future device_add() bind it, bypassing probe()
> >  	 */
> > -	if (device_is_registered(dev))
> > +	if (device_is_registered(dev)) {
> > +		device_lock(dev);
> >  		retval = device_bind_driver(dev);
> > +		device_unlock(dev);
> > +	}
> >  
> >  	if (retval) {
> >  		dev->driver = NULL;
> 
> [Severity: High]
> Does taking device_lock(dev) only around device_bind_driver() leave
> dev->driver and the interface binding state unprotected on a registered
> interface?

Yes, the thing is that behaviour existed before, but no problem, let's
try to fix it in separate patch.

Thanks