Re: [PATCH RFC 1/2] riscv: dts: spacemit: k1: add PowerVR GPU device node

From: Yixun Lan <dlan@kernel.org>
To: Iker Pedrosa <ikerpedrosam@gmail.com>
Cc: Alessio Belle <alessio.belle@imgtec.com>,
	Luigi Santivetti <luigi.santivetti@imgtec.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	imagination@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	spacemit@lists.linux.dev
Subject: Re: [PATCH RFC 1/2] riscv: dts: spacemit: k1: add PowerVR GPU device node
Date: Wed, 11 Nov 2026 00:47:32 +0000	[thread overview]
Message-ID: <20261111004732-GKB2005@kernel.org> (raw)
In-Reply-To: <20261015-orangepi-gpu-v1-1-03566a615660@gmail.com>

Hi Iker,

You could drop "RFC" prefix next time..

This patch generally looks good, while note that it has to
wait for power domain to be kicked in

On 20:56 Thu 15 Oct     , Iker Pedrosa wrote:
> Add device tree node for the Imagination Technologies PowerVR Rogue GPU
      ~~~~~~~~~~~~~~~~~~~~ drop, it's redundant and obvious

> (BVNC 36.29.52.182 / BXE-2-32) found in the Spacemit K1 SoC.
> 
> The GPU is located at address 0xcac00000 and uses:
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        drop, too much detail and not really worth mention in commit message

> - CLK_GPU for core clock from APMU controller
> - RESET_GPU for reset control from APMU controller
> - K1_PMDOMAIN_GPU for power management from syscon_apmu provider
> - IRQ 75 for interrupt handling
> 
..
> Disabled by default; boards enable it individually.
> 
As GPU is integrated within SoC, I'd rather see it enabled by default,
so will not only one specific board befenit from this patch,
besides, I see no reason why people should disable it by default?

> Signed-off-by: Iker Pedrosa <ikerpedrosam@gmail.com>
> ---
>  arch/riscv/boot/dts/spacemit/k1.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/spacemit/k1.dtsi b/arch/riscv/boot/dts/spacemit/k1.dtsi
> index 3fabfd34114b..82cade2f76fe 100644
> --- a/arch/riscv/boot/dts/spacemit/k1.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k1.dtsi
> @@ -5,6 +5,7 @@
>  
>  #include <dt-bindings/clock/spacemit,k1-syscon.h>
>  #include <dt-bindings/phy/phy.h>
> +#include <dt-bindings/power/spacemit,k1-power.h>
>  
>  #include "k1-pdma.h"
>  
> @@ -1119,6 +1120,17 @@ multimedia-bus {
>  			#size-cells = <2>;
>  			dma-ranges = <0x0 0x00000000 0x0 0x00000000 0x0 0x80000000>,
>  				     <0x0 0x80000000 0x1 0x00000000 0x3 0x80000000>;
> +
> +			gpu: gpu@cac00000 {
> +				compatible = "spacemit,k1-gpu", "img,img-bxe-2-32", "img,img-rogue";
> +				reg = <0x0 0xcac00000 0x0 0x80000>;
> +				interrupts = <75>;
> +				clocks = <&syscon_apmu CLK_GPU>;
> +				clock-names = "core";
> +				resets = <&syscon_apmu RESET_GPU>;
> +				power-domains = <&syscon_apmu K1_PMDOMAIN_GPU>;
..
> +				status = "disabled";
as if agree with above comment, drop this line and patch [2/2]

> +			};
>  		};
>  
>  		network-bus {
> 
> -- 
> 2.56.0
> 

-- 
Yixun Lan (dlan)