[pdx86-platform-drivers-x86:review-ilpo-next 7/10] drivers/platform/asus/asus-laptop.c:1351 asus_rfkill_setup() warn: 'rfk->rfkill' is an error pointer or valid

[pdx86-platform-drivers-x86:review-ilpo-next 7/10] drivers/platform/asus/asus-laptop.c:1351 asus_rfkill_setup() warn: 'rfk->rfkill' is an error pointer or valid

[kernel test robot]

Unfiltered warning: this smatch report is sent as-is and has not been
reviewed for false positives, so please treat it with due skepticism.

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC: Hans de Goede <hdegoede@redhat.com>
TO: Chipang Kao <chipang_kao@asus.com>
CC: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
CC: Denis Benato <denis.benato@linux.dev>

Hi Chipang,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-ilpo-next
head:   5680519168f65666d2c03cc6ed8fe2b7052aee12
commit: ef696e89f836c31825b754abe181b490b82fbee7 [7/10] platform/asus: Move ASUS platform drivers out of drivers/platform/x86
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago
config: i386-randconfig-2200-20261111 (https://download.01.org/0day-ci/archive/20261111/202611110347.Meo5msSy-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
smatch: v0.5.0-9187-g5189e3fb

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202611110347.Meo5msSy-lkp@intel.com/

smatch warnings:
drivers/platform/asus/asus-laptop.c:1351 asus_rfkill_setup() warn: 'rfk->rfkill' is an error pointer or valid

vim +1351 drivers/platform/asus/asus-laptop.c

18e1311ee71a67 drivers/platform/x86/asus-laptop.c Corentin Chary 2010-01-25  1340  
774b06780be20d drivers/platform/x86/asus-laptop.c Corentin Chary 2011-12-15  1341  static int asus_rfkill_setup(struct asus_laptop *asus, struct asus_rfkill *rfk,
774b06780be20d drivers/platform/x86/asus-laptop.c Corentin Chary 2011-12-15  1342  			     const char *name, int control_id, int type,
774b06780be20d drivers/platform/x86/asus-laptop.c Corentin Chary 2011-12-15  1343  			     const struct rfkill_ops *ops)
18e1311ee71a67 drivers/platform/x86/asus-laptop.c Corentin Chary 2010-01-25  1344  {
18e1311ee71a67 drivers/platform/x86/asus-laptop.c Corentin Chary 2010-01-25  1345  	int result;
18e1311ee71a67 drivers/platform/x86/asus-laptop.c Corentin Chary 2010-01-25  1346  
774b06780be20d drivers/platform/x86/asus-laptop.c Corentin Chary 2011-12-15  1347  	rfk->control_id = control_id;
774b06780be20d drivers/platform/x86/asus-laptop.c Corentin Chary 2011-12-15  1348  	rfk->asus = asus;
774b06780be20d drivers/platform/x86/asus-laptop.c Corentin Chary 2011-12-15  1349  	rfk->rfkill = rfkill_alloc(name, &asus->platform_device->dev,
774b06780be20d drivers/platform/x86/asus-laptop.c Corentin Chary 2011-12-15  1350  				   type, ops, rfk);
774b06780be20d drivers/platform/x86/asus-laptop.c Corentin Chary 2011-12-15 @1351  	if (!rfk->rfkill)
18e1311ee71a67 drivers/platform/x86/asus-laptop.c Corentin Chary 2010-01-25  1352  		return -EINVAL;
18e1311ee71a67 drivers/platform/x86/asus-laptop.c Corentin Chary 2010-01-25  1353  
774b06780be20d drivers/platform/x86/asus-laptop.c Corentin Chary 2011-12-15  1354  	result = rfkill_register(rfk->rfkill);
18e1311ee71a67 drivers/platform/x86/asus-laptop.c Corentin Chary 2010-01-25  1355  	if (result) {
774b06780be20d drivers/platform/x86/asus-laptop.c Corentin Chary 2011-12-15  1356  		rfkill_destroy(rfk->rfkill);
774b06780be20d drivers/platform/x86/asus-laptop.c Corentin Chary 2011-12-15  1357  		rfk->rfkill = NULL;
774b06780be20d drivers/platform/x86/asus-laptop.c Corentin Chary 2011-12-15  1358  	}
774b06780be20d drivers/platform/x86/asus-laptop.c Corentin Chary 2011-12-15  1359  
774b06780be20d drivers/platform/x86/asus-laptop.c Corentin Chary 2011-12-15  1360  	return result;
18e1311ee71a67 drivers/platform/x86/asus-laptop.c Corentin Chary 2010-01-25  1361  }
18e1311ee71a67 drivers/platform/x86/asus-laptop.c Corentin Chary 2010-01-25  1362  

:::::: The code at line 1351 was first introduced by commit
:::::: 774b06780be20d07c5459becd6495c04523a93a2 asus-laptop: control how BLED and WLED should be exposed

:::::: TO: Corentin Chary <corentin.chary@gmail.com>
:::::: CC: Matthew Garrett <mjg@redhat.com>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki