Re: [PATCH net-next] dt-bindings: net: Convert HiSilicon GMAC v1/2 to DT schema

[Rob Herring <robh@kernel.org>]

On Tue, Nov 10, 2026 at 07:17:28PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Low] dt-bindings: net: hisilicon,hisi-gmac-v1.yaml omits
>   hisilicon,hi3516a-gmac
> --
> 
> commit ab6f211d13f9c7a3f51fb6e0f45f7089669c73d4
> Author: Rob Herring (Arm) <robh@kernel.org>
> 
> dt-bindings: net: Convert HiSilicon GMAC v1/2 to DT schema
> 
> This commit converts the HiSilicon GMAC v1/2 binding from text to DT schema
> format and relaxes the node name pattern in mdio.yaml to allow ethernet
> controller nodes that directly contain an MDIO bus.
> 
> > diff --git a/Documentation/devicetree/bindings/net/hisilicon,hisi-gmac-v1.yaml b/Documentation/devicetree/bindings/net/hisilicon,hisi-gmac-v1.yaml
> > new file mode 100644
> > index 0000000000000..89ed6ab1905e1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/hisilicon,hisi-gmac-v1.yaml
> > @@ -0,0 +1,96 @@
> 
> [ ... ]
> 
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - items:
> > +          - const: hisilicon,hix5hd2-gmac
> > +          - const: hisilicon,hisi-gmac-v1
> > +      - items:
> > +          - const: hisilicon,hi3798cv200-gmac
> > +          - const: hisilicon,hisi-gmac-v2
> 
> [Severity: Low]
> Should the v2 compatible entry also allow "hisilicon,hi3516a-gmac" via an
> enum alongside "hisilicon,hi3798cv200-gmac"?
> 
> The removed text binding documented "hisilicon,hi3516a-gmac" as a v2 SoC
> compatible string, and hix5hd2_of_match[] in
> drivers/net/ethernet/hisilicon/hix5hd2_gmac.c still matches it, so omitting
> it leaves that compatible string undocumented for dt_compatible_check and
> breaks schema validation for hi3516a GMAC nodes.

No, the above matches actual users and the .txt binding was not precise.

Rob