From: sashiko-bot@kernel.org
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH net-next] dt-bindings: net: Convert HiSilicon GMAC v1/2 to DT schema
Date: Tue, 10 Nov 2026 19:17:28 +0000 [thread overview]
Message-ID: <sashiko-outbox-207650@kernel.org> (raw)
In-Reply-To: <20261109191641.653847-3-robh@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: net: hisilicon,hisi-gmac-v1.yaml omits
hisilicon,hi3516a-gmac
--
commit ab6f211d13f9c7a3f51fb6e0f45f7089669c73d4
Author: Rob Herring (Arm) <robh@kernel.org>
dt-bindings: net: Convert HiSilicon GMAC v1/2 to DT schema
This commit converts the HiSilicon GMAC v1/2 binding from text to DT schema
format and relaxes the node name pattern in mdio.yaml to allow ethernet
controller nodes that directly contain an MDIO bus.
> diff --git a/Documentation/devicetree/bindings/net/hisilicon,hisi-gmac-v1.yaml b/Documentation/devicetree/bindings/net/hisilicon,hisi-gmac-v1.yaml
> new file mode 100644
> index 0000000000000..89ed6ab1905e1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/hisilicon,hisi-gmac-v1.yaml
> @@ -0,0 +1,96 @@
[ ... ]
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - const: hisilicon,hix5hd2-gmac
> + - const: hisilicon,hisi-gmac-v1
> + - items:
> + - const: hisilicon,hi3798cv200-gmac
> + - const: hisilicon,hisi-gmac-v2
[Severity: Low]
Should the v2 compatible entry also allow "hisilicon,hi3516a-gmac" via an
enum alongside "hisilicon,hi3798cv200-gmac"?
The removed text binding documented "hisilicon,hi3516a-gmac" as a v2 SoC
compatible string, and hix5hd2_of_match[] in
drivers/net/ethernet/hisilicon/hix5hd2_gmac.c still matches it, so omitting
it leaves that compatible string undocumented for dt_compatible_check and
breaks schema validation for hi3516a GMAC nodes.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109191641.653847-3-robh@kernel.org?part=1
next prev parent reply other threads:[~2026-11-10 19:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 19:16 [PATCH net-next] dt-bindings: net: Convert HiSilicon GMAC v1/2 to DT schema Rob Herring (Arm)
2026-11-10 19:17 ` sashiko-bot [this message]
2026-11-11 14:06 ` Rob Herring
2026-11-12 10:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-207650@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.