All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: David Laight <david.laight.linux@gmail.com>
Cc: Mariia Nikitash <nikitash.mariiaw@gmail.com>,
	nicolas.dufresne@collabora.com, benjamin.gaignard@collabora.com,
	p.zabel@pengutronix.de, mchehab@kernel.org,
	linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
	justinstitt@google.com, morbo@google.com
Subject: Re: [PATCH] media: verisilicon: Replace strlcat() with seq_buf
Date: Thu, 12 Nov 2026 09:45:08 -0800	[thread overview]
Message-ID: <202611120942.A91A689C5@keescook> (raw)
In-Reply-To: <20261108200800.2b3b15cf@pumpkin>

On Sun, Nov 08, 2026 at 08:08:00PM +0000, David Laight wrote:
> On Thu,  5 Nov 2026 00:45:18 -0800
> Mariia Nikitash <nikitash.mariiaw@gmail.com> wrote:
> 
> > In preparation for removing the deprecated strlcat() API[1], replace
> > the strscpy() and strlcat() calls with seq_buf operations when
> > constructing Hantro video device names.
> > 
> > This preserves the resulting strings, including truncation
> > when the compatible string and suffix exceed the destination
> > buffer's capacity.
> 
> This is just stupid...

David, this isn't very helpful. I realize there are other threads where
you get into more detail, but as a stand-alone reply, I'd expect more
constructive feedback (or none at all, or a pointer to an earlier thread
if you feel like something needs repeating, etc).

-- 
Kees Cook

WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <kees@kernel.org>
To: David Laight <david.laight.linux@gmail.com>
Cc: Mariia Nikitash <nikitash.mariiaw@gmail.com>,
	nicolas.dufresne@collabora.com, benjamin.gaignard@collabora.com,
	p.zabel@pengutronix.de, mchehab@kernel.org,
	linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
	justinstitt@google.com, morbo@google.com
Subject: Re: [PATCH] media: verisilicon: Replace strlcat() with seq_buf
Date: Thu, 12 Nov 2026 09:45:08 -0800	[thread overview]
Message-ID: <202611120942.A91A689C5@keescook> (raw)
In-Reply-To: <20261108200800.2b3b15cf@pumpkin>

On Sun, Nov 08, 2026 at 08:08:00PM +0000, David Laight wrote:
> On Thu,  5 Nov 2026 00:45:18 -0800
> Mariia Nikitash <nikitash.mariiaw@gmail.com> wrote:
> 
> > In preparation for removing the deprecated strlcat() API[1], replace
> > the strscpy() and strlcat() calls with seq_buf operations when
> > constructing Hantro video device names.
> > 
> > This preserves the resulting strings, including truncation
> > when the compatible string and suffix exceed the destination
> > buffer's capacity.
> 
> This is just stupid...

David, this isn't very helpful. I realize there are other threads where
you get into more detail, but as a stand-alone reply, I'd expect more
constructive feedback (or none at all, or a pointer to an earlier thread
if you feel like something needs repeating, etc).

-- 
Kees Cook

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2026-11-12 17:45 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05  8:45 [PATCH] media: verisilicon: Replace strlcat() with seq_buf Mariia Nikitash
2026-11-05  8:45 ` Mariia Nikitash
2026-11-08 20:08 ` David Laight
2026-11-08 20:08   ` David Laight
2026-11-10 10:13   ` Hans Verkuil
2026-11-10 10:13     ` Hans Verkuil
2026-11-10 18:27     ` Mariia Nikitash
2026-11-10 18:27       ` Mariia Nikitash
2026-11-12 17:45   ` Kees Cook [this message]
2026-11-12 17:45     ` Kees Cook
2026-11-11  3:24 ` [PATCH v2] media: verisilicon: Replace strlcat() with scnprintf() Mariia Nikitash
2026-11-11  3:24   ` Mariia Nikitash
2026-11-11 10:35   ` Alejandro Colomar
2026-11-11 10:35     ` Alejandro Colomar
2026-11-11 22:04   ` Thorsten Blum
2026-11-11 22:04     ` Thorsten Blum
2026-11-12 17:42   ` Kees Cook
2026-11-12 17:42     ` Kees Cook
2026-11-11 23:27 ` [PATCH] media: verisilicon: Replace strlcat() with seq_buf Justin Stitt
2026-11-11 23:27   ` Justin Stitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202611120942.A91A689C5@keescook \
    --to=kees@kernel.org \
    --cc=benjamin.gaignard@collabora.com \
    --cc=david.laight.linux@gmail.com \
    --cc=justinstitt@google.com \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=morbo@google.com \
    --cc=nicolas.dufresne@collabora.com \
    --cc=nikitash.mariiaw@gmail.com \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.