All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin George <martinus.gpy@gmail.com>
To: linux-nvme@lists.infradead.org, hch@lst.de
Cc: kbusch@kernel.org, sagi@grimberg.me
Subject: [PATCH 0/2] nvme-fabrics: bound reconnect_delay and keep_alive_tmo
Date: Fri, 13 Nov 2026 15:39:49 +0530	[thread overview]
Message-ID: <20261113100951.17577-1-marting@netapp.com> (raw)

reconnect_delay and keep_alive_tmo (kato) are accepted in seconds but 
later multiplied by HZ (and, for kato, by 1000) in 32-bit arithmetic, so 
large values overflow and yield bogus timers. Bound both at parse/store 
time so the conversions can't wrap.

The target already does this for kato via NVMET_MAX_KATO, and the host 
recently fixed the same class for admin_timeout/io_timeout (4a5aeebf1a00) 
and partly for reconnect_delay (f92fe8dea19c).

Martin George (2):
  nvme-fabrics: bound reconnect_delay to avoid timer overflow
  nvme-fabrics: bound keep_alive_tmo to avoid overflow

 drivers/nvme/host/fabrics.c | 4 ++--
 drivers/nvme/host/sysfs.c   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.53.0



             reply	other threads:[~2026-11-13 10:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 10:09 Martin George [this message]
2026-11-13 10:09 ` [PATCH 1/2] nvme-fabrics: bound reconnect_delay to avoid timer overflow Martin George
2026-11-13 10:09 ` [PATCH 2/2] nvme-fabrics: bound keep_alive_tmo to avoid overflow Martin George
2026-11-13 13:01 ` [PATCH 0/2] nvme-fabrics: bound reconnect_delay and keep_alive_tmo Laurence Oberman
2026-11-13 15:16   ` Martin George

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261113100951.17577-1-marting@netapp.com \
    --to=martinus.gpy@gmail.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.