From: Martin George <martinus.gpy@gmail.com>
To: linux-nvme@lists.infradead.org, hch@lst.de
Cc: kbusch@kernel.org, sagi@grimberg.me
Subject: [PATCH 2/2] nvme-fabrics: bound keep_alive_tmo to avoid overflow
Date: Fri, 13 Nov 2026 15:39:51 +0530 [thread overview]
Message-ID: <20261113100951.17577-3-marting@netapp.com> (raw)
In-Reply-To: <20261113100951.17577-1-marting@netapp.com>
keep_alive_tmo (kato) is only checked for being negative, yet it is sent
to the controller as "kato * 1000" ms and used as "kato * HZ" jiffies for
the keep-alive timer; a large value overflows both.
Reject values above INT_MAX / 1000, which (as 1000 >= HZ) covers both
conversions, as the target already does via NVMET_MAX_KATO.
Signed-off-by: Martin George <marting@netapp.com>
---
drivers/nvme/host/fabrics.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index 25029978b978..b4ca0f9fd703 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -837,7 +837,7 @@ static int nvmf_parse_options(struct nvmf_ctrl_options *opts,
goto out;
}
- if (token < 0) {
+ if (token < 0 || token > INT_MAX / 1000) {
pr_err("Invalid keep_alive_tmo %d\n", token);
ret = -EINVAL;
goto out;
--
2.53.0
next prev parent reply other threads:[~2026-11-13 10:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 10:09 [PATCH 0/2] nvme-fabrics: bound reconnect_delay and keep_alive_tmo Martin George
2026-11-13 10:09 ` [PATCH 1/2] nvme-fabrics: bound reconnect_delay to avoid timer overflow Martin George
2026-11-13 10:09 ` Martin George [this message]
2026-11-13 13:01 ` [PATCH 0/2] nvme-fabrics: bound reconnect_delay and keep_alive_tmo Laurence Oberman
2026-11-13 15:16 ` Martin George
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113100951.17577-3-marting@netapp.com \
--to=martinus.gpy@gmail.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.