Re: [PATCH v2 00/12] Fix 'make check' errors

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1535 bytes --]

On Fri, Nov 13, 2026 at 04:47:51PM +0000, Andrew Goodbody wrote:
> On 10/11/2026 16:57, Tom Rini wrote:
> > And FWIW, with this series applied on current main 'make check' still
> > fails on my dev box, which is just Ubuntu 24.04.
> In addition to the packages documented for building U-Boot in order to run
> 'make check' and friends you need
> 
> $ sudo apt install yamllint cgpt xilinx-bootgen u-boot-tools softhsm2
> vboot-kernel-utils opensc coreboot-utils libengine-pkcs11-openssl
> 
> You also need a built copy of fiptool which seems to need being built from
> TF_A.
> 
> cd ~/src
> git clone --recurse-submodules
> "https://review.trustedfirmware.org/TF-A/trusted-firmware-a"
> cd trusted-firmware-a
> make fiptool
> mkdir ~/bin # if this did not exist previously also need to logout/login to
> get on path
> cp ~/src/trusted-firmware-a/build/fvp/release/tools/fiptool/fiptool ~/bin
> 
> I hope to do a an update to the docs to make all this knowledge generally
> available. But that will not be part of this series if that is OK.

That's fine, yes. But also highlights why I put what I put in the rest
of the email. Running "make check" is not some sort of quick test, nor
some self contained test. It's running a bunch of stuff, with a bunch of
required tooling. It's arguably not even doing what a developer expects.
If you're developing support for <arbitrary physical platform> why is a
bunch of sandbox stuff being built? But yes, fixing the bug you're
finding is worthwhile.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]