* + mm-mglru-avoid-prolonged-anon-reclaim-with-swappiness=200.patch added to mm-new branch
@ 2026-11-12 1:17 Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2026-11-12 1:17 UTC (permalink / raw)
To: mm-commits, zhuhui, zhangbo56, yuanchu, weixugc, wangzicheng,
surenb, sidchintamaneni, shakeel.butt, rppt, ridong.chen,
qi.zheng, mhocko, liuxiang.277, lianux.mm, liam, kunwu.chan,
kasong, hui.zhu, hannes, baoquan.he, baolin.wang, baohua,
axelrasmussen, lyugaofei, akpm
The patch titled
Subject: mm/mglru: avoid prolonged anon reclaim with swappiness=200
has been added to the -mm mm-new branch. Its filename is
mm-mglru-avoid-prolonged-anon-reclaim-with-swappiness=200.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-mglru-avoid-prolonged-anon-reclaim-with-swappiness=200.patch
This patch will later appear in the mm-new branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Note, mm-new is a provisional staging ground for work-in-progress
patches, and acceptance into mm-new is a notification for others take
notice and to finish up reviews. Please do not hesitate to respond to
review feedback and post updated versions to replace or incrementally
fixup patches in mm-new.
The mm-new branch of mm.git is not included in linux-next
If a few days of testing in mm-new is successful, the patch will me moved
into mm.git's mm-unstable branch, which is included in linux-next
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via various
branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there most days
------------------------------------------------------
From: lyugaofei <lyugaofei@xiaomi.com>
Subject: mm/mglru: avoid prolonged anon reclaim with swappiness=200
Date: Thu, 12 Nov 2026 07:26:01 +0800
It has been observed that swappiness=200 can significantly slow down
reclaim on some machines, with some workloads running 3x slower
under MGLRU than under CLRU.
This is because swappiness=200 currently results in file_factor=0.
Give file reclaim a small factor at lower priorities, for example,
when sc->priority < DEF_PRIORITY / 2.
Link: https://lore.kernel.org/20261111232603.9934-15-baohua@kernel.org
Signed-off-by: lyugaofei <lyugaofei@xiaomi.com>
Signed-off-by: Barry Song (Xiaomi) <baohua@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Co-developed-by: Barry Song (Xiaomi) <baohua@kernel.org>
Cc: Axel Rasmussen <axelrasmussen@google.com>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Baoquan He <baoquan.he@linux.dev>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: <hui.zhu@linux.dev>
Cc: Kairui Song <kasong@tencent.com>
Cc: Kunwu Chan <kunwu.chan@gmail.com>
Cc: Liam R. Howlett <liam@infradead.org>
Cc: wang lian <lianux.mm@gmail.com>
Cc: <liuxiang.277@bytedance.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Qi Zheng <qi.zheng@linux.dev>
Cc: Ridong Chen <ridong.chen@linux.dev>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: wangzicheng <wangzicheng@honor.com>
Cc: Wei Xu <weixugc@google.com>
Cc: Yuanchu Xie <yuanchu@google.com>
Cc: Bo Zhang <zhangbo56@xiaomi.com>
Cc: Hui Zhu <zhuhui@kylinos.cn>
Cc: Siddharth Chintamaneni <sidchintamaneni@gmail.com>
---
mm/vmscan.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
--- a/mm/vmscan.c~mm-mglru-avoid-prolonged-anon-reclaim-with-swappiness=200
+++ a/mm/vmscan.c
@@ -4895,8 +4895,8 @@ static int get_tier_idx(struct lruvec *l
* We don't calculate the scan cost, MGLRU uses lazy promotion, which will
* cancel the scan budget natually.
*/
-static void lru_gen_balance_scan(struct lruvec *lruvec, int swappiness,
- unsigned long total_scan, unsigned long nr[])
+static void lru_gen_balance_scan(struct lruvec *lruvec, struct scan_control *sc,
+ int swappiness, unsigned long total_scan, unsigned long nr[])
{
struct lru_gen_folio *lrugen = &lruvec->lrugen;
u64 refault_rate[ANON_AND_FILE], anon_factor, file_factor;
@@ -4953,7 +4953,12 @@ static void lru_gen_balance_scan(struct
file_weight = nr[LRU_GEN_FILE] + nr[LRU_GEN_ANON] / size_bias;
anon_factor = (u64)swappiness * refault_rate[LRU_GEN_FILE] * anon_weight;
- file_factor = (u64)(MAX_SWAPPINESS - swappiness) * refault_rate[LRU_GEN_ANON] * file_weight;
+ if (swappiness == MAX_SWAPPINESS)
+ file_factor = sc->priority < DEF_PRIORITY / 2 ?
+ refault_rate[LRU_GEN_ANON] * file_weight : 0;
+ else
+ file_factor = (u64)(MAX_SWAPPINESS - swappiness) *
+ refault_rate[LRU_GEN_ANON] * file_weight;
/* Cross-multiply the ratio above. */
anon_scan = mul_u64_u64_div_u64(total_scan, anon_factor, anon_factor + file_factor);
@@ -5150,7 +5155,7 @@ static void lru_gen_prepare_scan(struct
total = apply_proportional_protection(memcg, sc, total);
total >>= sc->priority;
- lru_gen_balance_scan(lruvec, swappiness, total, nr_to_scan);
+ lru_gen_balance_scan(lruvec, sc, swappiness, total, nr_to_scan);
}
static bool should_abort_scan(struct lruvec *lruvec, struct scan_control *sc)
@@ -5897,7 +5902,7 @@ static int run_eviction(struct lruvec *l
return 0;
lruvec_evictable_size(lruvec, sc, swappiness, nr_to_scan);
- lru_gen_balance_scan(lruvec, swappiness,
+ lru_gen_balance_scan(lruvec, sc, swappiness,
nr_to_reclaim - sc->nr_reclaimed, nr_to_scan);
if (!evict_folio_lists(nr_to_scan, lruvec, sc, swappiness, MAX_LRU_BATCH))
_
Patches currently in -mm which might be from lyugaofei@xiaomi.com are
mm-mglru-run-aging-when-pages-are-rare-outside-the-youngest-gen.patch
mm-mglru-avoid-prolonged-anon-reclaim-with-swappiness=200.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
* + mm-mglru-avoid-prolonged-anon-reclaim-with-swappiness=200.patch added to mm-new branch
@ 2026-11-13 20:05 Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2026-11-13 20:05 UTC (permalink / raw)
To: mm-commits, lyugaofei, akpm
The patch titled
Subject: mm/mglru: avoid prolonged anon reclaim with swappiness=200
has been added to the -mm mm-new branch. Its filename is
mm-mglru-avoid-prolonged-anon-reclaim-with-swappiness=200.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-mglru-avoid-prolonged-anon-reclaim-with-swappiness=200.patch
This patch will later appear in the mm-new branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Note, mm-new is a provisional staging ground for work-in-progress
patches, and acceptance into mm-new is a notification for others take
notice and to finish up reviews. Please do not hesitate to respond to
review feedback and post updated versions to replace or incrementally
fixup patches in mm-new.
The mm-new branch of mm.git is not included in linux-next
If a few days of testing in mm-new is successful, the patch will me moved
into mm.git's mm-unstable branch, which is included in linux-next
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via various
branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there most days
------------------------------------------------------
From: Gaofei Lyu <lyugaofei@xiaomi.com>
Subject: mm/mglru: avoid prolonged anon reclaim with swappiness=200
Date: Sat, 14 Nov 2026 02:55:39 +0800
It has been observed that swappiness=200 can significantly slow down
reclaim on some machines, with some workloads running 3x slower under
MGLRU than under CLRU.
This is because swappiness=200 currently results in file_factor=0. Give
file reclaim a small factor at lower priorities, for example, when
sc->priority < DEF_PRIORITY / 2.
Link: https://lore.kernel.org/20261113185541.70203-15-baohua@kernel.org
Signed-off-by: Gaofei Lyu <lyugaofei@xiaomi.com>
Signed-off-by: Barry Song (Xiaomi) <baohua@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Co-developed-by: Barry Song (Xiaomi) <baohua@kernel.org>
Cc: Axel Rasmussen <axelrasmussen@google.com>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Baoquan He <baoquan.he@linux.dev>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: <hui.zhu@linux.dev>
Cc: Kairui Song <kasong@tencent.com>
Cc: Kunwu Chan <kunwu.chan@gmail.com>
Cc: Liam R. Howlett <liam@infradead.org>
Cc: wang lian <lianux.mm@gmail.com>
Cc: <liuxiang.277@bytedance.com>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Qi Zheng <qi.zheng@linux.dev>
Cc: Ridong Chen <ridong.chen@linux.dev>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: wangzicheng <wangzicheng@honor.com>
Cc: Wei Xu <weixugc@google.com>
Cc: Yuanchu Xie <yuanchu@google.com>
Cc: Bo Zhang <zhangbo56@xiaomi.com>
Cc: Hui Zhu <zhuhui@kylinos.cn>
Cc: Siddharth Chintamaneni <sidchintamaneni@gmail.com>
Cc: Bo Zhang <zhangbo0325@gmail.com>
---
mm/vmscan.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
--- a/mm/vmscan.c~mm-mglru-avoid-prolonged-anon-reclaim-with-swappiness=200
+++ a/mm/vmscan.c
@@ -4899,8 +4899,8 @@ static int get_tier_idx(struct lruvec *l
* We don't calculate the scan cost, MGLRU uses lazy promotion, which will
* cancel the scan budget natually.
*/
-static void lru_gen_balance_scan(struct lruvec *lruvec, int swappiness,
- unsigned long total_scan, unsigned long nr[])
+static void lru_gen_balance_scan(struct lruvec *lruvec, struct scan_control *sc,
+ int swappiness, unsigned long total_scan, unsigned long nr[])
{
struct lru_gen_folio *lrugen = &lruvec->lrugen;
u64 refault_rate[ANON_AND_FILE], anon_factor, file_factor;
@@ -4957,7 +4957,12 @@ static void lru_gen_balance_scan(struct
file_weight = nr[LRU_GEN_FILE] + nr[LRU_GEN_ANON] / size_bias;
anon_factor = (u64)swappiness * refault_rate[LRU_GEN_FILE] * anon_weight;
- file_factor = (u64)(MAX_SWAPPINESS - swappiness) * refault_rate[LRU_GEN_ANON] * file_weight;
+ if (swappiness == MAX_SWAPPINESS)
+ file_factor = sc->priority < DEF_PRIORITY / 2 ?
+ refault_rate[LRU_GEN_ANON] * file_weight : 0;
+ else
+ file_factor = (u64)(MAX_SWAPPINESS - swappiness) *
+ refault_rate[LRU_GEN_ANON] * file_weight;
/* Cross-multiply the ratio above. */
anon_scan = mul_u64_u64_div_u64(total_scan, anon_factor, anon_factor + file_factor);
@@ -5154,7 +5159,7 @@ static void lru_gen_prepare_scan(struct
total = apply_proportional_protection(memcg, sc, total);
total >>= sc->priority;
- lru_gen_balance_scan(lruvec, swappiness, total, nr_to_scan);
+ lru_gen_balance_scan(lruvec, sc, swappiness, total, nr_to_scan);
}
static bool should_abort_scan(struct lruvec *lruvec, struct scan_control *sc)
@@ -5914,7 +5919,7 @@ static int run_eviction(struct lruvec *l
return 0;
lruvec_evictable_size(lruvec, sc, swappiness, nr_to_scan);
- lru_gen_balance_scan(lruvec, swappiness,
+ lru_gen_balance_scan(lruvec, sc, swappiness,
nr_to_reclaim - sc->nr_reclaimed, nr_to_scan);
if (!evict_folio_lists(nr_to_scan, lruvec, sc, swappiness, MAX_LRU_BATCH))
_
Patches currently in -mm which might be from lyugaofei@xiaomi.com are
mm-mglru-run-aging-when-pages-are-rare-outside-the-youngest-gen.patch
mm-mglru-avoid-prolonged-anon-reclaim-with-swappiness=200.patch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-13 20:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-13 20:05 + mm-mglru-avoid-prolonged-anon-reclaim-with-swappiness=200.patch added to mm-new branch Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2026-11-12 1:17 Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.