* [to-be-updated] selftests-mm-mlock2-tests-fix-fclosenull-in-is_vmflag_set.patch removed from -mm tree
@ 2026-11-14 2:44 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-11-14 2:44 UTC (permalink / raw)
To: mm-commits, vbabka, surenb, shuah, rppt, mhocko, ljs, liam, david,
akpm, lihongfu
The quilt patch titled
Subject: selftests/mm: mlock2-tests: fix fclose(NULL) in is_vmflag_set()
has been removed from the -mm tree. Its filename was
selftests-mm-mlock2-tests-fix-fclosenull-in-is_vmflag_set.patch
This patch was dropped because an updated version will be issued
------------------------------------------------------
From: Hongfu Li <lihongfu@kylinos.cn>
Subject: selftests/mm: mlock2-tests: fix fclose(NULL) in is_vmflag_set()
Date: Wed, 04 Nov 2026 16:49:10 +0800
is_vmflag_set() jumps to the shared 'out' label when seek_to_smaps_entry()
fails. smaps is NULL on that path, and the code at the 'out' label calls
fclose(smaps) unconditionally. fclose(NULL) is undefined behaviour, so
the test crashes before it can report a test result.
Link: https://lore.kernel.org/20261104-for-mlock2-v1-1-57e6dd74c2bd@kylinos.cn
Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@kernel.org>
Cc: Lorenzo Stoakes <ljs@kernel.org>
Cc: Liam R. Howlett <liam@infradead.org>
Cc: Vlastimil Babka <vbabka@kernel.org>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Shuah Khan <shuah@kernel.org>
---
tools/testing/selftests/mm/mlock2-tests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/tools/testing/selftests/mm/mlock2-tests.c~selftests-mm-mlock2-tests-fix-fclosenull-in-is_vmflag_set
+++ a/tools/testing/selftests/mm/mlock2-tests.c
@@ -66,7 +66,7 @@ static bool is_vmflag_set(unsigned long
smaps = seek_to_smaps_entry(addr);
if (!smaps) {
ksft_print_msg("Unable to parse /proc/self/smaps\n");
- goto out;
+ return false;
}
while (getline(&line, &size, smaps) > 0) {
_
Patches currently in -mm which might be from lihongfu@kylinos.cn are
mm-hugetlb-charge-hugetlb-cgroup-and-memcg-in-alloc_hugetlb_folio_reserve.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-14 2:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-14 2:44 [to-be-updated] selftests-mm-mlock2-tests-fix-fclosenull-in-is_vmflag_set.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.