[PATCH] drm/panel: newvision-nv3051d: Propagate init sequence errors to prepare()

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Archit More <architmore303@gmail.com>
To: Neil Armstrong <neil.armstrong@linaro.org>,
	Douglas Anderson <dianders@chromium.org>
Cc: Chris Morgan <macromorgan@hotmail.com>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Archit More <architmore303@gmail.com>
Subject: [PATCH] drm/panel: newvision-nv3051d: Propagate init sequence errors to prepare()
Date: Sat, 14 Nov 2026 19:22:51 +0530	[thread overview]
Message-ID: <20261114135251.32775-1-architmore303@gmail.com> (raw)

In commit 3944ca3e6b7d ("drm/panel: newvision-nv3051d: Use
mipi_dsi_*_multi(); fix minor bugs"), prepare() and unprepare() were
converted to use mipi_dsi_*_multi() helpers, but
panel_nv3051d_init_sequence() continued using its own local struct
mipi_dsi_multi_context and unconditionally returned 0. Consequently,
errors encountered during the panel init sequence were discarded and
never reached prepare().

Convert panel_nv3051d_init_sequence() to take struct
mipi_dsi_multi_context * directly from prepare() so all DCS commands
share the same context. Referred to panel-elida-kd35t133 to solve
the issue.

Signed-off-by: Archit More <architmore303@gmail.com>
---
 .../gpu/drm/panel/panel-newvision-nv3051d.c   | 383 +++++++++---------
 1 file changed, 187 insertions(+), 196 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3051d.c b/drivers/gpu/drm/panel/panel-newvision-nv3051d.c
index 9ee0fa5b446a..38d49e1d27a6 100644
--- a/drivers/gpu/drm/panel/panel-newvision-nv3051d.c
+++ b/drivers/gpu/drm/panel/panel-newvision-nv3051d.c
@@ -44,203 +44,196 @@ static inline struct panel_nv3051d *panel_to_panelnv3051d(struct drm_panel *pane
 	return container_of(panel, struct panel_nv3051d, panel);
 }
 
-static int panel_nv3051d_init_sequence(struct panel_nv3051d *ctx)
+static void panel_nv3051d_init_sequence(struct mipi_dsi_multi_context *dsi_ctx)
 {
-	struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
-	struct mipi_dsi_multi_context dsi_ctx = {.dsi = dsi};
-
 	/*
 	 * Init sequence was supplied by device vendor with no
 	 * documentation.
 	 */
 
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xFF, 0x30);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xFF, 0x52);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xFF, 0x01);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xE3, 0x00);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x03, 0x40);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x04, 0x00);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x05, 0x03);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x24, 0x12);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x25, 0x1E);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x26, 0x28);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x27, 0x52);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x28, 0x57);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x29, 0x01);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x2A, 0xDF);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x38, 0x9C);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x39, 0xA7);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x3A, 0x53);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x44, 0x00);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x49, 0x3C);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x59, 0xFE);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x5C, 0x00);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x91, 0x77);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x92, 0x77);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xA0, 0x55);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xA1, 0x50);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xA4, 0x9C);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xA7, 0x02);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xA8, 0x01);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xA9, 0x01);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xAA, 0xFC);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xAB, 0x28);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xAC, 0x06);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xAD, 0x06);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xAE, 0x06);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xAF, 0x03);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB0, 0x08);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB1, 0x26);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB2, 0x28);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB3, 0x28);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB4, 0x33);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB5, 0x08);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB6, 0x26);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB7, 0x08);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB8, 0x26);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xFF, 0x30);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xFF, 0x52);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xFF, 0x02);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB1, 0x0E);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xD1, 0x0E);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB4, 0x29);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xD4, 0x2B);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB2, 0x0C);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xD2, 0x0A);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB3, 0x28);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xD3, 0x28);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB6, 0x11);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xD6, 0x0D);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB7, 0x32);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xD7, 0x30);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xC1, 0x04);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xE1, 0x06);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB8, 0x0A);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xD8, 0x0A);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB9, 0x01);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xD9, 0x01);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xBD, 0x13);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xDD, 0x13);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xBC, 0x11);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xDC, 0x11);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xBB, 0x0F);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xDB, 0x0F);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xBA, 0x0F);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xDA, 0x0F);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xBE, 0x18);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xDE, 0x18);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xBF, 0x0F);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xDF, 0x0F);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xC0, 0x17);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xE0, 0x17);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB5, 0x3B);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xD5, 0x3C);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB0, 0x0B);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xD0, 0x0C);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xFF, 0x30);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xFF, 0x52);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xFF, 0x03);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x00, 0x2A);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x01, 0x2A);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x02, 0x2A);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x03, 0x2A);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x04, 0x61);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x05, 0x80);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x06, 0xC7);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x07, 0x01);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x08, 0x82);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x09, 0x83);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x30, 0x2A);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x31, 0x2A);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x32, 0x2A);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x33, 0x2A);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x34, 0x61);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x35, 0xC5);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x36, 0x80);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x37, 0x23);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x40, 0x82);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x41, 0x83);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x42, 0x80);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x43, 0x81);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x44, 0x11);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x45, 0xF2);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x46, 0xF1);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x47, 0x11);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x48, 0xF4);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x49, 0xF3);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x50, 0x02);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x51, 0x01);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x52, 0x04);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x53, 0x03);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x54, 0x11);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x55, 0xF6);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x56, 0xF5);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x57, 0x11);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x58, 0xF8);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x59, 0xF7);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x7E, 0x02);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x7F, 0x80);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xE0, 0x5A);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB1, 0x00);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB4, 0x0E);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB5, 0x0F);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB6, 0x04);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB7, 0x07);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB8, 0x06);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xB9, 0x05);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xBA, 0x0F);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xC7, 0x00);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xCA, 0x0E);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xCB, 0x0F);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xCC, 0x04);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xCD, 0x07);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xCE, 0x06);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xCF, 0x05);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xD0, 0x0F);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x81, 0x0F);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x84, 0x0E);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x85, 0x0F);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x86, 0x07);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x87, 0x04);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x88, 0x05);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x89, 0x06);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x8A, 0x00);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x97, 0x0F);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x9A, 0x0E);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x9B, 0x0F);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x9C, 0x07);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x9D, 0x04);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x9E, 0x05);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x9F, 0x06);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xA0, 0x00);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xFF, 0x30);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xFF, 0x52);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xFF, 0x02);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x01, 0x01);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x02, 0xDA);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x03, 0xBA);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x04, 0xA8);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x05, 0x9A);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x06, 0x70);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x07, 0xFF);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x08, 0x91);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x09, 0x90);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x0A, 0xFF);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x0B, 0x8F);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x0C, 0x60);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x0D, 0x58);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x0E, 0x48);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x0F, 0x38);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x10, 0x2B);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xFF, 0x30);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xFF, 0x52);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xFF, 0x00);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x36, 0x02);
-	mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x3A, 0x70);
-
-	dev_dbg(ctx->dev, "Panel init sequence done\n");
-
-	return 0;
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xFF, 0x30);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xFF, 0x52);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xFF, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xE3, 0x00);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x03, 0x40);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x04, 0x00);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x05, 0x03);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x24, 0x12);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x25, 0x1E);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x26, 0x28);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x27, 0x52);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x28, 0x57);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x29, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x2A, 0xDF);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x38, 0x9C);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x39, 0xA7);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x3A, 0x53);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x44, 0x00);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x49, 0x3C);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x59, 0xFE);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x5C, 0x00);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x91, 0x77);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x92, 0x77);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xA0, 0x55);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xA1, 0x50);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xA4, 0x9C);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xA7, 0x02);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xA8, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xA9, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xAA, 0xFC);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xAB, 0x28);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xAC, 0x06);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xAD, 0x06);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xAE, 0x06);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xAF, 0x03);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB0, 0x08);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB1, 0x26);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB2, 0x28);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB3, 0x28);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB4, 0x33);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB5, 0x08);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB6, 0x26);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB7, 0x08);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB8, 0x26);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xFF, 0x30);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xFF, 0x52);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xFF, 0x02);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB1, 0x0E);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xD1, 0x0E);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB4, 0x29);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xD4, 0x2B);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB2, 0x0C);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xD2, 0x0A);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB3, 0x28);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xD3, 0x28);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB6, 0x11);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xD6, 0x0D);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB7, 0x32);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xD7, 0x30);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xC1, 0x04);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xE1, 0x06);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB8, 0x0A);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xD8, 0x0A);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB9, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xD9, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xBD, 0x13);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xDD, 0x13);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xBC, 0x11);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xDC, 0x11);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xBB, 0x0F);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xDB, 0x0F);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xBA, 0x0F);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xDA, 0x0F);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xBE, 0x18);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xDE, 0x18);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xBF, 0x0F);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xDF, 0x0F);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xC0, 0x17);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xE0, 0x17);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB5, 0x3B);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xD5, 0x3C);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB0, 0x0B);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xD0, 0x0C);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xFF, 0x30);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xFF, 0x52);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xFF, 0x03);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x00, 0x2A);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x01, 0x2A);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x02, 0x2A);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x03, 0x2A);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x04, 0x61);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x05, 0x80);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x06, 0xC7);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x07, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x08, 0x82);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x09, 0x83);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x30, 0x2A);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x31, 0x2A);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x32, 0x2A);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x33, 0x2A);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x34, 0x61);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x35, 0xC5);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x36, 0x80);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x37, 0x23);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x40, 0x82);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x41, 0x83);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x42, 0x80);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x43, 0x81);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x44, 0x11);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x45, 0xF2);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x46, 0xF1);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x47, 0x11);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x48, 0xF4);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x49, 0xF3);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x50, 0x02);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x51, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x52, 0x04);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x53, 0x03);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x54, 0x11);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x55, 0xF6);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x56, 0xF5);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x57, 0x11);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x58, 0xF8);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x59, 0xF7);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x7E, 0x02);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x7F, 0x80);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xE0, 0x5A);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB1, 0x00);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB4, 0x0E);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB5, 0x0F);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB6, 0x04);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB7, 0x07);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB8, 0x06);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xB9, 0x05);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xBA, 0x0F);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xC7, 0x00);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xCA, 0x0E);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xCB, 0x0F);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xCC, 0x04);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xCD, 0x07);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xCE, 0x06);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xCF, 0x05);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xD0, 0x0F);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x81, 0x0F);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x84, 0x0E);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x85, 0x0F);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x86, 0x07);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x87, 0x04);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x88, 0x05);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x89, 0x06);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x8A, 0x00);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x97, 0x0F);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x9A, 0x0E);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x9B, 0x0F);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x9C, 0x07);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x9D, 0x04);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x9E, 0x05);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x9F, 0x06);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xA0, 0x00);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xFF, 0x30);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xFF, 0x52);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xFF, 0x02);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x01, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x02, 0xDA);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x03, 0xBA);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x04, 0xA8);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x05, 0x9A);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x06, 0x70);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x07, 0xFF);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x08, 0x91);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x09, 0x90);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x0A, 0xFF);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x0B, 0x8F);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x0C, 0x60);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x0D, 0x58);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x0E, 0x48);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x0F, 0x38);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x10, 0x2B);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xFF, 0x30);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xFF, 0x52);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xFF, 0x00);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x36, 0x02);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x3A, 0x70);
 }
 
 static int panel_nv3051d_unprepare(struct drm_panel *panel)
@@ -285,11 +278,9 @@ static int panel_nv3051d_prepare(struct drm_panel *panel)
 	gpiod_set_value_cansleep(ctx->reset_gpio, 0);
 	msleep(20);
 
-	ret = panel_nv3051d_init_sequence(ctx);
-	if (ret < 0) {
-		dev_err(ctx->dev, "Panel init sequence failed: %d\n", ret);
-		goto disable_vdd;
-	}
+	panel_nv3051d_init_sequence(&dsi_ctx);
+	if (!dsi_ctx.accum_err)
+		dev_dbg(ctx->dev, "Panel init sequence done\n");
 
 	mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);
 	mipi_dsi_msleep(&dsi_ctx, 200);
-- 
2.34.1

next             reply	other threads:[~2026-11-14 13:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14 13:52 Archit More [this message]
2026-11-14 14:01 ` [PATCH] drm/panel: newvision-nv3051d: Propagate init sequence errors to prepare() sashiko-bot

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:9ee0fa5b446 dfblob:38d49e1d27a )
 OR (
bs:"[PATCH] drm/panel: newvision-nv3051d: Propagate init sequence errors to prepare()" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261114135251.32775-1-architmore303@gmail.com \
    --to=architmore303@gmail.com \
    --cc=airlied@gmail.com \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=macromorgan@hotmail.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.