All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Archit More" <architmore303@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/panel: newvision-nv3051d: Propagate init sequence errors to prepare()
Date: Sat, 14 Nov 2026 14:01:03 +0000	[thread overview]
Message-ID: <sashiko-outbox-214599@kernel.org> (raw)
In-Reply-To: <20261114135251.32775-1-architmore303@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/panel: newvision-nv3051d: missing Fixes: trailer for init
  error fix
--

commit 99328fc94545f2992a1fb5b8fdaa4985cf1f91dc
Author: Archit More <architmore303@gmail.com>

> drm/panel: newvision-nv3051d: Propagate init sequence errors to prepare()
>
> In commit 3944ca3e6b7d ("drm/panel: newvision-nv3051d: Use
> mipi_dsi_*_multi(); fix minor bugs"), prepare() and unprepare() were
> converted to use mipi_dsi_*_multi() helpers, but
> panel_nv3051d_init_sequence() continued using its own local struct
> mipi_dsi_multi_context and unconditionally returned 0. Consequently,
> errors encountered during the panel init sequence were discarded and
> never reached prepare().
>
> Convert panel_nv3051d_init_sequence() to take struct
> mipi_dsi_multi_context * directly from prepare() so all DCS commands
> share the same context. Referred to panel-elida-kd35t133 to solve
> the issue.
>
> Signed-off-by: Archit More <architmore303@gmail.com>

[Severity: Low]
panel_nv3051d_init_sequence() started discarding DCS write errors in
bfbdf72d6c14 ("drm/panel: nv3051d: Transition to
mipi_dsi_dcs_write_seq_multi"), which switched it to a local
mipi_dsi_multi_context while leaving the trailing "return 0;".  Should
this include:

  Fixes: bfbdf72d6c14 ("drm/panel: nv3051d: Transition to mipi_dsi_dcs_write_seq_multi")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261114135251.32775-1-architmore303@gmail.com?part=1

      reply	other threads:[~2026-11-14 14:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14 13:52 [PATCH] drm/panel: newvision-nv3051d: Propagate init sequence errors to prepare() Archit More
2026-11-14 14:01 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-214599@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=architmore303@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.