* [PATCH] Docs/mm/damon/design: replace "same to" with "same as"
@ 2026-11-14 5:54 Enze Li
2026-11-14 5:58 ` sashiko-bot
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Enze Li @ 2026-11-14 5:54 UTC (permalink / raw)
To: sj, corbet, skhan, rdunlap; +Cc: damon, linux-mm, linux-doc, Enze Li
"same to" is not idiomatic; it should be "the same as" or "same as".
This doc has six such usages. Fix all of them at once for consistency.
Signed-off-by: Enze Li <lienze@kylinos.cn>
---
Documentation/mm/damon/design.rst | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
index b676be697158..6284b9005443 100644
--- a/Documentation/mm/damon/design.rst
+++ b/Documentation/mm/damon/design.rst
@@ -292,17 +292,17 @@ DAMON :ref:`context <damon_design_execution_model_and_data_structures>`. The
registration is made by specifying a probe per attribute. Each of the probes
specifies a rule to determine if a given memory region has the related
attribute. The rule is constructed with multiple filters. The filters work
-same to :ref:`DAMOS filters <damon_design_damos_filters>` except the supported
-filter types. Currently below filter types are supported.
+the same as :ref:`DAMOS filters <damon_design_damos_filters>` except the
+supported filter types. Currently below filter types are supported.
-- ``anon``: Same to that for DAMOS filters.
-- ``memcg``: Same to that for DAMOS filters.
+- ``anon``: Same as that for DAMOS filters.
+- ``memcg``: Same as that for DAMOS filters.
- ``pgidle_unset``: Matches if the page for the memory is marked as not
access-idle.
- ``pgidle_set``: Matches if the page for the memory is marked as access-idle.
- ``hugepage_size``: Matches if the page for the memory is a part of a hugepage
of a given size range.
-- ``active``: Same to that for DAMOS filters.
+- ``active``: Same as that for DAMOS filters.
If such probes are registered, DAMON executes the probes for each region's
sampling memory when it does the access :ref:`sampling
@@ -706,7 +706,7 @@ There are two such tuning algorithms that users can select as they need.
The goal can be specified with six parameters, namely ``target_metric``,
``complement``, ``target_value``, ``current_value``, ``nid`` and ``path``. The
auto-tuning mechanism tries to make ``current_value`` of ``complement``-ed
-``target_metric`` be same to ``target_value``.
+``target_metric`` be the same as ``target_value``.
- ``user_input``: User-provided value. Users could use any metric that they
have interest in for the value. User space main workload's latency or
@@ -736,7 +736,7 @@ auto-tuning mechanism tries to make ``current_value`` of ``complement``-ed
``complement`` is a boolean parameter that determines whether to use
complemented value of the target metric. For example, if ``complement`` is set
-and target metric is ``active_mem_bp``, it is effectively same to
+and target metric is ``active_mem_bp``, it is effectively the same as
``inactive_mem_bp``. ``complement`` is no-op when the target metric type is
``user_input``. For the metric type, the user should be able to emit
complemented metric values on their own.
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Docs/mm/damon/design: replace "same to" with "same as"
2026-11-14 5:54 [PATCH] Docs/mm/damon/design: replace "same to" with "same as" Enze Li
@ 2026-11-14 5:58 ` sashiko-bot
2026-11-14 6:02 ` Randy Dunlap
2026-11-14 17:07 ` SJ Park
2 siblings, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-11-14 5:58 UTC (permalink / raw)
To: Enze Li; +Cc: damon
> "same to" is not idiomatic; it should be "the same as" or "same as".
> This doc has six such usages. Fix all of them at once for consistency.
>
> Signed-off-by: Enze Li <lienze@kylinos.cn>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261114055436.5546-1-lienze@kylinos.cn?part=1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Docs/mm/damon/design: replace "same to" with "same as"
2026-11-14 5:54 [PATCH] Docs/mm/damon/design: replace "same to" with "same as" Enze Li
2026-11-14 5:58 ` sashiko-bot
@ 2026-11-14 6:02 ` Randy Dunlap
2026-11-14 17:07 ` SJ Park
2 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2026-11-14 6:02 UTC (permalink / raw)
To: Enze Li, sj, corbet, skhan; +Cc: damon, linux-mm, linux-doc
On 11/13/26 9:54 PM, Enze Li wrote:
> "same to" is not idiomatic; it should be "the same as" or "same as".
> This doc has six such usages. Fix all of them at once for consistency.
>
> Signed-off-by: Enze Li <lienze@kylinos.cn>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> Documentation/mm/damon/design.rst | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
> index b676be697158..6284b9005443 100644
> --- a/Documentation/mm/damon/design.rst
> +++ b/Documentation/mm/damon/design.rst
> @@ -292,17 +292,17 @@ DAMON :ref:`context <damon_design_execution_model_and_data_structures>`. The
> registration is made by specifying a probe per attribute. Each of the probes
> specifies a rule to determine if a given memory region has the related
> attribute. The rule is constructed with multiple filters. The filters work
> -same to :ref:`DAMOS filters <damon_design_damos_filters>` except the supported
> -filter types. Currently below filter types are supported.
> +the same as :ref:`DAMOS filters <damon_design_damos_filters>` except the
> +supported filter types. Currently below filter types are supported.
>
> -- ``anon``: Same to that for DAMOS filters.
> -- ``memcg``: Same to that for DAMOS filters.
> +- ``anon``: Same as that for DAMOS filters.
> +- ``memcg``: Same as that for DAMOS filters.
> - ``pgidle_unset``: Matches if the page for the memory is marked as not
> access-idle.
> - ``pgidle_set``: Matches if the page for the memory is marked as access-idle.
> - ``hugepage_size``: Matches if the page for the memory is a part of a hugepage
> of a given size range.
> -- ``active``: Same to that for DAMOS filters.
> +- ``active``: Same as that for DAMOS filters.
>
> If such probes are registered, DAMON executes the probes for each region's
> sampling memory when it does the access :ref:`sampling
> @@ -706,7 +706,7 @@ There are two such tuning algorithms that users can select as they need.
> The goal can be specified with six parameters, namely ``target_metric``,
> ``complement``, ``target_value``, ``current_value``, ``nid`` and ``path``. The
> auto-tuning mechanism tries to make ``current_value`` of ``complement``-ed
> -``target_metric`` be same to ``target_value``.
> +``target_metric`` be the same as ``target_value``.
>
> - ``user_input``: User-provided value. Users could use any metric that they
> have interest in for the value. User space main workload's latency or
> @@ -736,7 +736,7 @@ auto-tuning mechanism tries to make ``current_value`` of ``complement``-ed
>
> ``complement`` is a boolean parameter that determines whether to use
> complemented value of the target metric. For example, if ``complement`` is set
> -and target metric is ``active_mem_bp``, it is effectively same to
> +and target metric is ``active_mem_bp``, it is effectively the same as
> ``inactive_mem_bp``. ``complement`` is no-op when the target metric type is
> ``user_input``. For the metric type, the user should be able to emit
> complemented metric values on their own.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Docs/mm/damon/design: replace "same to" with "same as"
2026-11-14 5:54 [PATCH] Docs/mm/damon/design: replace "same to" with "same as" Enze Li
2026-11-14 5:58 ` sashiko-bot
2026-11-14 6:02 ` Randy Dunlap
@ 2026-11-14 17:07 ` SJ Park
2 siblings, 0 replies; 4+ messages in thread
From: SJ Park @ 2026-11-14 17:07 UTC (permalink / raw)
To: Enze Li; +Cc: SJ Park, corbet, skhan, rdunlap, damon, linux-mm, linux-doc
Hello Enze,
On Sat, 14 Nov 2026 13:54:36 +0800 Enze Li <lienze@kylinos.cn> wrote:
> "same to" is not idiomatic; it should be "the same as" or "same as".
> This doc has six such usages. Fix all of them at once for consistency.
Thank you for fixing those!
>
> Signed-off-by: Enze Li <lienze@kylinos.cn>
Reviewed-by: SJ Park <sj@kernel.org>
This patch is applied to damon/next [1] tree. I will repost it soon (~1 week)
as an mm.git merge request. So, no action from your side is needed for now.
[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
Thanks,
SJ
[...]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-11-14 17:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-14 5:54 [PATCH] Docs/mm/damon/design: replace "same to" with "same as" Enze Li
2026-11-14 5:58 ` sashiko-bot
2026-11-14 6:02 ` Randy Dunlap
2026-11-14 17:07 ` SJ Park
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.