[PATCH v1 1/2] leds: lm3533: Clean up probe and use managed helpers

[Svyatoslav Ryhel <clamor95@gmail.com>]

Clean up the lm3533 LED driver probe and remove routines by adopting
managed device helpers and modernizing error handling:

- Introduce a local `struct device *dev` variable to clean up repeated
  `&pdev->dev` references.
- Use `dev_err_probe()` for cleaner error handling on invalid IDs and
  LED class registration failures.
- Switch to `devm_led_classdev_register()` to automatically handle LED
  class device unregistration, removing the need for manual cleanup in
  error paths and the `remove` hook.
- Remove redundant `dev_dbg()` statements and cleanup unused cleanup
  labels.

Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
 drivers/leds/leds-lm3533.c | 48 +++++++++++---------------------------
 1 file changed, 14 insertions(+), 34 deletions(-)

diff --git a/drivers/leds/leds-lm3533.c b/drivers/leds/leds-lm3533.c
index d5997cbd88dfc..7db1105bee5c2 100644
--- a/drivers/leds/leds-lm3533.c
+++ b/drivers/leds/leds-lm3533.c
@@ -633,22 +633,19 @@ static int lm3533_led_setup(struct lm3533_led *led)
 
 static int lm3533_led_probe(struct platform_device *pdev)
 {
+	struct device *dev = &pdev->dev;
 	struct lm3533 *lm3533;
 	struct lm3533_led *led;
 	int ret;
 
-	dev_dbg(&pdev->dev, "%s\n", __func__);
-
-	lm3533 = dev_get_drvdata(pdev->dev.parent);
+	lm3533 = dev_get_drvdata(dev->parent);
 	if (!lm3533)
 		return -EINVAL;
 
-	if (pdev->id < 0 || pdev->id >= LM3533_LVCTRLBANK_COUNT) {
-		dev_err(&pdev->dev, "illegal LED id %d\n", pdev->id);
-		return -EINVAL;
-	}
+	if (pdev->id < 0 || pdev->id >= LM3533_LVCTRLBANK_COUNT)
+		return dev_err_probe(dev, -EINVAL, "Illegal LED id %d\n", pdev->id);
 
-	led = devm_kzalloc_obj(&pdev->dev, *led);
+	led = devm_kzalloc_obj(dev, *led);
 	if (!led)
 		return -ENOMEM;
 
@@ -662,14 +659,12 @@ static int lm3533_led_probe(struct platform_device *pdev)
 	led->cdev.groups = lm3533_led_attribute_groups;
 	led->id = pdev->id;
 
-	led->cdev.name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s-%d",
-					pdev->name, led->id);
+	led->cdev.name = devm_kasprintf(dev, GFP_KERNEL, "%s-%d", pdev->name, led->id);
 	if (!led->cdev.name)
 		return -ENOMEM;
 
 	led->cdev.default_trigger = "none";
-	device_property_read_string(&pdev->dev, "linux,default-trigger",
-				    &led->cdev.default_trigger);
+	device_property_read_string(dev, "linux,default-trigger", &led->cdev.default_trigger);
 
 	mutex_init(&led->mutex);
 
@@ -683,45 +678,30 @@ static int lm3533_led_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, led);
 
-	ret = led_classdev_register(&pdev->dev, &led->cdev);
-	if (ret) {
-		dev_err(&pdev->dev, "failed to register LED %d\n", pdev->id);
-		return ret;
-	}
+	ret = devm_led_classdev_register(dev, &led->cdev);
+	if (ret)
+		return dev_err_probe(dev, ret, "Failed to register LED %d\n", pdev->id);
 
 	led->cb.dev = led->cdev.dev;
 
-	device_property_read_u32(&pdev->dev, "led-max-microamp",
-				 &led->max_current);
+	device_property_read_u32(dev, "led-max-microamp", &led->max_current);
 	led->max_current = clamp(led->max_current, LM3533_MAX_CURRENT_MIN,
 				 LM3533_MAX_CURRENT_MAX);
 
-	device_property_read_u32(&pdev->dev, "ti,pwm-config-mask", &led->pwm);
+	device_property_read_u32(dev, "ti,pwm-config-mask", &led->pwm);
 
 	ret = lm3533_led_setup(led);
 	if (ret)
-		goto err_deregister;
-
-	ret = lm3533_ctrlbank_enable(&led->cb);
-	if (ret)
-		goto err_deregister;
-
-	return 0;
-
-err_deregister:
-	led_classdev_unregister(&led->cdev);
+		return ret;
 
-	return ret;
+	return lm3533_ctrlbank_enable(&led->cb);
 }
 
 static void lm3533_led_remove(struct platform_device *pdev)
 {
 	struct lm3533_led *led = platform_get_drvdata(pdev);
 
-	dev_dbg(&pdev->dev, "%s\n", __func__);
-
 	lm3533_ctrlbank_disable(&led->cb);
-	led_classdev_unregister(&led->cdev);
 }
 
 static void lm3533_led_shutdown(struct platform_device *pdev)
-- 
2.53.0