From: sashiko-bot@kernel.org
To: "Svyatoslav Ryhel" <clamor95@gmail.com>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH v1 1/2] leds: lm3533: Clean up probe and use managed helpers
Date: Sun, 15 Nov 2026 08:49:30 +0000 [thread overview]
Message-ID: <sashiko-outbox-215306@kernel.org> (raw)
In-Reply-To: <20261115084347.70592-2-clamor95@gmail.com>
> Clean up the lm3533 LED driver probe and remove routines by adopting
> managed device helpers and modernizing error handling:
>
> - Introduce a local `struct device *dev` variable to clean up repeated
> `&pdev->dev` references.
> - Use `dev_err_probe()` for cleaner error handling on invalid IDs and
> LED class registration failures.
> - Switch to `devm_led_classdev_register()` to automatically handle LED
> class device unregistration, removing the need for manual cleanup in
> error paths and the `remove` hook.
> - Remove redundant `dev_dbg()` statements and cleanup unused cleanup
> labels.
>
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261115084347.70592-1-clamor95@gmail.com?part=1
next prev parent reply other threads:[~2026-11-15 8:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 8:43 [PATCH v1 0/2] leds: lm3533: cleanups and support getting LED sources from DT Svyatoslav Ryhel
2026-11-15 8:43 ` [PATCH v1 1/2] leds: lm3533: Clean up probe and use managed helpers Svyatoslav Ryhel
2026-11-15 8:49 ` sashiko-bot [this message]
2026-11-15 8:43 ` [PATCH v1 2/2] leds: lm3533: Support getting LED sources from DT Svyatoslav Ryhel
2026-11-15 8:49 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-215306@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=clamor95@gmail.com \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.