All of lore.kernel.org
 help / color / mirror / Atom feed
* [sj:damon/next 37/125] mm/damon/core.c:1839:2: warning: unannotated fall-through between switch labels
@ 2026-11-15  8:33 kernel test robot
  2026-11-15 17:29 ` SJ Park
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2026-11-15  8:33 UTC (permalink / raw)
  To: SJ Park; +Cc: oe-kbuild-all

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
head:   c6e08f98976018ef8823a44dfabbfa444fdc39da
commit: 0e9dffb2f36016e675b02bf66467ef5b4fc8ed63 [37/125] mm/damon/core: introduce DAMON_FILTER_TYPE_REPORT_MADE
config: x86_64-allmodconfig (https://download.01.org/0day-ci/archive/20261115/202611150922.CN5lOX66-lkp@intel.com/config)
compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1)
rustc: rustc 1.96.0 (ac68faa20 2026-05-25)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261115/202611150922.CN5lOX66-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611150922.CN5lOX66-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> mm/damon/core.c:1839:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
    1839 |         default:
         |         ^
   mm/damon/core.c:1839:2: note: insert 'break;' to avoid fall-through
    1839 |         default:
         |         ^
         |         break; 
   1 warning generated.


vim +1839 mm/damon/core.c

9641c80162a114 SJ Park 2026-09-01  1820  
a76723d4b615bd SJ Park 2026-09-15  1821  static int damon_commit_filter(struct damon_filter *dst,
d0de4b29c722d9 SJ Park 2026-05-18  1822  		struct damon_filter *src)
d0de4b29c722d9 SJ Park 2026-05-18  1823  {
d0de4b29c722d9 SJ Park 2026-05-18  1824  	dst->type = src->type;
d0de4b29c722d9 SJ Park 2026-05-18  1825  	dst->matching = src->matching;
d0de4b29c722d9 SJ Park 2026-05-18  1826  	dst->allow = src->allow;
d9f23f2f822a59 SJ Park 2026-05-18  1827  	switch (dst->type) {
d9f23f2f822a59 SJ Park 2026-05-18  1828  	case DAMON_FILTER_TYPE_MEMCG:
d9f23f2f822a59 SJ Park 2026-05-18  1829  		dst->memcg_id = src->memcg_id;
d9f23f2f822a59 SJ Park 2026-05-18  1830  		break;
a76723d4b615bd SJ Park 2026-09-15  1831  	case DAMON_FILTER_TYPE_HUGEPAGE_SIZE:
a76723d4b615bd SJ Park 2026-09-15  1832  		if (src->range_max < src->range_min)
a76723d4b615bd SJ Park 2026-09-15  1833  			return -EINVAL;
a76723d4b615bd SJ Park 2026-09-15  1834  		dst->range_min = src->range_min;
a76723d4b615bd SJ Park 2026-09-15  1835  		dst->range_max = src->range_max;
a76723d4b615bd SJ Park 2026-09-15  1836  		break;
0e9dffb2f36016 SJ Park 2026-11-14  1837  	case DAMON_FILTER_TYPE_REPORT_MADE:
0e9dffb2f36016 SJ Park 2026-11-14  1838  		dst->report_type = src->report_type;
d9f23f2f822a59 SJ Park 2026-05-18 @1839  	default:
d9f23f2f822a59 SJ Park 2026-05-18  1840  		break;
d9f23f2f822a59 SJ Park 2026-05-18  1841  	}
a76723d4b615bd SJ Park 2026-09-15  1842  	return 0;
d0de4b29c722d9 SJ Park 2026-05-18  1843  }
d0de4b29c722d9 SJ Park 2026-05-18  1844  

:::::: The code at line 1839 was first introduced by commit
:::::: d9f23f2f822a59771fdc3cab648785d4f651e1b2 mm/damon/core: introduce DAMON_FILTER_TYPE_MEMCG

:::::: TO: SeongJae Park <sj@kernel.org>
:::::: CC: Andrew Morton <akpm@linux-foundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [sj:damon/next 37/125] mm/damon/core.c:1839:2: warning: unannotated fall-through between switch labels
  2026-11-15  8:33 [sj:damon/next 37/125] mm/damon/core.c:1839:2: warning: unannotated fall-through between switch labels kernel test robot
@ 2026-11-15 17:29 ` SJ Park
  0 siblings, 0 replies; 2+ messages in thread
From: SJ Park @ 2026-11-15 17:29 UTC (permalink / raw)
  To: kernel test robot; +Cc: SJ Park, oe-kbuild-all, damon

On Sun, 15 Nov 2026 09:33:12 +0100 kernel test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
> head:   c6e08f98976018ef8823a44dfabbfa444fdc39da
> commit: 0e9dffb2f36016e675b02bf66467ef5b4fc8ed63 [37/125] mm/damon/core: introduce DAMON_FILTER_TYPE_REPORT_MADE
> config: x86_64-allmodconfig (https://download.01.org/0day-ci/archive/20261115/202611150922.CN5lOX66-lkp@intel.com/config)
> compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1)
> rustc: rustc 1.96.0 (ac68faa20 2026-05-25)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261115/202611150922.CN5lOX66-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202611150922.CN5lOX66-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> mm/damon/core.c:1839:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
>     1839 |         default:
>          |         ^
>    mm/damon/core.c:1839:2: note: insert 'break;' to avoid fall-through
>     1839 |         default:
>          |         ^
>          |         break; 
>    1 warning generated.

Thank you for this report!  I pushed a fix to damon/next.


Thanks,
SJ

[...]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-15 17:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-15  8:33 [sj:damon/next 37/125] mm/damon/core.c:1839:2: warning: unannotated fall-through between switch labels kernel test robot
2026-11-15 17:29 ` SJ Park

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.