All of lore.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: aleksa.paunovic@htecgroup.com
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Djordje Todorovic <djordje.todorovic@htecgroup.com>,
	Anup Patel <anup@brainfault.org>,
	Thomas Gleixner <tglx@kernel.org>, Radu Rendec <radu@rendec.net>,
	Inochi Amaoto <inochiama@outlook.com>,
	Daniel Lezcano <daniel.lezcano@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@sifive.com>, Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH v3 5/8] dt-bindings: timer: Add MIPS P8700 ACLINT MTIMER
Date: Mon, 16 Nov 2026 17:30:24 +0000	[thread overview]
Message-ID: <20261116-exquisite-taco-e48371fe6912@spud> (raw)
In-Reply-To: <20261116-p8700-dts-v3-5-ec5d4b7de39f@htecgroup.com>

[-- Attachment #1: Type: text/plain, Size: 2950 bytes --]

On Mon, Nov 16, 2026 at 12:55:12PM +0100, Aleksa Paunovic via B4 Relay wrote:
> From: Aleksa Paunovic <aleksa.paunovic@htecgroup.com>
> 
> Document the MIPS P8700 ACLINT MTIMER.
> Extend support for both mtimecmp and mtime registers
> within the ACLINT MTIMER, identified via reg-names.
> 
> Signed-off-by: Aleksa Paunovic <aleksa.paunovic@htecgroup.com>

Perhaps worth mentioning that we are doing this this way because opensbi
expects this behaviour, as does u-boot, for the riscv,aclint-mtimer
compatible and we wish to align this device with it.

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

(If I end up applying this, I will amend the commit message)

Cheers,
Conor.

> ---
>  .../bindings/timer/thead,c900-aclint-mtimer.yaml   | 37 ++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/timer/thead,c900-aclint-mtimer.yaml b/Documentation/devicetree/bindings/timer/thead,c900-aclint-mtimer.yaml
> index cf7c82e980f674afcf59fc726742dc4f49c1a820..a5ebe04ade9ed61c8beac5017aab94ab12afa9ea 100644
> --- a/Documentation/devicetree/bindings/timer/thead,c900-aclint-mtimer.yaml
> +++ b/Documentation/devicetree/bindings/timer/thead,c900-aclint-mtimer.yaml
> @@ -21,13 +21,19 @@ properties:
>            - enum:
>                - anlogic,dr1v90-aclint-mtimer
>            - const: nuclei,ux900-aclint-mtimer
> +      - const: mips,p8700-aclint-mtimer
>  
>    reg:
> +    minItems: 1
>      items:
> +      - description: MTIME Registers, or MTIMECMP Registers if only one
> +          region is present
>        - description: MTIMECMP Registers
>  
>    reg-names:
> +    minItems: 1
>      items:
> +      - enum: [ mtime, mtimecmp ]
>        - const: mtimecmp
>  
>    interrupts-extended:
> @@ -42,6 +48,26 @@ required:
>    - reg-names
>    - interrupts-extended
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: mips,p8700-aclint-mtimer
> +    then:
> +      properties:
> +        reg:
> +          minItems: 2
> +        reg-names:
> +          minItems: 2
> +    else:
> +      properties:
> +        reg:
> +          maxItems: 1
> +        reg-names:
> +          items:
> +            - const: mtimecmp
> +
>  examples:
>    - |
>      timer@ac000000 {
> @@ -53,4 +79,15 @@ examples:
>        reg = <0xac000000 0x00010000>;
>        reg-names = "mtimecmp";
>      };
> +
> +  - |
> +    timer@16108050 {
> +        compatible = "mips,p8700-aclint-mtimer";
> +        reg = <0x16108050 0x8>, <0x16154000 0x7ff8>;
> +        reg-names = "mtime", "mtimecmp";
> +        interrupts-extended = <&cpu1intc 7>,
> +                              <&cpu2intc 7>,
> +                              <&cpu3intc 7>,
> +                              <&cpu4intc 7>;
> +    };
>  ...
> 
> -- 
> 2.43.0
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: aleksa.paunovic@htecgroup.com
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Djordje Todorovic <djordje.todorovic@htecgroup.com>,
	Anup Patel <anup@brainfault.org>,
	Thomas Gleixner <tglx@kernel.org>, Radu Rendec <radu@rendec.net>,
	Inochi Amaoto <inochiama@outlook.com>,
	Daniel Lezcano <daniel.lezcano@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@sifive.com>, Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH v3 5/8] dt-bindings: timer: Add MIPS P8700 ACLINT MTIMER
Date: Mon, 16 Nov 2026 17:30:24 +0000	[thread overview]
Message-ID: <20261116-exquisite-taco-e48371fe6912@spud> (raw)
In-Reply-To: <20261116-p8700-dts-v3-5-ec5d4b7de39f@htecgroup.com>


[-- Attachment #1.1: Type: text/plain, Size: 2950 bytes --]

On Mon, Nov 16, 2026 at 12:55:12PM +0100, Aleksa Paunovic via B4 Relay wrote:
> From: Aleksa Paunovic <aleksa.paunovic@htecgroup.com>
> 
> Document the MIPS P8700 ACLINT MTIMER.
> Extend support for both mtimecmp and mtime registers
> within the ACLINT MTIMER, identified via reg-names.
> 
> Signed-off-by: Aleksa Paunovic <aleksa.paunovic@htecgroup.com>

Perhaps worth mentioning that we are doing this this way because opensbi
expects this behaviour, as does u-boot, for the riscv,aclint-mtimer
compatible and we wish to align this device with it.

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

(If I end up applying this, I will amend the commit message)

Cheers,
Conor.

> ---
>  .../bindings/timer/thead,c900-aclint-mtimer.yaml   | 37 ++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/timer/thead,c900-aclint-mtimer.yaml b/Documentation/devicetree/bindings/timer/thead,c900-aclint-mtimer.yaml
> index cf7c82e980f674afcf59fc726742dc4f49c1a820..a5ebe04ade9ed61c8beac5017aab94ab12afa9ea 100644
> --- a/Documentation/devicetree/bindings/timer/thead,c900-aclint-mtimer.yaml
> +++ b/Documentation/devicetree/bindings/timer/thead,c900-aclint-mtimer.yaml
> @@ -21,13 +21,19 @@ properties:
>            - enum:
>                - anlogic,dr1v90-aclint-mtimer
>            - const: nuclei,ux900-aclint-mtimer
> +      - const: mips,p8700-aclint-mtimer
>  
>    reg:
> +    minItems: 1
>      items:
> +      - description: MTIME Registers, or MTIMECMP Registers if only one
> +          region is present
>        - description: MTIMECMP Registers
>  
>    reg-names:
> +    minItems: 1
>      items:
> +      - enum: [ mtime, mtimecmp ]
>        - const: mtimecmp
>  
>    interrupts-extended:
> @@ -42,6 +48,26 @@ required:
>    - reg-names
>    - interrupts-extended
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: mips,p8700-aclint-mtimer
> +    then:
> +      properties:
> +        reg:
> +          minItems: 2
> +        reg-names:
> +          minItems: 2
> +    else:
> +      properties:
> +        reg:
> +          maxItems: 1
> +        reg-names:
> +          items:
> +            - const: mtimecmp
> +
>  examples:
>    - |
>      timer@ac000000 {
> @@ -53,4 +79,15 @@ examples:
>        reg = <0xac000000 0x00010000>;
>        reg-names = "mtimecmp";
>      };
> +
> +  - |
> +    timer@16108050 {
> +        compatible = "mips,p8700-aclint-mtimer";
> +        reg = <0x16108050 0x8>, <0x16154000 0x7ff8>;
> +        reg-names = "mtime", "mtimecmp";
> +        interrupts-extended = <&cpu1intc 7>,
> +                              <&cpu2intc 7>,
> +                              <&cpu3intc 7>,
> +                              <&cpu4intc 7>;
> +    };
>  ...
> 
> -- 
> 2.43.0
> 
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2026-11-16 17:30 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 11:55 [PATCH v3 0/8] Add support for MIPS P8700 Aleksa Paunovic via B4 Relay
2026-11-16 11:55 ` Aleksa Paunovic
2026-11-16 11:55 ` Aleksa Paunovic via B4 Relay
2026-11-16 11:55 ` [PATCH v3 1/8] dt-bindings: riscv: cpus: add mips,p8700 Aleksa Paunovic via B4 Relay
2026-11-16 11:55   ` Aleksa Paunovic
2026-11-16 11:55   ` Aleksa Paunovic via B4 Relay
2026-11-16 11:55 ` [PATCH v3 2/8] dt-bindings: riscv: Add MIPS Boston board compatible Aleksa Paunovic via B4 Relay
2026-11-16 11:55   ` Aleksa Paunovic
2026-11-16 11:55   ` Aleksa Paunovic via B4 Relay
2026-11-16 11:55 ` [PATCH v3 3/8] dt-bindings: interrupt-controller: Add MIPS P8700 APLIC Aleksa Paunovic via B4 Relay
2026-11-16 11:55   ` Aleksa Paunovic
2026-11-16 11:55   ` Aleksa Paunovic via B4 Relay
2026-11-16 11:55 ` [PATCH v3 4/8] dt-bindings: interrupt-controller: Add MIPS P8700 ACLINT MSWI Aleksa Paunovic via B4 Relay
2026-11-16 11:55   ` Aleksa Paunovic
2026-11-16 11:55   ` Aleksa Paunovic via B4 Relay
2026-11-16 11:55 ` [PATCH v3 5/8] dt-bindings: timer: Add MIPS P8700 ACLINT MTIMER Aleksa Paunovic via B4 Relay
2026-11-16 11:55   ` Aleksa Paunovic
2026-11-16 11:55   ` Aleksa Paunovic via B4 Relay
2026-11-16 12:13   ` sashiko-bot
2026-11-16 17:30   ` Conor Dooley [this message]
2026-11-16 17:30     ` Conor Dooley
2026-11-16 11:55 ` [PATCH v3 6/8] riscv: dts: mips: Initial support for the P8700 Boston board Aleksa Paunovic via B4 Relay
2026-11-16 11:55   ` Aleksa Paunovic
2026-11-16 11:55   ` Aleksa Paunovic via B4 Relay
2026-11-16 11:55 ` [PATCH v3 7/8] MAINTAINERS: Add entry for MIPS RISC-V SoC support Aleksa Paunovic via B4 Relay
2026-11-16 11:55   ` Aleksa Paunovic
2026-11-16 11:55   ` Aleksa Paunovic via B4 Relay
2026-11-16 17:40   ` Conor Dooley
2026-11-16 17:40     ` Conor Dooley
2026-11-16 11:55 ` [PATCH v3 8/8] riscv: defconfig: Enable MIPS SoCs Aleksa Paunovic via B4 Relay
2026-11-16 11:55   ` Aleksa Paunovic
2026-11-16 11:55   ` Aleksa Paunovic via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116-exquisite-taco-e48371fe6912@spud \
    --to=conor@kernel.org \
    --cc=aleksa.paunovic@htecgroup.com \
    --cc=alex@ghiti.fr \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djordje.todorovic@htecgroup.com \
    --cc=inochiama@outlook.com \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=palmer@sifive.com \
    --cc=paul.walmsley@sifive.com \
    --cc=pjw@kernel.org \
    --cc=radu@rendec.net \
    --cc=robh@kernel.org \
    --cc=tglx@kernel.org \
    --cc=vladimir.kondratiev@mobileye.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.