All of lore.kernel.org
 help / color / mirror / Atom feed
From: Klaus Jensen <its@irrelevant.dk>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Markku Ahvenjärvi" <mankku@gmail.com>,
	qemu-stable@nongnu.org, "Klaus Jensen" <k.jensen@samsung.com>,
	"Keith Busch" <kbusch@kernel.org>,
	"Klaus Jensen" <its@irrelevant.dk>,
	"Jesper Devantier" <foss@defmacro.it>,
	qemu-block@nongnu.org
Subject: [PULL 2/7] hw/nvme: fix missed CQ updates
Date: Mon, 16 Nov 2026 22:50:08 +0100	[thread overview]
Message-ID: <20261116215014.59993-3-its@irrelevant.dk> (raw)
In-Reply-To: <20261116215014.59993-1-its@irrelevant.dk>

From: Markku Ahvenjärvi <mankku@gmail.com>

When doorbell buffers are enabled, CQ head updates may race with
completion posting. When a CQ doorbell leaves pending completions, the
event index may become stale and cause the guest to suppress the next
MMIO doorbell write. QEMU may then fail to observe that the CQ has
been drained. With legacy INTx, this can leave the interrupt asserted
indefinitely and cause an interrupt storm.

Update the CQ event index as part of doorbell processing to ensure that
subsequent head updates notify QEMU.

Cc: qemu-stable@nongnu.org
Fixes: 3f7fe8de3d49 ("hw/nvme: Implement shadow doorbell buffer support")
Fixes: 2e53b0b45024 ("hw/nvme: Use ioeventfd to handle doorbell updates")
Signed-off-by: Markku Ahvenjärvi <mankku@gmail.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
 hw/nvme/ctrl.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index e591842a4a33..52fa4b327c1f 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -4789,6 +4789,7 @@ static void nvme_cq_notifier(EventNotifier *e)
         return;
     }
 
+    nvme_update_cq_eventidx(cq);
     nvme_update_cq_head(cq);
 
     if (cq->tail == cq->head) {
@@ -8633,6 +8634,8 @@ static void nvme_process_db(NvmeCtrl *n, hwaddr addr, int val)
             }
 
             nvme_irq_deassert(n, cq);
+        } else if (n->dbbuf_enabled) {
+            nvme_update_cq_eventidx(cq);
         }
     } else {
         /* Submission queue doorbell write */
-- 
2.53.0



  parent reply	other threads:[~2026-11-16 21:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 21:50 [PULL 0/7] hw/nvme fixes Klaus Jensen
2026-11-16 21:50 ` [PULL 1/7] hw/nvme: prevent cq_pending underflow Klaus Jensen
2026-11-16 21:50 ` Klaus Jensen [this message]
2026-11-16 21:50 ` [PULL 3/7] hw/nvme: clear interrupts on controller reset Klaus Jensen
2026-11-16 21:50 ` [PULL 4/7] hw/nvme: verify source and destination lba size for copy Klaus Jensen
2026-11-16 21:50 ` [PULL 5/7] hw/nvme: reject fdp.runs smaller than the lba data size Klaus Jensen
2026-11-16 21:50 ` [PULL 6/7] hw/nvme: fix fdp reclaim unit accounting Klaus Jensen
2026-11-16 21:50 ` [PULL 7/7] hw/nvme: fix broadcast fdp events handling Klaus Jensen
2026-11-16 23:47 ` [PULL 0/7] hw/nvme fixes Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116215014.59993-3-its@irrelevant.dk \
    --to=its@irrelevant.dk \
    --cc=foss@defmacro.it \
    --cc=k.jensen@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=mankku@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.