From: Klaus Jensen <its@irrelevant.dk>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Klaus Jensen <k.jensen@samsung.com>,
qemu-stable@nongnu.org,
Jesper Wendel Devantier <foss@defmacro.it>,
Keith Busch <kbusch@kernel.org>, Klaus Jensen <its@irrelevant.dk>,
qemu-block@nongnu.org
Subject: [PULL 7/7] hw/nvme: fix broadcast fdp events handling
Date: Mon, 16 Nov 2026 22:50:13 +0100 [thread overview]
Message-ID: <20261116215014.59993-8-its@irrelevant.dk> (raw)
In-Reply-To: <20261116215014.59993-1-its@irrelevant.dk>
From: Klaus Jensen <k.jensen@samsung.com>
The Set Features handler for the FDP Events feature asserts that a
namespace is passed in the command because the feature is
namespace-specific. An invalid namespace is rejected prior to reaching
the handler, but the "broadcast nsid" (0xFFFFFFFF) is considered valid
and causes the assert to abort QEMU.
Reject it with Invalid Field in Command instead as per the
specification.
Cc: qemu-stable@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4792
Fixes: 73064edfb864 ("hw/nvme: flexible data placement emulation")
Reviewed-by: Jesper Wendel Devantier <foss@defmacro.it>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
hw/nvme/ctrl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index a0d22dacedfa..71c24dc02b67 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -6636,7 +6636,9 @@ static uint16_t nvme_set_feature_fdp_events(NvmeCtrl *n, NvmeNamespace *ns,
g_autofree uint8_t *events = NULL;
NvmeRuHandle *ruh = NULL;
- assert(ns);
+ if (!ns) {
+ return NVME_INVALID_FIELD | NVME_DNR;
+ }
if (!n->subsys || !n->subsys->endgrp.fdp.enabled) {
return NVME_FDP_DISABLED | NVME_DNR;
--
2.53.0
next prev parent reply other threads:[~2026-11-16 21:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 21:50 [PULL 0/7] hw/nvme fixes Klaus Jensen
2026-11-16 21:50 ` [PULL 1/7] hw/nvme: prevent cq_pending underflow Klaus Jensen
2026-11-16 21:50 ` [PULL 2/7] hw/nvme: fix missed CQ updates Klaus Jensen
2026-11-16 21:50 ` [PULL 3/7] hw/nvme: clear interrupts on controller reset Klaus Jensen
2026-11-16 21:50 ` [PULL 4/7] hw/nvme: verify source and destination lba size for copy Klaus Jensen
2026-11-16 21:50 ` [PULL 5/7] hw/nvme: reject fdp.runs smaller than the lba data size Klaus Jensen
2026-11-16 21:50 ` [PULL 6/7] hw/nvme: fix fdp reclaim unit accounting Klaus Jensen
2026-11-16 21:50 ` Klaus Jensen [this message]
2026-11-16 23:47 ` [PULL 0/7] hw/nvme fixes Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116215014.59993-8-its@irrelevant.dk \
--to=its@irrelevant.dk \
--cc=foss@defmacro.it \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.