From: SJ Park <sj@kernel.org>
To: Mattathias Pinchover via B4 Relay
<devnull+mattathias.pinchover.uber.com@kernel.org>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Mattathias Pinchover <mattathias.pinchover@uber.com>
Subject: Re: [PATCH 4/6] Docs/mm/damon/design: update for sz_ops_filter_passed_last
Date: Mon, 16 Nov 2026 18:25:59 -0800 [thread overview]
Message-ID: <20261117022600.110435-1-sj@kernel.org> (raw)
In-Reply-To: <20261116-damon-sz-ops-b4-v1-4-1cffe7227e6d@uber.com>
On Mon, 16 Nov 2026 19:10:07 +0000 Mattathias Pinchover via B4 Relay <devnull+mattathias.pinchover.uber.com@kernel.org> wrote:
> From: Mattathias Pinchover <mattathias.pinchover@uber.com>
>
> Update DAMON design document for the newly added DAMOS stat,
> sz_ops_filter_passed_last. Also explain that, unlike other
> stats, it is not accumulated from the beginning of the scheme's
> execution but shows the value of the last apply interval.
>
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Mattathias Pinchover <mattathias.pinchover@uber.com>
> ---
> Documentation/mm/damon/design.rst | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
> index b676be697158..e40b8c1a3461 100644
> --- a/Documentation/mm/damon/design.rst
> +++ b/Documentation/mm/damon/design.rst
> @@ -876,6 +876,8 @@ scheme's execution.
> - ``sz_tried``: Total size of regions that the scheme is tried to be applied.
> - ``sz_ops_filter_passed``: Total bytes that passed operations set
> layer-handled DAMOS filters.
> +- ``sz_ops_filter_passed_last``: Bytes that passed operations set
> + layer-handled DAMOS filters in the last ``apply_interval``.
> - ``nr_applied``: Total number of regions that the scheme is applied.
> - ``sz_applied``: Total size of regions that the scheme is applied.
> - ``qt_exceeds``: Total number of times the quota of the scheme has exceeded.
> @@ -903,6 +905,13 @@ to exclude anonymous pages and the region has only anonymous pages, or if the
> action is ``pageout`` while all pages of the region are unreclaimable, applying
> the action to the region will fail.
>
> +Unlike other stats, ``sz_ops_filter_passed_last`` is not
> +accumulated from the beginning of the scheme's execution. It is updated at the
> +end of each :ref:`apply_interval <damon_design_damos>` with the amount of
> +``sz_ops_filter_passed`` increase in the interval. Hence it shows the size of
> +memory that passed the operations set layer-handled filters in the last
> +completed ``apply_interval``.
> +
I think the description is clear enough. Could we drop this? I concern if we
will have more non-accumulated stats but forget updating this in future. We
could add this again if someone really get confused about this in future.
Other than that,
Reviewed-by: SJ Park <sj@kernel.org>
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-11-17 2:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 19:10 [PATCH 0/6] mm/damon: add sz_ops_filter_passed_last DAMOS stat Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` Mattathias Pinchover
2026-11-16 19:10 ` [PATCH 1/6] mm/damon/core: introduce sz_ops_filter_passed_last stat Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` Mattathias Pinchover
2026-11-16 19:19 ` sashiko-bot
2026-11-17 2:03 ` SJ Park
2026-11-16 19:10 ` [PATCH 2/6] mm/damon/sysfs-schemes: add sz_ops_filter_passed_last file Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` Mattathias Pinchover
2026-11-16 19:22 ` sashiko-bot
2026-11-17 2:10 ` SJ Park
2026-11-16 19:10 ` [PATCH 3/6] mm/damon/tests/core-kunit: test sz_ops_filter_passed_last Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` Mattathias Pinchover
2026-11-16 19:30 ` sashiko-bot
2026-11-17 2:22 ` SJ Park
2026-11-17 3:49 ` Aveline Noir
2026-11-17 14:16 ` SJ Park
2026-11-16 19:10 ` [PATCH 4/6] Docs/mm/damon/design: update for sz_ops_filter_passed_last Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` Mattathias Pinchover
2026-11-16 19:31 ` sashiko-bot
2026-11-17 2:25 ` SJ Park [this message]
2026-11-16 19:10 ` [PATCH 5/6] Docs/admin-guide/mm/damon/usage: " Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` Mattathias Pinchover
2026-11-16 19:32 ` sashiko-bot
2026-11-17 2:29 ` SJ Park
2026-11-16 19:10 ` [PATCH 6/6] Docs/ABI/damon: " Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` Mattathias Pinchover
2026-11-16 19:35 ` sashiko-bot
2026-11-17 2:31 ` SJ Park
2026-11-17 2:42 ` [PATCH 0/6] mm/damon: add sz_ops_filter_passed_last DAMOS stat SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117022600.110435-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=damon@lists.linux.dev \
--cc=devnull+mattathias.pinchover.uber.com@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mattathias.pinchover@uber.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.