From: SJ Park <sj@kernel.org>
To: Aveline Noir <jm5905938@gmail.com>
Cc: SJ Park <sj@kernel.org>,
mattathias.pinchover@uber.com,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
damon@lists.linux.dev,
Mattathias Pinchover via B4 Relay
<devnull+mattathias.pinchover.uber.com@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Randy Dunlap <rdunlap@infradead.org>,
sashiko-bot@kernel.org, sashiko-reviews@lists.linux.dev,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 3/6] mm/damon/tests/core-kunit: test sz_ops_filter_passed_last
Date: Tue, 17 Nov 2026 06:16:12 -0800 [thread overview]
Message-ID: <20261117141613.121192-1-sj@kernel.org> (raw)
In-Reply-To: <179488734513.2.6285120857568566018.b4-reply@b4>
On Tue, 17 Nov 2026 14:49:05 +1100 Aveline Noir <jm5905938@gmail.com> wrote:
> Hi Mattathias,
>
> On Mon, 16 Nov 2026 19:10:06 +0000 Mattathias Pinchover via B4 Relay wrote:
>
> > Add a kunit test for the sz_ops_filter_passed_last DAMOS stat.
>
> Since the motivation mentions contexts with multiple targets, maybe we
> could also cover two targets in the same context, with the stub returning
> different sizes for each? Checking their sum, then changing the sizes for
> the next interval, would verify both aggregation across targets and that
> the value only includes the latest interval.
I concern if that will make this test too complicated. Testing those would be
good, but not necessarily for sz_ops_filter_passed_last, in my opinion. Those
may deserve a separate test, if there is no test covering that.
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-11-17 14:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 19:10 [PATCH 0/6] mm/damon: add sz_ops_filter_passed_last DAMOS stat Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` Mattathias Pinchover
2026-11-16 19:10 ` [PATCH 1/6] mm/damon/core: introduce sz_ops_filter_passed_last stat Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` Mattathias Pinchover
2026-11-16 19:19 ` sashiko-bot
2026-11-17 2:03 ` SJ Park
2026-11-16 19:10 ` [PATCH 2/6] mm/damon/sysfs-schemes: add sz_ops_filter_passed_last file Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` Mattathias Pinchover
2026-11-16 19:22 ` sashiko-bot
2026-11-17 2:10 ` SJ Park
2026-11-16 19:10 ` [PATCH 3/6] mm/damon/tests/core-kunit: test sz_ops_filter_passed_last Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` Mattathias Pinchover
2026-11-16 19:30 ` sashiko-bot
2026-11-17 2:22 ` SJ Park
2026-11-17 3:49 ` Aveline Noir
2026-11-17 14:16 ` SJ Park [this message]
2026-11-16 19:10 ` [PATCH 4/6] Docs/mm/damon/design: update for sz_ops_filter_passed_last Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` Mattathias Pinchover
2026-11-16 19:31 ` sashiko-bot
2026-11-17 2:25 ` SJ Park
2026-11-16 19:10 ` [PATCH 5/6] Docs/admin-guide/mm/damon/usage: " Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` Mattathias Pinchover
2026-11-16 19:32 ` sashiko-bot
2026-11-17 2:29 ` SJ Park
2026-11-16 19:10 ` [PATCH 6/6] Docs/ABI/damon: " Mattathias Pinchover via B4 Relay
2026-11-16 19:10 ` Mattathias Pinchover
2026-11-16 19:35 ` sashiko-bot
2026-11-17 2:31 ` SJ Park
2026-11-17 2:42 ` [PATCH 0/6] mm/damon: add sz_ops_filter_passed_last DAMOS stat SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117141613.121192-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=damon@lists.linux.dev \
--cc=devnull+mattathias.pinchover.uber.com@kernel.org \
--cc=jm5905938@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mattathias.pinchover@uber.com \
--cc=rdunlap@infradead.org \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.