All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH rtw-next v4] wifi: rtw89: acpi: skip _DSM when there is no ACPI companion
@ 2026-11-17  2:46 Rosen Penev
  2026-11-17  8:28 ` Ping-Ke Shih
  0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-11-17  2:46 UTC (permalink / raw)
  To: linux-wireless; +Cc: Ping-Ke Shih

When the WiFi device has no ACPI companion, ACPI_HANDLE(rtwdev->dev) is
NULL and rtw89_acpi_evaluate_dsm() still calls acpi_evaluate_dsm().
acpi_evaluate_object() then returns AE_BAD_PARAMETER and ACPI core
warns on every probe:

  ACPI: \: failed to evaluate _DSM e8c3a8d2-694b-004f-82bd-fe8607803aa7 rev:0 func:10 (0x1001)
  ACPI: \: failed to evaluate _DSM e8c3a8d2-694b-004f-82bd-fe8607803aa7 rev:0 func:6 (0x1001)

All callers already treat failure as "no policy provided by the
platform", so this is only noise.  Bail out early in that case.

Seen on an RTL8852BE in a desktop PCIe slot.

Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 v4: add Acked-by. Remove stale commit wording.
 v3: remove acpi_check_dsm()
 v2: check handle separately. Remove Fixes.
 drivers/net/wireless/realtek/rtw89/acpi.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw89/acpi.c b/drivers/net/wireless/realtek/rtw89/acpi.c
index ebb6cf555747..d8cf8eb2527b 100644
--- a/drivers/net/wireless/realtek/rtw89/acpi.c
+++ b/drivers/net/wireless/realtek/rtw89/acpi.c
@@ -372,11 +372,16 @@ int rtw89_acpi_evaluate_dsm(struct rtw89_dev *rtwdev,
 			    enum rtw89_acpi_dsm_func func,
 			    struct rtw89_acpi_dsm_result *res)
 {
+	acpi_handle handle = ACPI_HANDLE(rtwdev->dev);
 	union acpi_object *obj;
 	int ret;
 
-	obj = acpi_evaluate_dsm(ACPI_HANDLE(rtwdev->dev), &rtw89_guid,
-				0, func, NULL);
+	if (!handle) {
+		rtw89_debug(rtwdev, RTW89_DBG_ACPI, "acpi dsm no handle\n");
+		return -ENODEV;
+	}
+
+	obj = acpi_evaluate_dsm(handle, &rtw89_guid, 0, func, NULL);
 	if (!obj) {
 		rtw89_debug(rtwdev, RTW89_DBG_ACPI,
 			    "acpi dsm fail to evaluate func: %d\n", func);
-- 
2.56.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH rtw-next v4] wifi: rtw89: acpi: skip _DSM when there is no ACPI companion
  2026-11-17  2:46 [PATCH rtw-next v4] wifi: rtw89: acpi: skip _DSM when there is no ACPI companion Rosen Penev
@ 2026-11-17  8:28 ` Ping-Ke Shih
  0 siblings, 0 replies; 2+ messages in thread
From: Ping-Ke Shih @ 2026-11-17  8:28 UTC (permalink / raw)
  To: Rosen Penev, linux-wireless; +Cc: Ping-Ke Shih

Rosen Penev <rosenp@gmail.com> wrote:

> When the WiFi device has no ACPI companion, ACPI_HANDLE(rtwdev->dev) is
> NULL and rtw89_acpi_evaluate_dsm() still calls acpi_evaluate_dsm().
> acpi_evaluate_object() then returns AE_BAD_PARAMETER and ACPI core
> warns on every probe:
> 
>   ACPI: \: failed to evaluate _DSM e8c3a8d2-694b-004f-82bd-fe8607803aa7 rev:0 func:10 (0x1001)
>   ACPI: \: failed to evaluate _DSM e8c3a8d2-694b-004f-82bd-fe8607803aa7 rev:0 func:6 (0x1001)
> 
> All callers already treat failure as "no policy provided by the
> platform", so this is only noise.  Bail out early in that case.
> 
> Seen on an RTL8852BE in a desktop PCIe slot.
> 
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

1 patch(es) applied to rtw-next branch of rtw.git, thanks.

badf4c3c7679 wifi: rtw89: acpi: skip _DSM when there is no ACPI companion

---
https://github.com/pkshih/rtw.git


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-17  8:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17  2:46 [PATCH rtw-next v4] wifi: rtw89: acpi: skip _DSM when there is no ACPI companion Rosen Penev
2026-11-17  8:28 ` Ping-Ke Shih

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.