All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yixun Lan <dlan@kernel.org>
To: Hung-Chun Tseng <alan.tseng.cs@gmail.com>
Cc: u-boot@lists.u-boot-project.org, u-boot-spacemit@groups.io,
	Bruno Banelli <bbanelli@gmail.com>, Tom Rini <trini@konsulko.com>,
	Eric Chung <eric.chung@riscstar.com>,
	Dave Klotz <DaveWK225@protonmail.com>,
	Guodong Xu <docular.xu@gmail.com>,
	Raymond Mao <raymond.mao@riscstar.com>
Subject: Re: [PATCH v3] board: spacemit: k1: Add the M1 Jupiter's product name
Date: Tue, 17 Nov 2026 08:00:16 +0000	[thread overview]
Message-ID: <20261117080016-GKI100523@kernel.org> (raw)
In-Reply-To: <20261117025737.3153817-1-alan.tseng.cs@gmail.com>

Hi Hung-Chun,

CC to the list

On 10:57 Tue 17 Nov     , Hung-Chun Tseng wrote:
> Hi Yixun,
> 
> On Tue, 17 Nov 2026 02:53:39 +0000, Yixun Lan wrote:
> > With K1 board map, it will derive the device tree name from the TLV
> > product name held in the board EEPROM, and problem here is that it
> > only recognises boards whose product name starts with "k1-x_".
> 
> Nit: k1_board_map matches the full names it lists, so it is the
> "m1-x_milkv-jupiter" name that is missing rather than the prefix.
> 
I generally find it matching current situation which recognise boards
with "k1-x" prefix only, although we update algorithm now for full
product name, it's ok and I will leave as it is for this version

> > Add an entry to map the M1 Milv-V jupiter board to correct device tree.
> 
> s/Milv-V jupiter/Milk-V Jupiter/
> 
> Either can be fixed when applying.
> 
I'd rather not sending another new version, will fix when applying

> Reviewed-by: Hung-Chun Tseng <alan.tseng.cs@gmail.com>
> 
Thanks for review

-- 
Yixun Lan (dlan)

  parent reply	other threads:[~2026-11-17  8:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  2:53 [PATCH v3] board: spacemit: k1: Add the M1 Jupiter's product name Yixun Lan
     [not found] ` <20261117025737.3153817-1-alan.tseng.cs@gmail.com>
2026-11-17  8:00   ` Yixun Lan [this message]
2026-11-18  6:14 ` Yixun Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117080016-GKI100523@kernel.org \
    --to=dlan@kernel.org \
    --cc=DaveWK225@protonmail.com \
    --cc=alan.tseng.cs@gmail.com \
    --cc=bbanelli@gmail.com \
    --cc=docular.xu@gmail.com \
    --cc=eric.chung@riscstar.com \
    --cc=raymond.mao@riscstar.com \
    --cc=trini@konsulko.com \
    --cc=u-boot-spacemit@groups.io \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.