* [PATCH v3] board: spacemit: k1: Add the M1 Jupiter's product name
@ 2026-11-17 2:53 Yixun Lan
[not found] ` <20261117025737.3153817-1-alan.tseng.cs@gmail.com>
2026-11-18 6:14 ` Yixun Lan
0 siblings, 2 replies; 3+ messages in thread
From: Yixun Lan @ 2026-11-17 2:53 UTC (permalink / raw)
To: u-boot, u-boot-spacemit
Cc: Bruno Banelli, Eric Chung, Tom Rini, Guodong Xu, Raymond Mao,
Dave Klotz, Hung-Chun Tseng, Yixun Lan
From: Bruno Banelli <bbanelli@gmail.com>
With K1 board map, it will derive the device tree name from the TLV
product name held in the board EEPROM, and problem here is that it
only recognises boards whose product name starts with "k1-x_".
Boards fitted with the higher-binned M1 part report an "m1-x_" prefix
instead. On those, fdt_name is left empty and the function silently
falls back to default device tree which defined in the config option
of CONFIG_DEFAULT_DEVICE_TREE ("k1-musepi-pro"), so an M1 board selects
the wrong device tree with no error or warning.
A Milk-V Jupiter fitted with an M1 reads, from the 24c04 at i2c2 0x50:
00: 54 6c 76 49 6e 66 6f 00 01 00 1a 21 12 6d 31 2d TlvInfo....!.m1-
10: 78 5f 6d 69 6c 6b 76 2d 6a 75 70 69 74 65 72 fe x_milkv-jupiter.
i.e. TLV code 0x21 (product name), length 0x12, "m1-x_milkv-jupiter".
Add an entry to map the M1 Milv-V jupiter board to correct device tree.
Signed-off-by: Bruno Banelli <bbanelli@gmail.com>
Signed-off-by: Yixun Lan <dlan@kernel.org>
---
I've dropped all Reviewed-by tags due to the change.
---
Changes in v3:
- update commit message
- Link to v2: https://patch.msgid.link/20261111-04-k1-milkv-m1-prefix-v2-1-3dae0c911965@kernel.org
Changes in v2:
- rework according to recent main code
- Link to v1: https://patch.msgid.link/20260825065257.69536-1-bbanelli@gmail.com
---
board/spacemit/k1/spl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/board/spacemit/k1/spl.c b/board/spacemit/k1/spl.c
index 0ce0a811830..8931c5f5362 100644
--- a/board/spacemit/k1/spl.c
+++ b/board/spacemit/k1/spl.c
@@ -149,6 +149,7 @@ static const struct {
{ "k1-x_MUSE-Pi-Pro", "spacemit/k1-musepi-pro" },
{ "k1-x_deb1", "spacemit/k1-bananapi-f3" },
{ "k1-x_milkv-jupiter", "spacemit/k1-milkv-jupiter" },
+ { "m1-x_milkv-jupiter", "spacemit/k1-milkv-jupiter" },
};
int read_product_name(char *name, int size)
---
base-commit: 8ea02c99391d2d922810065206721ead2863f075
change-id: 20261111-04-k1-milkv-m1-prefix-762704637cba
Best regards,
--
Yixun Lan <dlan@kernel.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] board: spacemit: k1: Add the M1 Jupiter's product name
[not found] ` <20261117025737.3153817-1-alan.tseng.cs@gmail.com>
@ 2026-11-17 8:00 ` Yixun Lan
0 siblings, 0 replies; 3+ messages in thread
From: Yixun Lan @ 2026-11-17 8:00 UTC (permalink / raw)
To: Hung-Chun Tseng
Cc: u-boot, u-boot-spacemit, Bruno Banelli, Tom Rini, Eric Chung,
Dave Klotz, Guodong Xu, Raymond Mao
Hi Hung-Chun,
CC to the list
On 10:57 Tue 17 Nov , Hung-Chun Tseng wrote:
> Hi Yixun,
>
> On Tue, 17 Nov 2026 02:53:39 +0000, Yixun Lan wrote:
> > With K1 board map, it will derive the device tree name from the TLV
> > product name held in the board EEPROM, and problem here is that it
> > only recognises boards whose product name starts with "k1-x_".
>
> Nit: k1_board_map matches the full names it lists, so it is the
> "m1-x_milkv-jupiter" name that is missing rather than the prefix.
>
I generally find it matching current situation which recognise boards
with "k1-x" prefix only, although we update algorithm now for full
product name, it's ok and I will leave as it is for this version
> > Add an entry to map the M1 Milv-V jupiter board to correct device tree.
>
> s/Milv-V jupiter/Milk-V Jupiter/
>
> Either can be fixed when applying.
>
I'd rather not sending another new version, will fix when applying
> Reviewed-by: Hung-Chun Tseng <alan.tseng.cs@gmail.com>
>
Thanks for review
--
Yixun Lan (dlan)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] board: spacemit: k1: Add the M1 Jupiter's product name
2026-11-17 2:53 [PATCH v3] board: spacemit: k1: Add the M1 Jupiter's product name Yixun Lan
[not found] ` <20261117025737.3153817-1-alan.tseng.cs@gmail.com>
@ 2026-11-18 6:14 ` Yixun Lan
1 sibling, 0 replies; 3+ messages in thread
From: Yixun Lan @ 2026-11-18 6:14 UTC (permalink / raw)
To: u-boot, u-boot-spacemit, Yixun Lan
Cc: Bruno Banelli, Eric Chung, Tom Rini, Guodong Xu, Raymond Mao,
Dave Klotz, Hung-Chun Tseng
On Tue, 17 Nov 2026 02:53:39 +0000, Yixun Lan wrote:
> With K1 board map, it will derive the device tree name from the TLV
> product name held in the board EEPROM, and problem here is that it
> only recognises boards whose product name starts with "k1-x_".
>
> Boards fitted with the higher-binned M1 part report an "m1-x_" prefix
> instead. On those, fdt_name is left empty and the function silently
> falls back to default device tree which defined in the config option
> of CONFIG_DEFAULT_DEVICE_TREE ("k1-musepi-pro"), so an M1 board selects
> the wrong device tree with no error or warning.
>
> [...]
Applied, thanks! Queued in SpacemiT custodian tree, for-main branch
[1/1] board: spacemit: k1: Add the M1 Jupiter's product name
https://git.u-boot-project.org/u-boot/custodians/u-boot-spacemit/-/commit/76e0d868ef47bf731ba62115de24fad91a5f81d0
Best regards,
--
Yixun Lan <dlan@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-18 6:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 2:53 [PATCH v3] board: spacemit: k1: Add the M1 Jupiter's product name Yixun Lan
[not found] ` <20261117025737.3153817-1-alan.tseng.cs@gmail.com>
2026-11-17 8:00 ` Yixun Lan
2026-11-18 6:14 ` Yixun Lan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.