From: Peder Bergan via B4 Relay <devnull+peder.bergan.gmail.com@kernel.org>
To: Miguel Ojeda <ojeda@kernel.org>
Cc: "Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Tamir Duberstein" <tamird@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Onur Özkan" <work@onurozkan.dev>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nsc@kernel.org>,
"Sami Tolvanen" <samitolvanen@google.com>,
"Matthew Maurer" <mmaurer@google.com>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Gwan-gyeong Mun" <gwan-gyeong.mun@intel.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org, linux-modules@vger.kernel.org
Subject: [PATCH] rust: kbuild: generate a symbol version for rust_build_error
Date: Wed, 18 Nov 2026 10:08:50 +0100 [thread overview]
Message-ID: <20261118-fix-rust-build-error-modversions-v1-1-7c1023764f30@gmail.com> (raw)
From: Peder Bergan <peder.bergan@gmail.com>
CONFIG_RUST_BUILD_ASSERT_ALLOW exports rust_build_error to modules.
When CONFIG_MODVERSIONS is also enabled, modpost warns that the export
has no symbol version and records a zero CRC because the build_error.o
rule skips gendwarfksyms.
Generate the checksum from build_error.o with the existing Rust library
rule. Make build_error.o depend on rust/Makefile when module versioning
is enabled so incremental builds pick up the change. Kbuild's saved
rustc command does not include the gendwarfksyms step.
Fixes: ac61506bf2d1 ("rust: Use gendwarfksyms + extended modversions for CONFIG_MODVERSIONS")
Reported-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Closes: https://github.com/Rust-for-Linux/linux/issues/1201
Signed-off-by: Peder Bergan <peder.bergan@gmail.com>
---
An incremental x86-64 build with LLVM=1 CLIPPY=1 clears the modpost
warning. The kernel export and a Rust module that references it both
record the same nonzero CRC.
OpenAI Codex assisted with coding and testing.
---
rust/Makefile | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/rust/Makefile b/rust/Makefile
index 0165626decbe..dd5b0a958d0c 100644
--- a/rust/Makefile
+++ b/rust/Makefile
@@ -773,8 +773,9 @@ $(obj)/pin_init.o: $(src)/pin-init/src/lib.rs $(obj)/compiler_builtins.o \
# treated as such so that we pass the same flags. Otherwise, for instance,
# `rustc` will complain about missing sanitizer flags causing an ABI mismatch.
$(obj)/build_error.o: private is-kernel-object := y
-$(obj)/build_error.o: private skip_gendwarfksyms = 1
-$(obj)/build_error.o: $(src)/build_error.rs $(obj)/compiler_builtins.o FORCE
+# Rebuild when the symbol version generation rule changes.
+$(obj)/build_error.o: $(src)/build_error.rs $(obj)/compiler_builtins.o \
+ $(if $(CONFIG_MODVERSIONS),$(src)/Makefile) FORCE
+$(call if_changed_rule,rustc_library)
$(obj)/ffi.o: private skip_gendwarfksyms = 1
---
base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3
change-id: 20261118-fix-rust-build-error-modversions-4af535edc9b2
Best regards,
--
Peder Bergan <peder.bergan@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Peder Bergan <peder.bergan@gmail.com>
To: Miguel Ojeda <ojeda@kernel.org>
Cc: "Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Tamir Duberstein" <tamird@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Onur Özkan" <work@onurozkan.dev>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nsc@kernel.org>,
"Sami Tolvanen" <samitolvanen@google.com>,
"Matthew Maurer" <mmaurer@google.com>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Gwan-gyeong Mun" <gwan-gyeong.mun@intel.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org, linux-modules@vger.kernel.org
Subject: [PATCH] rust: kbuild: generate a symbol version for rust_build_error
Date: Wed, 18 Nov 2026 10:08:50 +0100 [thread overview]
Message-ID: <20261118-fix-rust-build-error-modversions-v1-1-7c1023764f30@gmail.com> (raw)
CONFIG_RUST_BUILD_ASSERT_ALLOW exports rust_build_error to modules.
When CONFIG_MODVERSIONS is also enabled, modpost warns that the export
has no symbol version and records a zero CRC because the build_error.o
rule skips gendwarfksyms.
Generate the checksum from build_error.o with the existing Rust library
rule. Make build_error.o depend on rust/Makefile when module versioning
is enabled so incremental builds pick up the change. Kbuild's saved
rustc command does not include the gendwarfksyms step.
Fixes: ac61506bf2d1 ("rust: Use gendwarfksyms + extended modversions for CONFIG_MODVERSIONS")
Reported-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Closes: https://github.com/Rust-for-Linux/linux/issues/1201
Signed-off-by: Peder Bergan <peder.bergan@gmail.com>
---
An incremental x86-64 build with LLVM=1 CLIPPY=1 clears the modpost
warning. The kernel export and a Rust module that references it both
record the same nonzero CRC.
OpenAI Codex assisted with coding and testing.
---
rust/Makefile | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/rust/Makefile b/rust/Makefile
index 0165626decbe..dd5b0a958d0c 100644
--- a/rust/Makefile
+++ b/rust/Makefile
@@ -773,8 +773,9 @@ $(obj)/pin_init.o: $(src)/pin-init/src/lib.rs $(obj)/compiler_builtins.o \
# treated as such so that we pass the same flags. Otherwise, for instance,
# `rustc` will complain about missing sanitizer flags causing an ABI mismatch.
$(obj)/build_error.o: private is-kernel-object := y
-$(obj)/build_error.o: private skip_gendwarfksyms = 1
-$(obj)/build_error.o: $(src)/build_error.rs $(obj)/compiler_builtins.o FORCE
+# Rebuild when the symbol version generation rule changes.
+$(obj)/build_error.o: $(src)/build_error.rs $(obj)/compiler_builtins.o \
+ $(if $(CONFIG_MODVERSIONS),$(src)/Makefile) FORCE
+$(call if_changed_rule,rustc_library)
$(obj)/ffi.o: private skip_gendwarfksyms = 1
---
base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3
change-id: 20261118-fix-rust-build-error-modversions-4af535edc9b2
Best regards,
--
Peder Bergan <peder.bergan@gmail.com>
next reply other threads:[~2026-11-18 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 9:08 Peder Bergan via B4 Relay [this message]
2026-11-18 9:08 ` [PATCH] rust: kbuild: generate a symbol version for rust_build_error Peder Bergan
2026-11-19 0:44 ` Sami Tolvanen
2026-11-19 2:24 ` Gary Guo
2026-11-19 9:08 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118-fix-rust-build-error-modversions-v1-1-7c1023764f30@gmail.com \
--to=devnull+peder.bergan.gmail.com@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=gwan-gyeong.mun@intel.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=masahiroy@kernel.org \
--cc=mmaurer@google.com \
--cc=nathan@kernel.org \
--cc=nsc@kernel.org \
--cc=ojeda@kernel.org \
--cc=peder.bergan@gmail.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=samitolvanen@google.com \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.