All of lore.kernel.org
 help / color / mirror / Atom feed
From: SJ Park <sj@kernel.org>
Cc: SJ Park <sj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	damon@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [RFC PATCH v2 15/27] mm/damon/sysfs: add filter_report_type file under probe filter directory
Date: Tue, 17 Nov 2026 18:22:10 -0800	[thread overview]
Message-ID: <20261118022225.100659-16-sj@kernel.org> (raw)
In-Reply-To: <20261118022225.100659-1-sj@kernel.org>

Add a sysfs file, filter_report_type, under probe filter directory.  It
receives damon_report_type from the user.  Reuse
damon_sysfs_report_type_name struct for user keyword matching.  Move the
definition instead of forward declaration, as the code change is small
enough at this stage.

Signed-off-by: SJ Park <sj@kernel.org>
---
 mm/damon/sysfs.c | 61 +++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 52 insertions(+), 9 deletions(-)

diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
index 7cdbe2fedf7d8..ca971cf1dcf6d 100644
--- a/mm/damon/sysfs.c
+++ b/mm/damon/sysfs.c
@@ -977,6 +977,7 @@ struct damon_sysfs_filter {
 	char *path;
 	unsigned long range_min;
 	unsigned long range_max;
+	enum damon_report_type report_type;
 };
 
 static struct damon_sysfs_filter *damon_sysfs_filter_alloc(void)
@@ -1175,6 +1176,53 @@ static ssize_t max_store(struct kobject *kobj,
 	return err ? err : count;
 }
 
+struct damon_sysfs_report_type_name {
+	enum damon_report_type type;
+	char *name;
+};
+
+static const struct damon_sysfs_report_type_name
+damon_sysfs_report_type_names[] = {
+};
+
+static ssize_t filter_report_type_show(struct kobject *kobj,
+		struct kobj_attribute *attr, char *buf)
+{
+	struct damon_sysfs_filter *filter = container_of(kobj,
+			struct damon_sysfs_filter, kobj);
+	int i;
+
+	for (i = 0; i < ARRAY_SIZE(damon_sysfs_report_type_names); i++) {
+		const struct damon_sysfs_report_type_name *type_name;
+
+		type_name = &damon_sysfs_report_type_names[i];
+		if (type_name->type == filter->report_type)
+			return sysfs_emit(buf, "%s\n", type_name->name);
+	}
+	return -EINVAL;
+}
+
+static ssize_t filter_report_type_store(struct kobject *kobj,
+		struct kobj_attribute *attr, const char *buf, size_t count)
+{
+	struct damon_sysfs_filter *filter = container_of(kobj,
+			struct damon_sysfs_filter, kobj);
+	ssize_t ret = -EINVAL;
+	int i;
+
+	for (i = 0; i < ARRAY_SIZE(damon_sysfs_report_type_names); i++) {
+		const struct damon_sysfs_report_type_name *type_name;
+
+		type_name = &damon_sysfs_report_type_names[i];
+		if (sysfs_streq(buf, type_name->name)) {
+			filter->report_type = type_name->type;
+			ret = count;
+			break;
+		}
+	}
+	return ret;
+}
+
 static void damon_sysfs_filter_release(struct kobject *kobj)
 {
 	struct damon_sysfs_filter *filter = container_of(kobj,
@@ -1202,6 +1250,9 @@ static struct kobj_attribute damon_sysfs_filter_min_attr =
 static struct kobj_attribute damon_sysfs_filter_max_attr =
 		__ATTR_RW_MODE(max, 0600);
 
+static struct kobj_attribute damon_sysfs_filter_filter_report_type_attr =
+		__ATTR_RW_MODE(filter_report_type, 0600);
+
 static struct attribute *damon_sysfs_filter_attrs[] = {
 	&damon_sysfs_filter_type_attr.attr,
 	&damon_sysfs_filter_matching_attr.attr,
@@ -1209,6 +1260,7 @@ static struct attribute *damon_sysfs_filter_attrs[] = {
 	&damon_sysfs_filter_path_attr.attr,
 	&damon_sysfs_filter_min_attr.attr,
 	&damon_sysfs_filter_max_attr.attr,
+	&damon_sysfs_filter_filter_report_type_attr.attr,
 	NULL,
 };
 ATTRIBUTE_GROUPS(damon_sysfs_filter);
@@ -2992,15 +3044,6 @@ static struct damon_sysfs_producer *damon_sysfs_producer_alloc(void)
 	return kzalloc_obj(struct damon_sysfs_producer);
 }
 
-struct damon_sysfs_report_type_name {
-	enum damon_report_type type;
-	char *name;
-};
-
-static const struct damon_sysfs_report_type_name
-damon_sysfs_report_type_names[] = {
-};
-
 static ssize_t report_type_show(struct kobject *kobj,
 		struct kobj_attribute *attr, char *buf)
 {
-- 
2.47.3

  parent reply	other threads:[~2026-11-18  2:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  2:21 [RFC PATCH v2 00/27] mm/damon: let users report their data attribute findings SJ Park
2026-11-18  2:21 ` [RFC PATCH v2 01/27] mm/damon/api: introduce struct damon_report SJ Park
2026-11-18  2:21 ` [RFC PATCH v2 02/27] mm/damon/core: implement data attribute report queue SJ Park
2026-11-18  2:21 ` [RFC PATCH v2 03/27] mm/damon/core: introduce damon_submit_report() SJ Park
2026-11-18  2:21 ` [RFC PATCH v2 04/27] mm/damon/sysfs: add admin/reports/ directory SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 05/27] mm/damon/sysfs: add reports/producers/ directory SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 06/27] mm/damon/sysfs: add producers/nr_producers file SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 07/27] mm/damon/sysfs: implement report producer directory SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 08/27] mm/damon/sysfs: implement report producer type and state files SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 09/27] Docs/mm/damon/design: update for report system SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 10/27] Docs/admin-guide/mm/damon/usage: update for report producer sysfs SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 11/27] Docs/ABI/damon: update for report producer sysfs files SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 12/27] mm/damon/core: introduce DAMON_FILTER_TYPE_REPORT_MADE SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 13/27] mm/damon/core: introduce damon_report_exist() SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 14/27] mm/damon/paddr: support REPORT_MADE type probe filter SJ Park
2026-11-18  2:22 ` SJ Park [this message]
2026-11-18  2:22 ` [RFC PATCH v2 16/27] mm/damon/sysfs: support REPORT_MADE type probe filter setup SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 17/27] Docs/mm/damon/design: update for report_made probe filter type SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 18/27] Docs/admin-guide/mm/damon/usage: update for REPORT_MADE probe filter SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 19/27] Docs/ABI/damon: " SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 20/27] mm/damon/api: introduce user_report report type SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 21/27] mm/damon/sysfs: add user_report support for report type input SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 22/27] mm/damon/sysfs: implement report producer addr_{start,end} files SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 23/27] mm/damon/sysfs: implement submit command for report producer SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 24/27] selftests/damon/sysfs.sh: add basic tests for admin/reports/ SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 25/27] Docs/mm/damon/design: update for user report support SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 26/27] Docs/admin-guide/mm/damon/usage: update for user_report " SJ Park
2026-11-18  2:22 ` [RFC PATCH v2 27/27] Docs/ABI/damon: " SJ Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118022225.100659-16-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.